Page 5 of 30

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 2:28 am
by uksitebuilder
heinzchen wrote:I get this error message:

Warning: sprintf() [function.sprintf]: Too few arguments /var/www/xxxxx/catalog/controller/account/success.php in on line 31

what's going wrong?
Custom language or default english ?

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 2:33 am
by Qphoria
Seeing this on a few different websites, different hosts.

If there are many options, sometimes the option dropdown is not populating:
Image

Refresh will get them loading, but the problem is that if you save when its like this, then it will throw a php error and the item will be deleted from the list of options. Something with the ajax load or something.

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 2:41 am
by uksitebuilder
Hey Q, that used to happen to me on 1.5.0 etc and may be a coincidence, until I turned (your gonna hate me for this) UseCache to True in vQmod ;)

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 4:32 am
by Qphoria
uksitebuilder wrote:Hey Q, that used to happen to me on 1.5.0 etc and may be a coincidence, until I turned (your gonna hate me for this) UseCache to True in vQmod ;)
Yea but I would expect that if it is querying and bringing back some of it, why not the first field. if it was the old vQmod issue it would normally throw an error like it did in 1.4.x with the address form. I dunno.. maybe

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 5:01 am
by heinzchen
Custom language or default english ?
german language.
I think 'text_message' is missing in both (german/english) language files, is this right ?

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 7:34 pm
by i2Paq

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 7:56 pm
by Daniel
heinzchen wrote:
Custom language or default english ?
german language.
I think 'text_message' is missing in both (german/english) language files, is this right ?
don;t report this as a bug because opencart does not come with the german language. you download that separately from the extension section.

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 10:18 pm
by eddy
eddy wrote:I am getting 403 error:
Forbidden
You don't have permission to access /shop/index.php on this server.
when trying to search, with "search in description" selected.

If anyone else runs in to this problem, I solved mine by renaming .htaccess.txt to .htaccess

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sat Oct 08, 2011 10:35 pm
by jcsmithy
category controller file.

Code: Select all

if ($this->config->get('config_review_status')) {
	$rating = (int)$result['rating'];
} else {
	$rating = false;
}
				
$this->data['products'][] = array(
	'product_id'  => $result['product_id'],
	'thumb'       => $image,
	'name'        => $result['name'],
	'description' => mb_substr(strip_tags(html_entity_decode($result['description'], ENT_QUOTES, 'UTF-8')), 0, 100) . '..',
	'price'       => $price,
	'special'     => $special,
	'tax'         => $tax,
	'rating'      => $result['rating'],
	'reviews'     => sprintf($this->language->get('text_reviews'), (int)$result['reviews']),
	'href'        => $this->url->link('product/product', 'path=' . $this->request->get['path'] . '&product_id=' . $result['product_id'])
);
Rating value is pulled straight from the db query, ignoring the admin review status check coded just above.

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 3:17 am
by Qphoria
BUG: UPS and USPS won't work at the same time....

This is because of the new price sorting function that I put into both shipping options. Didn't realize it would leave them loaded. So it actually errors out because it is being redeclared if they are both enabled. This is in 1.5.1.3 only.

The quick fix:
1. EDIT: catalog/model/shipping/ups.php

2. FIND:
function comparecost ($a, $b) {
return $a['cost'] > $b['cost'];
}
uasort($quote_data, 'comparecost');
3. REPLACE WITH:
2. FIND:
function upscomparecost ($a, $b) {
return $a['cost'] > $b['cost'];
}
uasort($quote_data, 'upscomparecost');

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 3:47 am
by Daniel
Qphoria wrote:BUG: UPS and USPS won't work at the same time....

This is because of the new price sorting function that I put into both shipping options. Didn't realize it would leave them loaded. So it actually errors out because it is being redeclared if they are both enabled. This is in 1.5.1.3 only.

The fix:
1. EDIT: catalog/model/shipping/ups.php

2. FIND:
function comparecost ($a, $b) {
return $a['cost'] > $b['cost'];
}
uasort($quote_data, 'comparecost');
3. REPLACE WITH:
2. FIND:
function upscomparecost ($a, $b) {
return $a['cost'] > $b['cost'];
}
uasort($quote_data, 'upscomparecost');

declaring functions in side of classes is not the way to do things!

try this:

uasort($quote_data, array($this, 'comparecost'));

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 4:11 am
by Qphoria
Daniel wrote: declaring functions in side of classes is not the way to do things!

try this:

uasort($quote_data, array($this, 'comparecost'));
But then where should I put the actual compare function?
Maybe a new helper class?

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 5:27 am
by bluelayer
in 1.5.1.2 i seach for "ano: 2011" returns 40 products +/-, in 1.5.1.3.1 return +1000 products... is this normal?

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 2:00 pm
by Daniel
Qphoria wrote:
Daniel wrote: declaring functions in side of classes is not the way to do things!

try this:

uasort($quote_data, array($this, 'comparecost'));
But then where should I put the actual compare function?
Maybe a new helper class?
create a method in the extension.

http://code.google.com/p/opencart/source/detail?r=663

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 4:23 pm
by opencartrules
Regarding the issue :

* Store Logos do not show in emails when using Thunderbird or IE9 or IE8 with Windows
( option to allow graphics with OpenCart mails that should contain them is not present )
just tested with IE9 on gmail and images do not show. OpenCart is not responsible for this. i can not force internet explorer to show images in gmail.
OpenCart 1.5.1.3 Bug Thread

Postby Daniel » Fri Oct 07, 2011 1:43 pm
I can always make the images linked back to the owners site. It would be easier and make things more compatible.
They would of course have to allow the mail to show the images. The only problem might be if some one has hot linking protection on.
Is this a problem related to the latest release 1.5.1.3.1? I got the impression when looking at the thread. We have not had a chance to test it ourselves with FF 7.0.1 on Mac OS X and Safari. We use HTML Professional and Design Extension.

Will you post a solution Daniel in SVN?

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 8:13 pm
by Qphoria
Daniel wrote:
Qphoria wrote:
Daniel wrote: declaring functions in side of classes is not the way to do things!

try this:

uasort($quote_data, array($this, 'comparecost'));
But then where should I put the actual compare function?
Maybe a new helper class?
create a method in the extension.

http://code.google.com/p/opencart/source/detail?r=663
Well yea that is what I would normally do.. But I thought it different with uasort.
Also why is it

Code: Select all

uasort($quote_data, array($this, 'comparecost'));
instead of

Code: Select all

uasort($quote_data, $this->comparecost);

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 9:23 pm
by Daniel
good point!

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 9:27 pm
by Daniel
opencartrules wrote:Regarding the issue :

* Store Logos do not show in emails when using Thunderbird or IE9 or IE8 with Windows
( option to allow graphics with OpenCart mails that should contain them is not present )
just tested with IE9 on gmail and images do not show. OpenCart is not responsible for this. i can not force internet explorer to show images in gmail.
OpenCart 1.5.1.3 Bug Thread

Postby Daniel » Fri Oct 07, 2011 1:43 pm
I can always make the images linked back to the owners site. It would be easier and make things more compatible.
They would of course have to allow the mail to show the images. The only problem might be if some one has hot linking protection on.
Is this a problem related to the latest release 1.5.1.3.1? I got the impression when looking at the thread. We have not had a chance to test it ourselves with FF 7.0.1 on Mac OS X and Safari. We use HTML Professional and Design Extension.

Will you post a solution Daniel in SVN?
NO i won't post a solution. you have not read things properly. this is nothing to do with opencart is how these applications work!

thunderbird has the problem open cart sends emails how they should be sent.

why do you think safari not working with gmail got anything to do with opencart!!

Re: OpenCart 1.5.1.3 Bug Thread

Posted: Sun Oct 09, 2011 9:32 pm
by Daniel
heinzchen wrote:I get this error message:

Warning: sprintf() [function.sprintf]: Too few arguments /var/www/xxxxx/catalog/controller/account/success.php in on line 31

what's going wrong?

update your language file for that page.

Low Order Fee 1.5.1.3 Bug

Posted: Sun Oct 09, 2011 10:11 pm
by karadev
Low Order Fee Notice: Undefined variable: entry_tax in
/public_html/shop/admin/view/template/total/low_order_fee.tpl on line 28

Handling Fee Notice: Undefined variable: entry_tax in
public_html/shop/admin/view/template/total/handling.tpl on line 28

OC 1.5.1.3

best regards << karadev