Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by opencartisalright » Fri Jun 17, 2011 10:06 am

opencartisalright wrote:I'm using OC 1.5.0.5 and vQmod 1.1.0.

When I update the status of one of my orders (ex. from processing to shipped), when the customer gets the notification to their e-mail and they click on the link that takes them to their order history page in opencart, they get the following error message.

Code: Select all

Warning: require_once(/home/xxxxxxxx/public_html) [function.require-once]: failed to open stream: No such file or directory in /home/xxxxxxxx/public_html/vqmod/vqcache/vq-system_engine_front.php on line 43
Just thought I'd update this as I figured out what was causing the error. It was because the link in the order update notification e-mail was incorrect. I had to change the link so that it pointed to the correct location and it stopped throwing the error message above.

Using vQmod 1.2 now also and no problems thus far. Seems solid. Thanks for the update! Now if we could just start getting some vQmods for OC 1.5 all would be right in the world.
opencartisalright
Active Member
Posts
371
Joined
Mon Feb 21, 2011 4:09 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by rph » Fri Jun 17, 2011 2:56 pm

Bee's knees! Your work is always much appreciated Q.

-Ryan

rph
Expert Member
Posts
4102
Joined
Fri Jan 08, 2010 5:05 am
Location - Lincoln, Nebraska
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by madimar » Fri Jun 17, 2011 5:37 pm

Hi Q,
I'm trying new 1.2.0 release and simple logging is really great. I will let you know also if those random problems will disappear.
In the meanwhile, I'm testing it on a fresh 1.4.9.5 OC... From your code I understand that 4 errors in the log are expected (for those 1.5 specific operations, with skip), aren't they? It's a little annoying actually, because due to continuous log, you fill the file with thousand of lines in a while...

Thanks as usual, vqmod rocks!

M

-----------------------------------------------------------------------
My last mods: Partita IVA e CF | Pro EU VAT Number | Sales Agents | Pricelist Pro
-----------------------------------------------------------------------

User avatar
madimar
Active Member
Posts
1477
Joined
Thu Sep 24, 2009 6:27 pm
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 7:03 pm

Just tested VQmod 1.2.0 on an Opencart 1.4.9.3 based site, and it really messed up some of my .tpl files which used to be modified correctly in VQmod 1.0.8. I am now trying to narrow down the VQmod bug on this and let you know what I find.
Last edited by JNeuhoff on Fri Jun 17, 2011 8:54 pm, edited 2 times in total.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 7:44 pm

OK, I found the bug. The following did not work correctly:

Code: Select all

	<file name="admin/view/template/catalog/information_form.tpl">
		<operation>
			<search position="before" index="2"><![CDATA[<table class="form">]]></search>
			<add><![CDATA[
				<!-- before second instance of <table class="form"> only please! -->
			]]></add>
		</operation>
	</file>
VQMod 1.2.0 seems to ignore the index="2" attribute, instead it adds the data before every found instance of <table class="form">, instead of only before the second <table class="form">. This bug did not exist in previous versions of VQmod.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 8:29 pm

Also, my previously reported 1.1.0 bug is still there in 1.2.0, too!

Using URLs like index.php?route=xyz/abc with non-existing routes results in attempts to load from a non-existing file!

Back to the drawing board, please :)

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 9:09 pm

The following bugfixes will do for VQmod 1.2.0:

In function modCheck add this at the very beginning:

Code: Select all

		if ($sourcefile=='') {
			return '';
		}
And in function applyMod, replace

Code: Select all

	                if ($index && is_array($index)) {
	                    if (!in_array($count, $index)) { continue; }
	                }
with

Code: Select all

	                if ($index && is_array($index)) {
	                    if (!in_array($count, $index)) { continue; }
	                } else if ($index && ($index!=$count)) {
                        continue;
                    }

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by Qphoria » Fri Jun 17, 2011 9:18 pm

Ah ok.. I misread that bug the last time.. thought it was related to a diff issue but it is separate. I've fixed both issues now in 1.2.1

Updated in first post
v1.2.1 - 2011-JUN-17 - Qphoria@gmail.com
- Fixed bug with index not being converted to an array
- Fixed issue with invalid routes returning true on sourcefile (thanks JN)

Thanks

Image

User avatar
Qphoria
Administrator
Posts
20056
Joined
Tue Jul 22, 2008 3:02 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by madimar » Fri Jun 17, 2011 9:38 pm

hmmm, I'm sorry if it is a fake problem, but now, with 1.2.1 it is worst... no actions on any xml file. Only effect on vqmod_opencart.xml with only 1 file created in cache:

vq-system_startup.php

and it doesn't seem modified. Am I the only one experiencing this?

Rolling back to 1.0.9 just replacing vqmod.php file, everything works fine

-----------------------------------------------------------------------
My last mods: Partita IVA e CF | Pro EU VAT Number | Sales Agents | Pricelist Pro
-----------------------------------------------------------------------

User avatar
madimar
Active Member
Posts
1477
Joined
Thu Sep 24, 2009 6:27 pm
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 10:12 pm

Q hasn't quite woken up yet, let him have his breakfast first :)

Replace

Code: Select all

    public function modCheck($sourcefile) {

		if ($sourcefile == '') {
			return;
		}


with

Code: Select all

    public function modCheck($sourcefile) {

		if ($sourcefile == '') {
			return '';
		}


and then VQmod 1.2.1 will be fine.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by madimar » Fri Jun 17, 2011 10:23 pm

...hmm... not working yet! Don't you have a vqmod xml file to do the fix?!? :joker:
xml files are practically not processed anymore with my 1.2.1... rollback again on 1.0.9 :crazy:

-----------------------------------------------------------------------
My last mods: Partita IVA e CF | Pro EU VAT Number | Sales Agents | Pricelist Pro
-----------------------------------------------------------------------

User avatar
madimar
Active Member
Posts
1477
Joined
Thu Sep 24, 2009 6:27 pm
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Fri Jun 17, 2011 10:42 pm

Yeah, Q's bugfix was a bit too explosive ;D

In addition to what I said before for 1.2.1, also do this: In method applyMod, remove

Code: Select all

		$index = explode(',', $index);
and replace

Code: Select all

	                if ($index && is_array($index)) {
	                    if (!in_array($count, $index)) { continue; }
	                }
with

Code: Select all

	                if ($index && is_array($index)) {
	                    if (!in_array($count, $index)) { continue; }
	                } else if ($index && ($index != $count)) {
	                    continue;
	                }
Otherwise, ($index && is_array($index)) always is TRUE even when there is no index!

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by madimar » Fri Jun 17, 2011 11:15 pm

oooohhhhhhh YES! Thank you J, now, finally, fantastic 1.2.1(.3.4.5.6.7.8.9) version seems working fine!!!!!!!!!
:clown: :clown: :clown: :clown: :clown:

-----------------------------------------------------------------------
My last mods: Partita IVA e CF | Pro EU VAT Number | Sales Agents | Pricelist Pro
-----------------------------------------------------------------------

User avatar
madimar
Active Member
Posts
1477
Joined
Thu Sep 24, 2009 6:27 pm
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by Qphoria » Fri Jun 17, 2011 11:15 pm

lol this is what I get for rushing

updated... 1.2.2
Thanks JN

Image

User avatar
Qphoria
Administrator
Posts
20056
Joined
Tue Jul 22, 2008 3:02 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by ckonig » Fri Jun 17, 2011 11:27 pm

Thanks a lot Q,
I am going to test my 30 vQmod scripts on 1.4.9.5 next week with your new vQmod version.
By the way, I filled 20 pages of my internship report with praising you, Daniel, OpenCart and vQmod.
I hope i can convince my boss to publish a generic version of my warehousing/purchasing extension I created in the last five months. This way, this nice community can get something back.
User avatar
ckonig
Active Member
Posts
196
Joined
Wed Feb 16, 2011 4:26 pm
Location - Netherlands
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JAY6390 » Sun Jun 19, 2011 7:53 pm

Anyone here wanting to test a prototype 2.0 version? This is NOT for production servers

Image

User avatar
JAY6390
Guru Member
Posts
5086
Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by Qphoria » Sun Jun 19, 2011 9:43 pm

JAY6390 wrote:Anyone here wanting to test a prototype 2.0 version? This is NOT for production servers
Yes Jay has done a great job of revamping the original to a much improved object based method that will likely become the official 2.x build. I will be testing it more on my sites this week as well.

Image

User avatar
Qphoria
Administrator
Posts
20056
Joined
Tue Jul 22, 2008 3:02 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JNeuhoff » Sun Jun 19, 2011 11:58 pm

JAY6390 wrote:Anyone here wanting to test a prototype 2.0 version? This is NOT for production servers
I can test it next week with allmy XML files. Where can I download it?

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig

User avatar
JNeuhoff
Guru Member
Posts
7484
Joined
Wed Dec 05, 2007 3:38 am
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by madimar » Mon Jun 20, 2011 6:03 am

I'm interested too!

Sent from my Desire HD using Tapatalk

-----------------------------------------------------------------------
My last mods: Partita IVA e CF | Pro EU VAT Number | Sales Agents | Pricelist Pro
-----------------------------------------------------------------------

User avatar
madimar
Active Member
Posts
1477
Joined
Thu Sep 24, 2009 6:27 pm
Top

Re: [MOD] - VirtualQMod "vQmod" Virtual File Modification Sy

Post by JAY6390 » Tue Jun 21, 2011 12:39 am

Hi Madimar. Please check your PMs

Jay

Image

User avatar
JAY6390
Guru Member
Posts
5086
Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom
Top
Locked
Return to “Free Contributions”
Who is online

Users browsing this forum: No registered users and 4 guests