Post by ckonig » Wed Jun 01, 2011 7:09 pm

same problem for me. i had to remove the operation regarding the $default, in order to make it work.

User avatar
Active Member

Posts

Joined
Wed Feb 16, 2011 4:26 pm
Location - Netherlands

Post by Qphoria » Wed Jun 01, 2011 7:23 pm

spitos wrote:
JAY6390 wrote:Post your /system/library/language.php file here. it should definitely have the $default in it
Here is the code, i've made no changes at all to this file:

Code: Select all

<?php
final class Language {
  	private $directory;
	private $data = array();
 
	public function __construct($directory) {
		$this->directory = $directory;
	}
	
  	public function get($key) {
   		return (isset($this->data[$key]) ? $this->data[$key] : $key);
  	}
	
	public function load($filename) {
		$file = DIR_LANGUAGE . $this->directory . '/' . $filename . '.php';
    	
		if (file_exists($file)) {
			$_ = array();
	  		
			require($file);
		
			$this->data = array_merge($this->data, $_);
			
			return $this->data;
		} else {
			echo 'Error: Could not load language ' . $filename . '!';
			exit();
		}
  	}
}
?>
Cheers
This is because that is the 1.5.0 language class which daniel has mutilated and removed the language fallback. Epic fail. I wouldn't touch 1.5.0 with a stick

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by spitos » Wed Jun 01, 2011 7:42 pm

Qphoria wrote: This is because that is the 1.5.0 language class which daniel has mutilated and removed the language fallback. Epic fail. I wouldn't touch 1.5.0 with a stick
I've amended the language file after comparing it to the 1.4.9.5 version and it seems to solve the error in the log file.

Change this:

Code: Select all

public function load($filename) {
		$file = DIR_LANGUAGE . $this->directory . '/' . $filename . '.php';
To this:

Code: Select all

public function load($filename) {
	$_ = array();

		$default = DIR_LANGUAGE . 'english/' . $filename . '.php';

		if (file_exists($default)) {
			require($default);
		}
		$file = DIR_LANGUAGE . $this->directory . '/' . $filename . '.php';
However this still doesn't solve my issue with the mods not working and being unable to see any changes after upload of an xml file. I've even edited the xml file to update it with the new code changes but it is still unsuccessful.
Trying to install 'new_order_entry_v2.xml'.
An operation in that file is:

Code: Select all

		<file name="admin/controller/common/header.php">
        <operation>
            <search position="after"><![CDATA[
            $this->data['order'] = HTTPS_SERVER . 'index.php?route=sale/order&token=' . $this->session->data['token'];
            ]]></search>
            <add><![CDATA[
            $this->data['order_new'] = HTTPS_SERVER . 'index.php?route=sale/order_new&token=' . $this->session->data['token'];
            ]]></add>
        </operation>
	</file>
But the code in header.php has now changed.
For the operation to complete successfully, I amended that code to this:

Code: Select all

	<file name="admin/controller/common/header.php">
        <operation>
            <search position="after"><![CDATA[
            $this->data['order'] = $this->url->link('sale/order', 'token=' . $this->session->data['token'], 'SSL');
            ]]></search>
            <add><![CDATA[
            $this->data['order_new'] = $this->url->link('sale/order_new', 'token=' . $this->session->data['token'], 'SSL');
            ]]></add>
        </operation>
	</file>
the log showed no errors but the mod still doesn't work! :'(

I'm pretty new to all of this... are my changes valid? Should things be working?

Image
Google Analytics Expert - Advanced e-commerce tracking, Product & options reporting, transaction/conversion reporting, Google Adwords conversion & profit reporting, goal & funnel reporting, event tracking, site search tracking, multi-store compatibility, EU Cookie Law compliance and works with any theme or checkout! Easy vqmod install. Get it here


User avatar
Active Member

Posts

Joined
Mon May 23, 2011 6:19 pm
Location - UK

Post by Qphoria » Wed Jun 01, 2011 7:53 pm

You are using a 1.4 mod with 1.5
won't work

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by ckonig » Wed Jun 01, 2011 7:59 pm

are there already any vQmods for 1.5?

User avatar
Active Member

Posts

Joined
Wed Feb 16, 2011 4:26 pm
Location - Netherlands

Post by spitos » Wed Jun 01, 2011 9:01 pm

Qphoria wrote:You are using a 1.4 mod with 1.5
won't work
I don't understand... If the mod has been rewritten to match v1.5.0 and insert the code correctly, why wouldn't it work?

It seems to be a fairly straightforward mod, what am I missing? Please take a look if you could (i'm not desperate to get this particular mod working, just curious as to why it wouldn't), all of the code in the attachment is applicable to the code in the relevant v.1.5.0 files.

Has the way the core files are coded changed in v1.5.0?

I look forward to some 1.5.0 mods ;D

Attachments

Updated to *work* with OpenCart v1.5.0

Last edited by spitos on Wed Jun 01, 2011 9:15 pm, edited 1 time in total.

Image
Google Analytics Expert - Advanced e-commerce tracking, Product & options reporting, transaction/conversion reporting, Google Adwords conversion & profit reporting, goal & funnel reporting, event tracking, site search tracking, multi-store compatibility, EU Cookie Law compliance and works with any theme or checkout! Easy vqmod install. Get it here


User avatar
Active Member

Posts

Joined
Mon May 23, 2011 6:19 pm
Location - UK

Post by ckonig » Wed Jun 01, 2011 9:11 pm

try empty your vqmod.log and reload the page. Then open the vqmod.log again and search for "failed".
Also check the vqcache folder if the modified files appear there.

User avatar
Active Member

Posts

Joined
Wed Feb 16, 2011 4:26 pm
Location - Netherlands

Post by Qphoria » Wed Jun 01, 2011 11:05 pm

Didn't know it was updated for150.

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by spitos » Wed Jun 01, 2011 11:58 pm

ckonig wrote:try empty your vqmod.log and reload the page. Then open the vqmod.log again and search for "failed".
Also check the vqcache folder if the modified files appear there.
I emptied the log and tried again but searching for 'failed' shows no results.
I also cleared the cache folder and checked again after reloading the page... for some reason one of the operations didn't seem to work as one of the cached files wasn't present (a change in admin/view/template/common/header.tpl), I don't understand why not. I simply put the code directly into that template to get the mod to appear in the admin area.

Clicking the new 'New Order' option in sales then bought up an error (didn't make a note of this but it was something to do with 'Document $title'). So, in one of the files necessary for the mod to *work* which gets uploaded to admin > controller > sale > 'order_new.php', I had to make to amendments.

Changed 2 instances of this:

Code: Select all

$this->document->title = $this->language->get('heading_title');
To this:

Code: Select all

$this->document->setTitle($this->language->get('heading_title'));
After making those changes I could then click the 'New Order' link and view the page.
However, the css is all out, it uses a different tab.js (instead of tabs.js in v1.5.0) and also has some other issues relating to the sql query and currency field upon saving the new order! :bash:

Almost there but don't have the time to proceed any further... It seems that much of the code has changed in v1.5.0 but without any documentation it makes it much more difficult and time consuming. I hope someone can help progress/convert the fantastic 1.4.9.5 mods for 1.5.0, I give up :'(

Image
Google Analytics Expert - Advanced e-commerce tracking, Product & options reporting, transaction/conversion reporting, Google Adwords conversion & profit reporting, goal & funnel reporting, event tracking, site search tracking, multi-store compatibility, EU Cookie Law compliance and works with any theme or checkout! Easy vqmod install. Get it here


User avatar
Active Member

Posts

Joined
Mon May 23, 2011 6:19 pm
Location - UK

Post by Qphoria » Thu Jun 02, 2011 12:52 am

Im in the process of converting my mods from 1.4.x to 1.5.0
There are basically 25 steps to convert. Looks like the updated version missed a few steps, like that setTitle one

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by opencartisalright » Thu Jun 02, 2011 1:48 am

Qphoria wrote:This is because that is the 1.5.0 language class which daniel has mutilated and removed the language fallback. Epic fail. I wouldn't touch 1.5.0 with a stick
You could just mysteriously add it back in to one of the point releases in the future. Ooops, how'd that get back in there... :-X

Active Member

Posts

Joined
Mon Feb 21, 2011 4:09 am

Post by Qphoria » Thu Jun 02, 2011 4:20 am

opencartisalright wrote:
Qphoria wrote:This is because that is the 1.5.0 language class which daniel has mutilated and removed the language fallback. Epic fail. I wouldn't touch 1.5.0 with a stick
You could just mysteriously add it back in to one of the point releases in the future. Ooops, how'd that get back in there... :-X
Gotta get past ol' eagle eye or better.. you all need to complain

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by opencartisalright » Thu Jun 02, 2011 5:42 am

Qphoria wrote:Gotta get past ol' eagle eye or better.. you all need to complain
It would help if I actually knew what to complain about. Language class...language fallback, it's all foreign language to me.

Maybe the basic "What happened to the Language Class, why isn't there a language fallback in version 1.5?" would suffice...

But seriously, why is it important. I'm just curious to know now.

Active Member

Posts

Joined
Mon Feb 21, 2011 4:09 am

Post by hellogoodbye » Thu Jun 02, 2011 11:46 am

just read this thread for the first time. when do you think it'll be ready for 1.5? thanks

New member

Posts

Joined
Wed May 04, 2011 6:33 am

Post by Qphoria » Thu Jun 02, 2011 12:01 pm

UPDATED FIRST POST!

v1.1.0 - 2011-JUN-01 - Qphoria@gmail.com
- AutoInstaller for OpenCart! (Thanks JayG)
- Updated core script to be 1.4.x and 1.5.x compatible
- Fixed another bug with source path on some servers
- Changed fwrite to file_put_contents for tempfiles
- Added write delays to tempfiles

DO NOT RUN AUTO-INSTALLER IF YOU HAVE ALREADY MANUALLY INSTALLED!

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by webpie it. » Thu Jun 02, 2011 1:05 pm

This is awesome.

I just installed the VQMOD for 1.5

That installed very easily, auto installer rocks!

Tried the mod new_order_entryV.2 above but could not get that to showup.

Everything looks like it works though, thanks to Q and Jayg and everyone else getting this out so fast, i must admit this was my only worry for 1.5 as I see this as a core reason that opencart beats everyone else!

Again thanks guys and hopefully now we will see people porting their mods over, and i dare i say i it, i may even try and port one myself as i feel confident enough to do so.

Peace

Chris

Regards

Chris


Active Member

Posts

Joined
Mon Jan 31, 2011 7:28 pm

Post by hellogoodbye » Thu Jun 02, 2011 3:57 pm

err i don't know what's going on. when the opencart root has .htaccess.txt and i try to install virtualqmod it gives me internal server error and when I rename it to .htaccess and try to install virtualqmod again, it gives me The page you requested cannot be found. opencart is installed on subdomain....or the hosting just sucks

New member

Posts

Joined
Wed May 04, 2011 6:33 am

Post by webpie it. » Thu Jun 02, 2011 4:52 pm

err i don't know what's going on. when the opencart root has .htaccess.txt and i try to install virtualqmod it gives me internal server error and when I rename it to .htaccess and try to install virtualqmod again, it gives me The page you requested cannot be found. opencart is installed on subdomain....or the hosting just sucks
I too had the exact same problem with the auto installer, after my post i tried it again, and i too got a the same error, followed your method with the htaccess and same problem.

I just installed manually as i feel better doing it that way anyway.

But possibly this is an error as this has been rolled out super fast, and only very very early this morning by Q and the with the help of JayG.

Regards

Chris


Active Member

Posts

Joined
Mon Jan 31, 2011 7:28 pm

Post by JAY6390 » Thu Jun 02, 2011 8:56 pm

lol the auto installer was made a couple of weeks ago (before 1.0.9 was released), just not publicly available, so it's not been rushed out at all 8) . If the .htaccess file is called ".htaccess.txt" then it should have NO effect on your site, or give an internal server error. I have a feeling this might actually be due to the .htaccess file(s) inside the vqmod folder itself. If you open vqmod/.htaccess and put a # before Options Indexes and save does it work then?

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by Qphoria » Thu Jun 02, 2011 9:03 pm

Yea.. there is a new .htaccess file inside of the vqmod folder that just prevents people from browsing your file index. That shouldn't cause any ISE 500's unless servers are that poorly configured. But removing the .htaccess file or renaming it may resolve it.

The installation process wasn't rushed at all, tho I did work on the latest vQmod class file last night while drinking so who knows :drunk:

All I know is it works for me on 1.4.x and 1.5.x on my windows localhost and my linux shared host

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am
Who is online

Users browsing this forum: No registered users and 13 guests