OpenCart Community

uksitebuilder wrote:I believe this has been fixed in the SVN for the next update too.

ninogui wrote:1511 localhost here

Bug

- On customer side, when entering the order history and choosing one order, customer selects one single line product and chooses to return it. Regardless of choosing one or more product lines all of them show up on the next screen for product return, meaning customer has to remove product lines that are not in fact to return ? I consider this a bug because on the first screen the customer is being asked what to do with the selected products

- Also apparently customer is able to issue the return for any qty product, even much more than he ever bought ?

thks

 'product'    => $this->model_account_order->getOrderProducts($order_id)

  'selected'   => $this->request->post['selected'],

foreach ($this->session->data['return']['product'] as $result) {
    $this->data['return_products'][] = array(
        'name'     => $result['name'],
        'model'    => $result['model'],
        'quantity' => 1,
        'opened'   => false,
        'comment'  => ''
    );
}

foreach ($this->session->data['return']['product'] as $result) {				
  if (in_array($result['order_product_id'], $this->session->data['return']['selected'])) {
    $this->data['return_products'][] = array(
        'name'     => $result['name'],
        'model'    => $result['model'],
        'quantity' => 1,
        'opened'   => false,
        'comment'  => ''
    );
  }
}

<input type="text" name="return_product[<?php echo $return_product_row; ?>][quantity]" value="<?php echo $return_product['quantity']; ?>" />

              <select name="return_product[<?=$return_product_row;?>][quantity]" id="return_product[<?=$return_product_row?>][quantity]">
                <?php 
                  for ($i = 1; $i <= $return_product[quantity]; $i++) {
                      echo '<option value="'.$i.'">'.$i.'</option>';
                  }
                ?>
              </select>

				$this->data['return_products'][] = array(
					'name'     => $result['name'],
					'model'    => $result['model'],
					'quantity' => 1,
					'opened'   => false,
					'comment'  => ''
				);

				$this->data['return_products'][] = array(
					'name'     => $result['name'],
					'model'    => $result['model'],
					'quantity' => $result['quantity'],
					'opened'   => false,
					'comment'  => ''
				);

ddowdall wrote:In version 1.5.1 when you add new customers in the admin, it does not verify that the email address has not been used before.

/manage/index.php?route=sale/customer/insert

simon_wu wrote:A minor miss in model/account/customer.php

When sending mail to the customer for created accounts the function uses the request-post instead of the inputed data.

Line 43:

Code: Select all

$mail->setTo($this->request->post['email']);

Should be:

Code: Select all

$mail->setTo($data['email']);

Minor problem for extensions/themes that create accounts with different input-names than the default register template.

Jaano wrote:Bug confirmed on current 1.5.1 version : http://demo.opencart.com/admin/

In the admin when editing an item (product or category), your images selection is not kept when the form si submitted with errors (validation). Both for main image and additional images, though for different reasons. In the controller:

Code: Select all

if (isset($category_info) && $category_info['image'] && file_exists(DIR_IMAGE . $category_info['image'])) {
			$this->data['preview'] = $this->model_tool_image->resize($category_info['image'], 100, 100);
		} else {
			$this->data['preview'] = $this->model_tool_image->resize('no_image.jpg', 100, 100);
		}

missing the case when getting the image URL from request post.

Code: Select all

foreach ($product_images as $product_image) {
				if ($product_image['image'] && file_exists(DIR_IMAGE . $product_image['image'])) {
					$image = $product_image['image'];
				} else {
					$image = 'no_image.jpg';
				}
				
				$this->data['product_images'][] = array(
					'image'   => $image,
					'preview' => $this->model_tool_image->resize($image, 100, 100)
				);
			}

the image URL is directly in $product_image, not in $product_image['image'], in the request->post validation case.

i2Paq wrote:

ddowdall wrote:In version 1.5.1 when you add new customers in the admin, it does not verify that the email address has not been used before.

/manage/index.php?route=sale/customer/insert

CONFIRMED on 1.5.1.3 also!

You can use that second account as well, it will "filter" on the password.

Simplicity wrote:Clean Opencart v1.5.1.2 install, default theme.

1. At least two languages needed for this. (choose any from extensions on opencart.com)
2. Put product which requires shipping calculation to cart. Canon EOS 5D in Desktops works fine.
3. Go to cart
4. Press "Estimate Shipping & Taxes" > Get Qoutes > Pick flat rate > Apply Shipping.
(Your shipping price will be added to total + you'll see a line "flat rate")
5. Change language from en to any other available and you'll see that "flat rate" stays in English.
6. Repeat step 4 and "flat rate" should change to other language (if translated).
7. Change language to en. Everything except shipping will change to English.