OpenCart 1.5.1.1 Bug Thread

Cannot seem to be able to edit the customers from the Customer List page. If I find an order that the customer has made, I can click on the customer's name link to get to the customer edit page, but if I am trying to add registered customers to special groups, I do not want to have to track down orders they have made to be able to edit their group.

uksitebuilder wrote:What value do yu have in System - Localisation - Currencies for the Euro ?

united wrote:Bug causes download files with spaces in the filename to be get the filename truncated at the occurrence of the first space. (See http://forum.opencart.com/viewtopic.php ... 07#p191507)

Fix is to change catalog/controller/account/download.php line 174 from:

header('Content-Disposition: attachment; filename=' . ($mask ? $mask : basename($file)));

to:

header('Content-Disposition: attachment; filename="' . ($mask ? $mask : basename($file)) . '"');


(i.e. Add double quotes around the filename value).

uksitebuilder wrote:It's not a bug, please see http://www.designs.org.uk/hp-lp3065

I added options of

small + 15
medium + 25
large + 35

they are correctly added to the basket.

i2Paq wrote:You should NEVER! use spaces in file-names on the web.

i2Paq wrote:You should NEVER! use spaces in file-names on the web.

united wrote:LOL! dude, it's not 1994 any more. And anyhow this bug was already fixed by OC developers and checked in. So if you get latest code from Subversion or as of next release you can use spaces just like any other character. And you can probably use 1,000's of other characters just fine too, which the interwebs have been supporting for years now, thanks to proper escaping/conversion functions. In other words, web standards and browsers have come a long way and the allowed ranges of characters are well defined nowadays and all you have to do is use the proper conversion/escape function (e.g. urlencode()) for the context and then things work very well Though having seen this code I don't think it does a urlencode() type of call so I would suggest not having any double-quote chars in your filenames.

united wrote:

i2Paq wrote:You should NEVER! use spaces in file-names on the web.

LOL! dude, it's not 1994 any more.

And anyhow this bug was already fixed by OC developers and checked in. So if you get latest code from Subversion or as of next release you can use spaces just like any other character. And you can probably use 1,000's of other characters just fine too, which the interwebs have been supporting for years now, thanks to proper escaping/conversion functions. In other words, web standards and browsers have come a long way and the allowed ranges of characters are well defined nowadays and all you have to do is use the proper conversion/escape function (e.g. urlencode()) for the context and then things work very well Though having seen this code I don't think it does a urlencode() type of call so I would suggest not having any double-quote chars in your filenames.

i2Paq wrote: It is NOT a bug, this fix is for stupid people like you who think that because they want it they should get it. The fix is in OpenCart for something that is well known to everyone who knows his ways around with php, you probably not

fido-x wrote: There are 2 sides to this, server and client (customer).
While the server can "serve" a page that contains spaces in the url by "urlencoding" names, the same is not true from the customer's perspective (the client side). For example, I can't enter a url of "http://www.domain.com/Product name" in the browser's address field, otherwise I get "Page not found" error. I (as the customer) have to manually "urlencode" this to "http://www.domain.com/Product%20name".

united wrote:Your example does not apply to how file downloads are done in opencart.

fido-x wrote:While the server can "serve" a page that contains spaces in the url by "urlencoding" names...

fido-x wrote: Note the word "page". I didn't refer to downloads at all. For that matter, neither did you.

fido-x wrote: What I was referring to was the practice of using of spaces in SEO keywords. Something that many people do, and then complain about "Page not found" errors.

I've been using OpenCart for over 3 years, providing downloadable modules to the community. Do you really think that I don't know how the download system works?

united wrote:i2Paq, wow sounds like you have some serious emotional issues! perhaps you should consider reading up a little on net etiquette, or taking some anger management classes?

united wrote:That's great, though a little off-topic since no one asked about that.

rph wrote:To get back on topic a bit, for the country cache we have

Catalog

Code: Select all

if (!$country_data) {
    $query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country WHERE status = '1' ORDER BY name ASC");
    
    $country_data = $query->rows;
        
    $this->cache->set('country', $country_data);
} 

Admin

Code: Select all

if (!$country_data) {
    $query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country ORDER BY name ASC");
    
    $country_data = $query->rows;
            
    $this->cache->set('country', $country_data);
} 

			.....
			$country_data = $this->cache->get('admin_country');
		
			if (!$country_data) {
				$query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country ORDER BY name ASC");
	
				$country_data = $query->rows;
			
				$this->cache->set('admin_country', $country_data);
			}
			.....