Package re-uploaded.
- Finalized the admin and catalog mail events.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Nice Job @straightlight.
Any plans to replace SHA with password_hash()? I believe this was also implemented into the master branch last I checked.
https://github.com/opencart/opencart/pull/5798
Disclaimer: - I think a few additional changes are required for the password hash that's not in the linked PR , you will have to double check against the master. I believe its some fixes to html_entity_decode that were later implemented for this feature.
Any plans to replace SHA with password_hash()? I believe this was also implemented into the master branch last I checked.
https://github.com/opencart/opencart/pull/5798
Disclaimer: - I think a few additional changes are required for the password hash that's not in the linked PR , you will have to double check against the master. I believe its some fixes to html_entity_decode that were later implemented for this feature.
Last edited by sw!tch on Thu Jun 11, 2020 11:38 am, edited 2 times in total.
Backup and learn how to recover before you make any changes!
If you notice official changes where those commits have not been mentioned on the topic, please mention them!Disclaimer: - I think a few additional changes are required for this as well, you will have to compare against the master.
As for the password_hash, the reason why I didn't integrated this yet is because the REMOTE_ADDR lookups are too repetitive. I am currently consolidating the idea on creating a new IP method in the library to use identical lookups instead of different ones throughout the platform since it can be quite confusing at times especially when it comes to patching.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Sorry edited my post. I was referring to the password_hash not other fixes. Clarified my post above.straightlight wrote: ↑Thu Jun 11, 2020 10:26 amIf you notice official changes where those commits have not been mentioned on the topic, please mention them!
Backup and learn how to recover before you make any changes!
https://github.com/opencart/opencart/co ... f0a17f742asw!tch wrote: ↑Thu Jun 11, 2020 11:36 amSorry edited my post. I was referring to the password_hash not other fixes. Clarified my post above.straightlight wrote: ↑Thu Jun 11, 2020 10:26 amIf you notice official changes where those commits have not been mentioned on the topic, please mention them!
https://github.com/opencart/opencart/co ... f8a3ded55c
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Ok, I tried it one more time with the password hash. Now, it works but without modifying the startup with the integrated session as it shows in the master branch. However, the only reason why I'm adding this is because Daniel seem to approve it from the commits the fact that he replied to the original poster and that the commits were merged. Nevertheless, my notes to this is that I don't totally agree with this integration due to the system/library/cart folder, for either the customer or user library, where the $new_password_hashed variable provides no guarantee of success since there's also a possibility that the $new_password_hashed may return false in the condition. When the case, the password is not being updated as per the codes shows as I don't believe this is the best suggestion based on a isset condition as to know if only not false to enforce security on a platform as a solution as much as access management is concerned despite if the html_entity_decode with password_hashed is being used or not in this case.xxvirusxx wrote: ↑Thu Jun 11, 2020 3:38 pmhttps://github.com/opencart/opencart/co ... f0a17f742asw!tch wrote: ↑Thu Jun 11, 2020 11:36 amSorry edited my post. I was referring to the password_hash not other fixes. Clarified my post above.straightlight wrote: ↑Thu Jun 11, 2020 10:26 amIf you notice official changes where those commits have not been mentioned on the topic, please mention them!
https://github.com/opencart/opencart/co ... f8a3ded55c
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Now I can't even login in to either sides. Process reversed, request denied.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Clean install or upgrade test?straightlight wrote: ↑Thu Jun 11, 2020 5:20 pmNow I can't even login in to either sides. Process reversed, request denied.
On my modified 3.0.3.3 work just fine.
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Clean install. These modifications will be focused on the master branch.xxvirusxx wrote: ↑Thu Jun 11, 2020 5:45 pmClean install or upgrade test?straightlight wrote: ↑Thu Jun 11, 2020 5:20 pmNow I can't even login in to either sides. Process reversed, request denied.
On my modified 3.0.3.3 work just fine.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Why don't work on Github?....private repo...with some developers from here..is more easy
This I was added in my modified version. Remove this link after you see
https://github.com/condor2/Opencart_303 ... 00c6e2d1d2
This I was added in my modified version. Remove this link after you see
https://github.com/condor2/Opencart_303 ... 00c6e2d1d2
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
As for the IP address, the system/startup already takes care of the forwarding or the client IP. Only the catalog/controller/common/footer.php file will be modified accordingly.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Agreed. If possible put it up on GitHub, it's incredibly difficult to track changes or to cherry pick fixes out.
Backup and learn how to recover before you make any changes!
Package updated.
- Modified IP lookup in catalog/controller/common/footer.php file as per Daniel.
- Modified IP lookup in catalog/controller/common/footer.php file as per Daniel.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package updated.
- Removed download_report from the core as per Daniel. Now being used in the features. From now on, all features suggestions from the master branch must be posted into this section: viewtopic.php?f=201&p=790560#p790560 . Please read the guidelines from the topic before posting.
- Removed download_report from the core as per Daniel. Now being used in the features. From now on, all features suggestions from the master branch must be posted into this section: viewtopic.php?f=201&p=790560#p790560 . Please read the guidelines from the topic before posting.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package updated.
- Replaced .twig with \.twig in <filesmatch> of .htaccess.txt file as per this commit: https://github.com/opencart/opencart/pull/7992 .
- Replaced .twig with \.twig in <filesmatch> of .htaccess.txt file as per this commit: https://github.com/opencart/opencart/pull/7992 .
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, confirmed and fixed. Will re-upload both packages in a moment.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, package re-uploaded.straightlight wrote: ↑Sat Jun 13, 2020 8:50 pmOk, confirmed and fixed. Will re-upload both packages in a moment.
- Reverted change in .htaccess from \.twig back to .twig since it's not a bug - it's intended this way.
- Fixed admin/controller/catalog folder as per derzet.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
As customer logged when you go register affiliate account in the console you will get:
And from admin if you try to add a custom field you will get:
Custom field not added, and when click on Custom Field..you will get same error.
I don't see where is declared: $custom_field
Code: Select all
Uncaught TypeError: $(...).datetimepicker is not a functionCode: Select all
admin/controller/customer/custom_field.php on line 210I don't see where is declared: $custom_field
Code: Select all
if ($custom_field['status']) {Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
The admin/controller/customer/custom_field used the wrong array name from the getCustomFields method. In general, Opencart uses $custom_fields and uses the array convention name of: $custom_field. The actual issue was from the $results to name the convention into: $result in the foreach statement. This has now been fixed. As for the datetimepicker, I am currently looking at the issue.xxvirusxx wrote: ↑Sat Jun 13, 2020 9:31 pmAs customer logged when you go register affiliate account in the console you will get:
And from admin if you try to add a custom field you will get:Code: Select all
Uncaught TypeError: $(...).datetimepicker is not a functionCustom field not added, and when click on Custom Field..you will get same error.Code: Select all
admin/controller/customer/custom_field.php on line 210
I don't see where is declared: $custom_fieldCode: Select all
if ($custom_field['status']) {
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Who is online
Users browsing this forum: No registered users and 3 guests
