Page 11 of 16
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Mon Jul 19, 2010 11:44 pm
by JAY6390
Bug added to first post
Re: Catalog - Product / Guest Checkout: Subtract not respect
Posted: Mon Jul 19, 2010 11:55 pm
by OSWorX
Qphoria wrote:That is no longer used and was "partially" removed in 1.4.8b and will be completely removed in 1.4.9
Great.
Therefore we can assume the next release very soon??
* Additonally, maybe the backend URLs will be fixed also to be XHTML valid (like the new 'token', 'product_id', 'page' (and maybe more)?
* And this long existing, but nasty issue with the 'line 121 column 5 - Warnung: <li> anchor "store" already defined' can be fixed also?
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 12:05 am
by 12oclocker
Just upgraded from 1.4.0 to 1.4.8b
I try to access "System->Localization->Measurement Classes" and I am getting...
Permission Denied!
...
Also after upgrading, all my products set for Inches, were automatically changed to Centimeters
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 12:42 am
by JAY6390
You will need to go to
SYSTEM > USERS > USER GROUPS
and enable the relevant permissions in there (just enable them all if you're the admin)
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 12:52 am
by 12oclocker
Ah thanks, that did it, would be nice to have a "Check All" option, lol
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 12:58 am
by JAY6390
I was just thinking the same thing
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 6:39 am
by 12oclocker
1.4.8b Bugs I have found
1) When in the Storefront, on the left select ANY manufacturer. Then change the product "Sort By" to anything other than default, then change it back to default, You will get an Error: "Manufacturer not found!"
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 10:25 am
by JAY6390
Not sure if it's been noticed but
Code: Select all
/catalog/controller/module/bestseller.php
and
Code: Select all
/catalog/controller/module/latest.php
both need to have
Code: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];
changed to
Code: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];
To maintain a valid document
Also
is in the template which should be changed to
(bestseller only)
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 11:37 am
by 12oclocker
I made those changes, but the bug is still there. humm
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 11:48 am
by Xsecrets
12oclocker wrote:I made those changes, but the bug is still there. humm
those changes were other bugs not related to yours. I have confirmed on the demo that what you mentioned is a bug.
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 2:18 pm
by OSWorX
JAY6390 wrote:Not sure if it's been noticed but
Code: Select all
/catalog/controller/module/bestseller.php
and
Code: Select all
/catalog/controller/module/latest.php
both need to have
Code: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];
changed to
Code: Select all
$add = HTTPS_SERVER . 'index.php?route=checkout/cart&product_id=' . $result['product_id'];
To maintain a valid document
These are NOT the only one!
Cannot understand why the URL building goes NOT through a function (as it was once a while ago).
So many not needed lines if all those links were build by $this->model_tool_seo_url->rewrite() - one line instead 5!
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 7:26 pm
by JAY6390
I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 7:48 pm
by OSWorX
JAY6390 wrote:I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
Also agreed.
But if the current method is used further, a simple addition to the rewrite function like 'false' and the url comes back as it was (the model still exists).
So this is just one line.
Same goes with all those currently stupid additons for the token.
In nearly every controller there are between 3 and 20 calls for that.
Would have been the controller 1 variable like $this->_url this could be handled much easier, the code would be much cleaner and - the scripts would be much smaller!
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 7:52 pm
by JAY6390
I actually have done something similar with the latest mods I've made
$this->_u()
which adds a token if needed
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 8:08 pm
by OSWorX
JAY6390 wrote:I actually have done something similar with the latest mods I've made
$this->_u()
which adds a token if needed
So did I - want to use my time for much better things
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 9:34 pm
by 12oclocker
I just noticed the little [+] beside my products on the Home page is NOT adding the products to the Cart, instead it's just taking me to the product page. But for the Online Demo it works fine. I upgraded from 1.4.0 to 1.4.8b, anyone else run into this problem or know a fix?
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 9:39 pm
by i2Paq
12oclocker wrote:I just noticed the little [+] beside my products on the Home page is NOT adding the products to the Cart, instead it's just taking me to the product page. But for the Online Demo it works fine. I upgraded from 1.4.0 to 1.4.8b, anyone else run into this problem or know a fix?
You really should read more before posting. This is NOT a bug, the product you've chosen has options, therefore it goes to the product page.
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Tue Jul 20, 2010 11:55 pm
by 12oclocker
I've been reading on here all morning and didn't find it, thanks for the explanation.
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Wed Jul 21, 2010 12:05 am
by Qphoria
OSWorX wrote:
Cannot understand why the URL building goes NOT through a function (as it was once a while ago).
So many not needed lines if all those links were build by $this->model_tool_seo_url->rewrite() - one line instead 5!
JAY6390 wrote:I totally agree, but think having to write that to rewrite a url is a bit much too to be honest, this should be a helper and a lot shorter to write
$this->rewrite
or $this->url
There shouldn't be any str_replace('&', '&', ...) or vice versa either. urlencode was made for this
I'm trying guys.. I really am. Daniel is very much opposed to the old method of url class. He has plans for a real url class that can be constructed. Something like this I guess:
Code: Select all
$action_url = new Class('Url');
$action_url->route = 'product/product';
$action_url->getToken();
$action_url->vars = array(
'product_id' => '1',
'sort' => 'p.price',
);
$action = $action_url->getHref();
But I think it's overkill to have to do for every link on a page. No changes on this until 1.5.x
Re: Post any OpenCart 1.4.8/1.4.8b Bugs here!
Posted: Thu Jul 22, 2010 2:42 am
by JJJaved
Northern Ireland's counties missing from the United Kingdom.