Page 2 of 5

Re: [Extension] Banner Language

Posted: Sun Sep 09, 2012 8:14 pm
by AvanOsch
Seems to be a problem with that vQMod Manager....
Just delete the xml file manually (or rename, what you want), and see what happens.

Re: [Extension] Banner Language

Posted: Sun Sep 09, 2012 9:27 pm
by rph
Your XML isn't valid because the comment isn't properly terminated.

Re: [Extension] Banner Language

Posted: Mon Sep 10, 2012 12:28 am
by AvanOsch
No offense, but without vQMod Manager everything works fine...
It should account for things like that.

I'm about to release my own "vQModerator" extension, which has no such problems...

Re: [Extension] Banner Language

Posted: Mon Sep 10, 2012 4:32 am
by rph
This has nothing to do with VQMod Manager. Your XML doesn't follow standards which the simplexml_load_file PHP function is reporting (that other load methods are more forgiving of errors doesn't matter). This practically never happens with released commercial mods because most devs follow XML standards and check their work. I'll update VQMod Manager to handle the error more gracefully but if you don't want to fix it don't blame others for your issue.

Re: [Extension] Banner Language

Posted: Mon Sep 10, 2012 4:46 am
by AvanOsch
I'll agree Banner Language's code is all but perfect.
The mentioned comment is terminated somewhere else in the code (I code "around" the original code as much as possible)
I'll have to re-check the code, and remove (some of) the comments.

However, as I mentioned, when not using vQMod Manager, I have not heard of any problems.
Also you suggesting I don't check my work is ridiculous.
I just don't use vQMod Manager, and didn't run in to the OP's problem.

Re: [Extension] Banner Language

Posted: Tue Sep 11, 2012 12:10 am
by ALandi
AvanOsch wrote:Seems to be a problem with that vQMod Manager....
Just delete the xml file manually (or rename, what you want), and see what happens.

Hi,

I've deleted the xml file, cleared the vqcache file and the problem was still there. I've reinstalled it back hoping it could fix, but nothing. Problem is still there.
I really appreciate your help as I'm unable to launch the shop before I can fix this problem.

My best regards,
ALandi

Re: [Extension] Banner Language

Posted: Tue Sep 11, 2012 12:13 am
by ALandi
ALandi wrote:
AvanOsch wrote:Seems to be a problem with that vQMod Manager....
Just delete the xml file manually (or rename, what you want), and see what happens.

Hi,

I've deleted the xml file, cleared the vqcache file and the problem was still there. I've reinstalled it back hoping it could fix, but nothing. Problem is still there.
I really appreciate your help as I'm unable to launch the shop before I can fix this problem.

My best regards,
ALandi

Wow..... I've just deleted all the comments in the top inside the xml file and all is working now.

This is a very good extension. Not sure about technical details :), but operacionally.

Re: [Extension] Banner Language

Posted: Tue Sep 11, 2012 12:19 am
by AvanOsch
Thanks for your comment.

I'll remove that stuff with the next update.
Glad things worked out in the end...

Re: [Extension] Banner Language

Posted: Wed Oct 17, 2012 4:53 pm
by tolinho
Hello.
I have installed the vqmod extension and have two languages.
Yesterday I decided to add a new banner.
For that I go to
System > Design > Banners
and I has getting this error has a other user sent a while back.

Image

I decided to delete all banners and re-add them all.
After I deleted then via:
System > Design > Banners pressing the delete button a now get this error:

Notice: Error: Duplicate column name 'language_id'
Error No: 1060
ALTER TABLE banner_image ADD language_id int(11) NOT NULL, ADD title varchar(64) COLLATE utf8_bin NOT NULL, DROP PRIMARY KEY, ADD PRIMARY KEY (`banner_image_id`, `language_id`) in D:\IIS\opencart1541\system\database\mysql.php on line 49


Yestarday I also found you did update your module on the 15th, so I downloaded that new updated vqmod and tested it.
But still have the same problem.

If I uninstall (&uninstall=true) your module and then remove the xml file the error goes away.

Help is much appreciated.
Thanks.

Re: [Extension] Banner Language

Posted: Wed Oct 17, 2012 7:03 pm
by AvanOsch
Do you have any messages in the vQMod log file?
Also, what OpenCart version are you running?

Re: [Extension] Banner Language

Posted: Wed Oct 17, 2012 7:16 pm
by tolinho
Hi.
In vqmod I have no messages.
I'm running opencart 1541

Re: [Extension] Banner Language

Posted: Thu Oct 18, 2012 5:22 am
by Da_Hobit
Hi,

i'm using your module ( nice one , thnx ) and i have the following question.

eacht time i refresh my page i first see all of my banners under each other and then they 'merge' into the sliding-banner
( i think that's because they need to be 'cached' )

is it possible to 'preload' the images or something ? so the users won't see them all the time they refresh or reload the page ?

thnx !

mvg,
Ivo

Re: [Extension] Banner Language

Posted: Thu Oct 18, 2012 5:35 am
by AvanOsch
Hi Hobit,

As I'm tracking down the error posted by Tolinho, I'll take a look into your problem too.
However, I can't say I ever saw your problem happen before...
Heel Vreemd... ;)

Re: [Extension] Banner Language

Posted: Sat Oct 20, 2012 1:01 am
by tolinho
Hi AvanOsch.
Just wondering if you managed to replicate the error I have on your side?

Re: [Extension] Banner Language

Posted: Mon Oct 22, 2012 7:20 pm
by suikerzout
Hi AvanOsch,

Thanks for making this available for free! I just have a bit of trouble getting it to work properly... I had to modify the .xml because of a small syntax error, by changing and adding the following in admin/view/template/design/banner_form.tpl:

Code: Select all

<operation>
			<search position="replace" error="skip"><![CDATA[<td class="left"><a onclick="$('#image-row<?php echo $image_row; ?>').remove();" class="button"><?php echo $button_remove; ?></a></td>]]></search> REMOVED SPAN TAGS HERE...
			<add><![CDATA[<br />
                  <a onclick="image_upload('image<?php echo $image_row; ?>', 'thumb<?php echo $image_row; ?>');"><?php echo $text_browse; ?></a>&nbsp;&nbsp;|&nbsp;&nbsp;<a onclick="$('#thumb<?php echo $image_row; ?>').attr('src', '<?php echo $no_image; ?>'); $('#image<?php echo $image_row; ?>').attr('value', '');"><?php echo $text_clear; ?></a></div></td>
              <td class="left"><a onclick="$('#image-row<?php echo $image_row; ?>').remove();" class="button"><?php echo $button_remove; ?></a></td>]]>
			</add>
		</operation>
		<operation>
			<search position="replace" offset="1"><![CDATA[<?php $image_row++; ?>]]></search>
			<add><![CDATA[<?php $image_row++; ?>]]></add> THERE WAS AN ILLEGAL } BELOW THIS LINE...
		</operation>
It works partly now, but if you add multiple items in a banner, it is behaving oddly by deleting previously entered items on save... There are also buttons in places they shouldn't be (see screen), so I guess something is not quite right here yet.

Any help much appreciated! Donation awaits if you can fix this ;)

Greetings,
Hugo

Re: [Extension] Banner Language

Posted: Mon Oct 22, 2012 7:28 pm
by AvanOsch
Hi Hugo,

What OpenCart version are you using?
I'm going to try and release a bugfixed version today.
I'd like to add your bug in this release too...

Met vriendelijke groeten, ;)
Albert

Re: [Extension] Banner Language

Posted: Mon Oct 22, 2012 7:39 pm
by suikerzout
Hoi Albert,

Dat zou natuurlijk mooi zijn! ;)

I've installed this on 1.5.3.1 and 1.5.4, both have the same problems...

Greetings,
Hugo

Re: [Extension] Banner Language

Posted: Mon Nov 12, 2012 6:09 pm
by tolinho
Hi AvanOsch.
Sorry to bother you again, but do you have any news on the reported issue?
Thanks

Re: [Extension] Banner Language

Posted: Tue Nov 13, 2012 5:38 am
by rph
If you don't want to wait Banners Plus has multi-language as one of its features. It's stable and has been out for 8 months now.

Re: [Extension] Banner Language

Posted: Tue Nov 13, 2012 6:35 pm
by AvanOsch
rph wrote:If you don't want to wait Banners Plus has multi-language as one of its features. It's stable and has been out for 8 months now.
Yeah, I'm guessing these people know that...
They probably just don't want to pay 20 bucks

--EDIT--
By the way, you don't see me posting at your extension pages, going like:
"You should check out this Free extension of mine"...
(Or criticizing your work, as you did before)