[Extension] Customer Group Discounts

eric_hsu wrote:

madimar wrote:Try to clean system/cache folder, maybe it is related to the same issue I was reporting

madimar wrote:AvantOsch,
I'm finally testing your contribution. I'm just thinking about again to the nested category point. It could be really great if a discount set to a category could be propagated to all its nested categories. At the moment, for my needs, this is a fundamental point.
Do you think it could be feasible?

eric_hsu wrote:I've solved my problem after installing the "clear cache" extension. it's really the catch problem.
Besides, I have another problem with "Default Group Discount" of "Customer group".
Can you tell me how to make it work and what's the function on it?

AvanOsch wrote:

eric_hsu wrote:I've solved my problem after installing the "clear cache" extension. it's really the catch problem.
Besides, I have another problem with "Default Group Discount" of "Customer group".
Can you tell me how to make it work and what's the function on it?

Hello Eric,

It's meant so set a Default discount for all Categories/Products/Options for a certain customer group.
If the discount-percentage should be the same throughout the catalog, you can set it with the "Default Group Discount".
This discount will be applied if no other discount is set for a Category/Product/Option.

public function getDiscount($pId) {
		$discount = false;
		$group_id = ($this->customer_group_id) ? $this->customer_group_id : (!$this->config->get('config_discount_login') ? $this->config->get('config_customer_group_id') : false);
		$query = $this->db->query("SELECT DISTINCT category_id as id FROM " . DB_PREFIX . "product_to_category WHERE product_id = '" . (int)$pId . "'");
		if ($query->num_rows && $group_id) {
			$query = $this->db->query("SELECT DISTINCT discounts FROM " . DB_PREFIX . "category WHERE category_id = '" . (int)$query->row['id'] . "'");
			if ($query->row['discounts'] && strpos($query->row['discounts'], '|')) {
				$discounts = explode(' ', $query->row['discounts']);
				foreach ($discounts as $group) {
					$group = explode('|', $group);
					if ($group[0] == $group_id) $discount = 1 - ((float)$group[1] / 100);
				}
			}
		}
		if (!$discount) {
			$discount = 1;
			if ($group_id) {
				$query = $this->db->query("SELECT DISTINCT discount FROM " . DB_PREFIX . "customer_group WHERE customer_group_id = '" . (int)$group_id . "'");
				if ($query->num_rows) $discount = 1 - ((float)$query->row['discount'] / 100);
			}
		}
		return $discount;
  	}

mickyp wrote: I found that there is a bug when the category discount is set to empty string.
When category discount is set to empty string, the group discount won't be calculated, the product price will no longer show the special price.
..............
We should focus on this line
if ($group[0] == $group_id) $discount = 1 - ((float)$group[1] / 100);

When the category discount is set to empty string, the $group[1] will be the empty string. And hence you can't calculate an "empty string divide by 100" <-- non sense.
So the $discount will always be set to some value, and cause the group discount failed to calculate.

Or the bug is caused by the category table has dirty discounts?!
I mean when I clear all content inside the category discount page, I found the category table in the database still have some value like "1| 2| 3|" in the discounts field.
..................
Sincerely,
Micky

dunn123 wrote: 1. The discount on options for customer groups isnt being applied. I can log in as a trade customer go to a product, the base price is reduced from the discount assigned to the customer group but no discount applied to the options.
2. if I add a product to the shopping basket it adds it at the default price not the discounted one.

dunn123 wrote:Hi
I am wondering if there is a way to assign an option price by customer group with a fixed amount not a % discount.
.............
Your mod works great for the % based discounts but I am struglling with the fixed price discount. Any ideas would be appreciated.

AvanOsch wrote:

madimar wrote:AvantOsch,
I'm finally testing your contribution. I'm just thinking about again to the nested category point. It could be really great if a discount set to a category could be propagated to all its nested categories. At the moment, for my needs, this is a fundamental point.
Do you think it could be feasible?

It's feasible, but unnecessary IMO...
You can go to Catalog --> Categories, Select the parent category and all it's children, and set the discount(s) for those categories from there using the Discounts Dialog...

AvanOsch wrote: Dunn123, I think (hope ) those bugs have to do with the previously reported cache-problem.
Amma get to it asap.

madimar wrote:are you going to work on a fix for caching problem?

cpeltier wrote:Am testing now on 1.5.31. Will it still take graduating discounts, ie 500:30%,1000:35%,1500:40%,999999:40% in the group discount? Sorry if this double posts.