Page 2 of 10
Re: Downloads Not Displaying in Admin
Posted: Fri Dec 24, 2010 5:08 pm
by JAY6390
SiteE@se wrote:
The language switcher code will now just have to be deleted manually from the header.tpl template file. I always thought the advice had been to disable this and the currency in the admin backend? Perhaps things have changed ......
You should delete all but the currency and language you want to use, then use CSS to hide the elements - either display: none; or visibility: hidden
You need a currency and a language

Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 1:53 am
by Lao
After updating from 1.4.9.2 to 1.4.9.3 yesterday I can no longer access Sales/Customers in Admin. It looks like it doesn't find the page.
Any idea why?
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 2:10 am
by SapporoGuy
Need to post a little more.
Can you see the link?
What kind of error happens?
Double check to see if you uploaded "ALL" the files.
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 2:22 am
by Lao
I already checked that.
It seems the problem was with the Gzip compression I "played" with earlier. My fault. Is there any gain in putting anything greater than 0 in Gzip compression?
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 4:38 am
by Skipper
I find the get() function in system/library/cache.php a little strange. At least, the return() statement should be moved up into the if($handle) block. Otherwise, the foreach() would be useless and a simple $files[0] would do the trick.
IMHO, the function should look like this
Code: Select all
public function get($key) {
$files = glob(DIR_CACHE . 'cache.' . $key . '.*');
if ($files) {
foreach ($files as $file) {
$cache = '';
$handle = fopen($file, 'r');
if ($handle) {
$cache = fread($handle, filesize($file));
fclose($handle);
return unserialize($cache);
}
}
}
}
Being here, the __construct() may have some small optimisation as well. The if() in this snippet is pretty useless, as the unlink() will take care of this anyway.
Code: Select all
if (file_exists($file)) {
@unlink($file);
}
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 5:19 am
by Xsecrets
Skipper wrote:
Being here, the __construct() may have some small optimisation as well. The if() in this snippet is pretty useless, as the unlink() will take care of this anyway.
Code: Select all
if (file_exists($file)) {
@unlink($file);
}
actually since display error notices are on by default then the if() is needed otherwise you will get error notices displayed.
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 3:01 pm
by Qphoria
Lao wrote:I already checked that.
It seems the problem was with the Gzip compression I "played" with earlier. My fault. Is there any gain in putting anything greater than 0 in Gzip compression?
When there are no errors on the page, gzip should work fine and improve page speed. Only in the case where there are errors should gzip cause the page to not load. Check the error log for errors on that page
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 3:02 pm
by Qphoria
Xsecrets wrote:Skipper wrote:
Being here, the __construct() may have some small optimisation as well. The if() in this snippet is pretty useless, as the unlink() will take care of this anyway.
Code: Select all
if (file_exists($file)) {
@unlink($file);
}
actually since display error notices are on by default then the if() is needed otherwise you will get error notices displayed.
Yea this is a race condition and the if() was added to try to help the problem with an error message stating that the unlink failed because the file doesn't exist. It's still not a 100% solution tho
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Tue Dec 28, 2010 7:07 pm
by Skipper
Not sure I can follow you. The following snippet is 100% quiet at the unlink(). Because of the at-operator, I assume.
Code: Select all
error_reporting(E_ALL | E_STRICT);
ini_set('display_errors', '1');
@unlink("blafasel");
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Wed Dec 29, 2010 12:50 am
by krittawit_st
in catalog/model/shipping/flat.php on line 27
Code: Select all
'title' => $this->language->get('text_title'),
should be
Code: Select all
'title' => $this->language->get('text_description'),

Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Wed Dec 29, 2010 12:57 am
by Lao
Qphoria wrote:Lao wrote:I already checked that.
It seems the problem was with the Gzip compression I "played" with earlier. My fault. Is there any gain in putting anything greater than 0 in Gzip compression?
When there are no errors on the page, gzip should work fine and improve page speed. Only in the case where there are errors should gzip cause the page to not load. Check the error log for errors on that page
I get this:
2010-12-27 22:58:53 - PHP Notice: Undefined variable: text_error in /usr/home/clients/HR7409/domains/importpieseauto.ro/catalog/view/theme/default/template/product/category.tpl on line 15
2010-12-28 2:37:07 - PHP Notice: Undefined variable: text_error in /usr/home/clients/HR7409/domains/importpieseauto.ro/catalog/view/theme/default/template/product/category.tpl on line 15
And line 15 of category.tpl is:
Code: Select all
<div class="content"><?php echo $text_error; ?></div>
Any ideas what I should check or modify?
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Wed Dec 29, 2010 5:35 am
by Qphoria
Skipper wrote:Not sure I can follow you. The following snippet is 100% quiet at the unlink(). Because of the at-operator, I assume.
Code: Select all
error_reporting(E_ALL | E_STRICT);
ini_set('display_errors', '1');
@unlink("blafasel");
Yes that is, but it bypasses the custom error handler that opencart uses
Google feed and discounted price v1.4.9.3
Posted: Wed Dec 29, 2010 11:04 pm
by david25
New Google base product feed works fine with USD and GBP now, but still does not take discounted price into account.
Is this a bug or is this the way it should work ?
Thank you for your comments !
Re: Google feed and discounted price v1.4.9.3
Posted: Thu Dec 30, 2010 2:42 am
by Qphoria
david25 wrote:New Google base product feed works fine with USD and GBP now, but still does not take discounted price into account.
Is this a bug or is this the way it should work ?
Thank you for your comments !
Not really a bug, just needs a feature request to add it
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Thu Dec 30, 2010 5:32 pm
by krittawit_st
Can't move image in image manager.
popup appear, but no list of folder.
it say "Warning: Invalid argument supplied for foreach() in .../admin/controller/common/filemanager on line 378"
how to fix it. thank you.
Edit : It work in chrome but not work in firefox and ie.
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Thu Jan 06, 2011 11:58 am
by Qphoria
Lao wrote:I already checked that.
It seems the problem was with the Gzip compression I "played" with earlier. My fault. Is there any gain in putting anything greater than 0 in Gzip compression?
You should only get a blank page with gzip compression if there is an error. Load that page and check the system error log and see if there was some reason why you got an error
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Thu Jan 06, 2011 11:43 pm
by Lao
I think I encountered another 1.4.9.3 bug.
The story:
Customer orders product, priced 199 RON.
Shipping is priced 25 RON.
Total: 199+25= 224 RON
After talking on the phone, he requested that I add another product, price 89 RON.
After I did this in Admin,
Sub-Total is ok (288 RON), 0.00 I guess it's from the product option, but Total showed it's wrong: 224 RON (it's the OLD Total).
Anyway, bellow it, everything it's ok, I mean the 313.00 RON.
See attachment for clearer understanding.
Order_Edit.JPG (51.5 KiB) Viewed 6474 times
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Fri Jan 07, 2011 12:57 am
by Qphoria
The total is not the last row in your picture.. Total should always be last and I think the code assumes the last row will get the update.
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Fri Jan 07, 2011 1:34 am
by Lao
So all I have to do is change places of Total with Shipping method in Order Totals.
I put Total the very last now.
Re: OFFICIAL v1.4.9.3 BUG THREAD. POST ALL BUGS HERE
Posted: Fri Jan 07, 2011 3:21 am
by berushka
I think there is a problem with approved customers. I have approving customers switched off in administration. I upgrade from 1.4.0 to 1.4.9.3 and now I see that all customers added before upgrade are also customers awaiting approval. I think it is bug in upgrade script or it is bug in dashboard - if I have switched off customer approving then dashboard haven't show number of customers awaiting approving. And also column Approved in Customers is useless.