Category?page=100 returns a page - how to prevent that?

by mona wrote: ↑

Fri Sep 03, 2021 6:03 pm

Code: Select all

 if (!$results && (int)$page != 1) {
	$this->response->redirect($this->url->link('error/not_found'));
}

You can do that but remember, a 404/410 should be given when a page does not exist, not when no products are found, website-logic vs. business-logic.

When a request is made for page=10 but page 10 does not exist (given the number of products and the limit), you could give a 404 and when you do not let page= be indexed requests for them should not happen unless manually entered.

Code: Select all

			// non-existent pages (requested page > number of pages)
			if (!empty($this->request->get['page'])) {
				if (ceil($product_total / $limit) < $this->request->get['page']) {
					header($_SERVER['SERVER_PROTOCOL'] . ' 404 Not Found', true);
					exit();
				}
			}

However, when a page does not yield products, you simply state that no products are found, you do not give a 404, the page exists, the products don't.
You could have combinations of filters, price ranges, search keywords, etc. which simply yield no products.
In short, the $results are irrelevant for a 404 response.