Page 2 of 3

Re: [Released] Simple HTML Module

Posted: Fri Jun 11, 2010 1:15 am
by Qphoria
There is a missing line in the controller. I'm not sure how it ever worked in 1.4.7, but it seems to break in 1.4.8

You are calling the getLanguages function but you need to load the model file first

1. EDIT: catalog/controller/module/mymodule.php

2. FIND:

Code: Select all

$languages = $this->model_localisation_language->getLanguages(); 
3. BEFORE, ADD:

Code: Select all

$this->load->model('localisation/language'); 

Re: [Released] Simple HTML Module

Posted: Fri Jun 11, 2010 11:55 am
by saccarrep
Thx Qphoria,

I'll update it as soon as my apache+php+mysql are installed :)

Re: [Released] Simple HTML Module

Posted: Sun Jun 13, 2010 4:14 pm
by saccarrep
Updated, now works on opencart 1.4.8 :)

Re: [Released] Simple HTML Module

Posted: Tue Jun 15, 2010 4:23 pm
by mystifier
There is an odd small problem with the module saccarrep (v1.4.8 ). As a simple example -

The below works fine (Save returns to Modules page):
<p style="text-align: center">
<a href="http://localhost/opencart/index.php?rou ... ext</a></p>

But the below fails and doesn't save (Save returns to Dashboard page):
<p style="text-align: center">
<a href="http://localhost/opencart/index.php?rou ... path=37_36">
<img alt="" src="http://localhost/opencart/image/data/image.jpg" /></a></p>

I think it may be something the editor is doing because it is possible to get it to work by writing in editor 'source' mode without ever changing to 'view' mode.

Re: [Released] Simple HTML Module

Posted: Tue Jun 15, 2010 4:39 pm
by saccarrep
mystifier wrote: I think it may be something the editor is doing because it is possible to get it to work by writing in editor 'source' mode without ever changing to 'view' mode.
Yes, you are right. I tried it in editor mode and after successfully saved, it can be edited in 'view' mode. But it fail if the first attempt is using the 'view' mode.
Maybe its 'browse server' that cause the problem. I used the 'browse server' and it failed to save but when I change the file name directly and not clicking the 'browse server' and directly click OK it successfully save

Re: [Released] Simple HTML Module

Posted: Sat Jun 19, 2010 7:32 am
by saccarrep
Updated...
Now it can be put on 'home' location ;D
shmhome.jpg

Mymodule on home location - shmhome.jpg (20.29 KiB) Viewed 8986 times


Re: [Released] Simple HTML Module

Posted: Mon Jul 05, 2010 10:31 am
by saccarrep
Updated...
Fixed invalid token error when adding image

Re: [Released] Simple HTML Module

Posted: Wed Jul 21, 2010 12:13 am
by jeebee2009
hi
i'm on 1,4,7 french language
i got this error when i tried to modify the module


Notice: Undefined index: token in /www/admin/controller/module/mymodule.php on line 46
Notice:Undefined index: token in /www/admin/controller/module/mymodule.php on line 69
Notice:Undefined index: token in /www/admin/controller/module/mymodule.php on line 75
Notice: Undefined index: token in /www/admin/controller/module/mymodule.php on line 81
Notice: Undefined index: token in /www/admin/controller/module/mymodule.php on line 86
Notice: Undefined index: token in /www/admin/controller/module/mymodule.php on line 88

tryed with mymodule v1,7
any idea ?

Re: [Released] Simple HTML Module

Posted: Wed Jul 21, 2010 3:12 am
by mystifier
The botton of the admin .tpl file is mal-formed with script and comment blocks not closed (and hence the footer being cut off).

Not knowing exactly what is supposed to be there, I will stick with v1.6 for now. It is fundamentally useful though and well deserves being in the core when fixed.

Re: [Released] Simple HTML Module

Posted: Thu Jul 22, 2010 12:33 am
by saccarrep
mystifier wrote:The botton of the admin .tpl file is mal-formed with script and comment blocks not closed (and hence the footer being cut off).
Will check it soon
mystifier wrote:Not knowing exactly what is supposed to be there, I will stick with v1.6 for now. It is fundamentally useful though and well deserves being in the core when fixed.
v.1.7 basically the same as v.1.6 it just fixed the token error when dealing with image in v.1.6

Re: [Released] Simple HTML Module

Posted: Thu Jul 22, 2010 6:46 am
by saccarrep
mystifier wrote:The botton of the admin .tpl file is mal-formed with script and comment blocks not closed (and hence the footer being cut off).
Fixed the footer problem. (the script is for the token problem in v.1.6) :)

Re: [Released] Simple HTML Module

Posted: Sun Aug 22, 2010 1:30 am
by Joxe
Is it possible to paste google adsense code on this module? I tried but I only get the code itself on my webpage frontend :-\

Re: [Released] Simple HTML Module

Posted: Thu Aug 26, 2010 5:32 am
by Joxe
Joxe wrote:Is it possible to paste google adsense code on this module? I tried but I only get the code itself on my webpage frontend :-\

No one ???

Re: [Released] Simple HTML Module

Posted: Thu Aug 26, 2010 3:34 pm
by mystifier
Yes, it is possible to add javascript, I do so on my own site with no problem.

If you can see the code, it is simply the case that you have added it in 'text' rather than 'html' mode in the editor so it is being displayed literally rather than being rendered.

Re: [Released] Simple HTML Module

Posted: Mon Aug 30, 2010 6:05 pm
by Joxe
Hi,

Thanks mystifier! You were right. ;)

Now, I only have to figure out the best size of the ad because if it's too small it will cut the text or picture; and if it's too big it will go out of the box module ::)

Re: [Released] Simple HTML Module

Posted: Tue Aug 31, 2010 11:46 am
by mjdallas
I have installed the module and it looks to be working, but I am not getting the WYSIWYG editor that I have seen in some of the other screen shots. Has that feature been removed?

Also, is there a way to have this module display as one of the other pages ("about Us" for example) from the information links instead of just on the home page?

Re: [Released] Simple HTML Module

Posted: Wed Sep 01, 2010 12:43 pm
by mjdallas
ok, I got it working. There was a problem with my install and the WYSIWYG editor wasn't showing up in the Admin panel (None of them were showing up). All is well. ;D

Re: [Released] Simple HTML Module

Posted: Sun Sep 19, 2010 7:56 pm
by mystifier
Has anyone succeeded in getting Simple HTML Module work with multi-store so that instances of it only show on required stores?

(It is not simply a case of adding tpl to store template because this gives a template load error on stores where it is not used).

Re: [Released] Simple HTML Module

Posted: Tue Sep 21, 2010 5:09 am
by j8yba
is there a way to have multiple additions of this, ie. i have one on left and one on right?

Re: [Released] Simple HTML Module

Posted: Wed Sep 22, 2010 1:19 am
by Joxe
j8yba wrote:is there a way to have multiple additions of this, ie. i have one on left and one on right?
Yeah, it's possible. You just have the change the name in some files: ie Module2, Module3, etc...