So you're saying that even though the commit was provided with the IF statement, the __destroy() method still needs to be used?
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
In system/library/session.php is the same code from last time
With destruct function will show errors...you can't even to login.
If you change to:
No errors and work just fine
https://github.com/opencart/opencart/issues/7522
and in system/library/session/db.php is this function
Code: Select all
public function __destruct() {
$this->adaptor->destroy($this->session_id);
}If you change to:
Code: Select all
public function destroy() {
$this->adaptor->destroy($this->session_id);
}https://github.com/opencart/opencart/issues/7522
and in system/library/session/db.php is this function
Code: Select all
public function destroy($session_id) {
$this->db->query("DELETE FROM `" . DB_PREFIX . "session` WHERE session_id = '" . $this->db->escape($session_id) . "'");
return true;
}Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
That's because the __destroy() method doesn't exist in PHP and most likely the close connection won't respond. What if you put it back to __destruct() but remove all the code inside so to keep the method empty. Does it still show the error?xxvirusxx wrote: ↑Mon Jun 01, 2020 10:35 pmIn system/library/session.php is the same code from last timeWith destruct function will show errors...you can't even to login.Code: Select all
public function __destruct() { $this->adaptor->destroy($this->session_id); }
If you change to:No errors and work just fineCode: Select all
public function destroy() { $this->adaptor->destroy($this->session_id); }
https://github.com/opencart/opencart/issues/7522
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
As Daniel said on github and what I understand he changed in destroy because db.php file has a function destroy.
So destroy from session call destroy from db to run this SQL command
Daniel changed...
https://github.com/opencart/opencart/co ... 5aba2e3402
So destroy from session call destroy from db to run this SQL command
Code: Select all
$this->db->query("DELETE FROM `" . DB_PREFIX . "session` WHERE session_id = '" . $this->db->escape($session_id) . "'");https://github.com/opencart/opencart/co ... 5aba2e3402
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Ok. That's what he meant by that. Now that it's clearer, I will update the package accordingly.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package and change log updated.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package and change logs have been updated. Added common/pagination controllers and TWIG files and removed the old pagination library class.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Package updated and change logs as well.
- Added product/thumb as per the master branch.
- Fixed product rating as per this post and commit: viewtopic.php?f=201&t=218203&p=789035&h ... ng#p789029 .
- Added product/thumb as per the master branch.
- Fixed product rating as per this post and commit: viewtopic.php?f=201&t=218203&p=789035&h ... ng#p789029 .
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Updated package and change logs accordingly.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
The latest distribution has been published now in the releases and changelog updated accordingly. Most of the recent commits by Daniel were integrated into the pre-released version.
Starting from this point, should anyone have any feature issues already coded from the core, please address them on Github Opencart.
Thank you.
Starting from this point, should anyone have any feature issues already coded from the core, please address them on Github Opencart.
Thank you.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
@xxvirusxx: Found the commit fix from Daniel about returns to read: return: https://github.com/opencart/opencart/co ... 5a57081e26 . This will be integrated shortly.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
returns has now been fixed on the new published update.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Hello straightlight and xxvirusxx great job both of you, closed bugs for waiting a long time....maybe yearsstraightlight wrote: ↑Wed Jun 03, 2020 11:28 pmreturns has now been fixed on the new published update.
straightlight all these bugs has mention xxvirusxx updated all >>> to last pre release 3.0.3.4 ;
thanks
Παρέχουμε VPS Hosting σε Ελλαδα & Γερμανία σε ιδιόκτητους Dell Enterprise PowerEdge Servers
https://www.fivelayer.host/
Opencart ESHOP
https://www.think-open.gr/
Thanks for the feedback. I have just re-updated the package which fixes the custom fields as well as sanitizing the admin sale order ID.noname1 wrote: ↑Thu Jun 04, 2020 10:31 pmHello straightlight and xxvirusxx great job both of you, closed bugs for waiting a long time....maybe yearsstraightlight wrote: ↑Wed Jun 03, 2020 11:28 pmreturns has now been fixed on the new published update.
straightlight all these bugs has mention xxvirusxx updated all >>> to last pre release 3.0.3.4 ;
thanks
@Add Creative: I will look into this to sanitize all _id prefixes that represents an integer; not the ones for the APIs. However, since all the service provider extensions have been removed from the core, this shouldn't take too long to sanitize nowadays.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Change _destroy to destroy
Before to pack remove from storage: cache content (no index), logs (no index), modification (no index), session (no .htaccess, index)
And use high compression for zip.
Before to pack remove from storage: cache content (no index), logs (no index), modification (no index), session (no .htaccess, index)
And use high compression for zip.
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
__destroy: Fixed.
Removed cache, logs, modification but the indexes remains there.
High compression: Denied. Normal compression is enough to ZIP this package. Besides, TAR files have no options for it. Only ZIP format.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
@Add Creative: All (if not, to the most possible ones that I found), integers variables have now been sanitized.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Re-uploaded the package.
- Modified order totals' getTotal parameters.
- Sanitized all IDs from $this->request->get/post requests on the browser.
- Fixed __destroy to read: destroy
- Worked on all catalog models.
- Fixed pagination class in admin setting/store page.
- Modified order totals' getTotal parameters.
- Sanitized all IDs from $this->request->get/post requests on the browser.
- Fixed __destroy to read: destroy
- Worked on all catalog models.
- Fixed pagination class in admin setting/store page.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Hi,
I just wanted to say thanks very much to Straightlight and also xxvirusxx for all your work on this.
Its fantastic to see so many issues and bugs being sorted out.
I am still on 1.5.5.1 but this year am intending to migrate to a fresh install of the latest Opencart.
Do you have an estimate for when v3.0.3.4 will become the official release for download on the opencart site?
Many thanks to you for working on this!
I just wanted to say thanks very much to Straightlight and also xxvirusxx for all your work on this.
Its fantastic to see so many issues and bugs being sorted out.
I am still on 1.5.5.1 but this year am intending to migrate to a fresh install of the latest Opencart.
Do you have an estimate for when v3.0.3.4 will become the official release for download on the opencart site?
Many thanks to you for working on this!
You can change to Best and is enough only zip archive.straightlight wrote: ↑Fri Jun 05, 2020 4:35 amHigh compression: Denied. Normal compression is enough to ZIP this package. Besides, TAR files have no options for it. Only ZIP format.
And remove image cache.
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Who is online
Users browsing this forum: No registered users and 2 guests
