Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Should be:
Code: Select all
'sort_order' => $this->config->get('total_sub_total_sort_order')Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Code: Select all
$this->model_catalog_recurring->getRecurringDescriptionCode: Select all
public function getDescriptionCode: Select all
// Check install directory exists
if (is_dir(DIR_APPLICATION . 'install')) {Code: Select all
// Check install directory exists
if (is_dir(DIR_CATALOG . '../install')) {Code: Select all
if (isset($this->request->get['ckeditor'])) {
$data['ckeditor'] = $this->request->get['ckeditor'];
} else {
$data['ckeditor'] = '';
}https://github.com/opencart/opencart/co ... bc45c5e773
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Not sure what you mean ... both shows the same method names from the controller calling the model and the same name is showing in the model recurring you're showing on the above for: getRecurringDescription ...xxvirusxx wrote: ↑Mon Jun 01, 2020 5:48 am- admin/controller/catalog/recurring.php, not same function as in model
and modelCode: Select all
$this->model_catalog_recurring->getRecurringDescription- admin/controller/common/dashboard, changed in master branchCode: Select all
public function getDescriptionto:Code: Select all
// Check install directory exists if (is_dir(DIR_APPLICATION . 'install')) {-filemanager is the sameCode: Select all
// Check install directory exists if (is_dir(DIR_CATALOG . '../install')) {- new route in admin/controller/common/securityCode: Select all
if (isset($this->request->get['ckeditor'])) { $data['ckeditor'] = $this->request->get['ckeditor']; } else { $data['ckeditor'] = ''; }
https://github.com/opencart/opencart/co ... bc45c5e773
As for the DIR_CATALOG in the common/dashboard controller, confirmed - fixed.
As for the file manager, don't know what happened there. It's been fixed and will be ready on the next update.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Was more easy to check if these changes was on github
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
No problem. At least there are 2 more problems you described that were identified.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Still therexxvirusxx wrote: ↑Mon Jun 01, 2020 5:03 amShould be:Code: Select all
'sort_order' => $this->config->get('total_sub_total_sort_order')
Stil there (admin/controller/common/security)straightlight wrote: ↑Mon Jun 01, 2020 6:09 amAs for the DIR_CATALOG in the common/dashboard controller, confirmed - fixed.
Code: Select all
if (!$this->user->hasPermission('modify', 'common/developer')) {Wrong:
Code: Select all
$data['filters'] = $this->model_catalog_filter->getGroupDescriptions($this->request->get['filter_group_id']);Code: Select all
$data['filters'] = $this->model_catalog_filter->getDescriptions($this->request->get['filter_group_id']);-admin/model/catalog/product.php
At line 311 you use:
Code: Select all
$data['product_filter'] = $this->getFilters($product_id);Code: Select all
public function getProductFilters($product_id) {Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Ok, all fixed now. That's because I reversed the package due to the login workaround solution on Github you provided and may have forgot some spots since. The next update should be good in a moment.xxvirusxx wrote: ↑Mon Jun 01, 2020 2:43 pmNot fixed
Still therexxvirusxx wrote: ↑Mon Jun 01, 2020 5:03 amShould be:Code: Select all
'sort_order' => $this->config->get('total_sub_total_sort_order')Stil there (admin/controller/common/security)straightlight wrote: ↑Mon Jun 01, 2020 6:09 amAs for the DIR_CATALOG in the common/dashboard controller, confirmed - fixed.- admin/controller/catalog/filterCode: Select all
if (!$this->user->hasPermission('modify', 'common/developer')) {
Wrong:Should be:Code: Select all
$data['filters'] = $this->model_catalog_filter->getGroupDescriptions($this->request->get['filter_group_id']);Same problem in filter model...line 106 should be getGroupDescriptionsCode: Select all
$data['filters'] = $this->model_catalog_filter->getDescriptions($this->request->get['filter_group_id']);
-admin/model/catalog/product.php
At line 311 you use:But function is wrong, line 466Code: Select all
$data['product_filter'] = $this->getFilters($product_id);Same for options, imagesCode: Select all
public function getProductFilters($product_id) {
As for the common/security, you say: still there. However, I don't see anywhere else on the topic where this issue has been addressed prior.
Also fixed an additional bug in admin/controller/user/api.php - line 372.
Code: Select all
if (!$this->user->hasPermission('modify', 'user/user')) {
Code: Select all
if (!$this->user->hasPermission('modify', 'user/api')) {
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Controller security use this:straightlight wrote: ↑Mon Jun 01, 2020 6:35 pmAs for the common/security, you say: still there. However, I don't see anywhere else on the topic where this issue has been addressed prior.
Code: Select all
if (!$this->user->hasPermission('modify', 'common/developer')) {Code: Select all
if (!$this->user->hasPermission('modify', 'common/security')) {Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Yes, now that it's being mentioned, as said above, it's been fixed now. However, with the provided commit, it's even better.xxvirusxx wrote: ↑Mon Jun 01, 2020 6:42 pmController security use this:straightlight wrote: ↑Mon Jun 01, 2020 6:35 pmAs for the common/security, you say: still there. However, I don't see anywhere else on the topic where this issue has been addressed prior.
Normaly should be this:Code: Select all
if (!$this->user->hasPermission('modify', 'common/developer')) {https://github.com/opencart/opencart/co ... bc45c5e773Code: Select all
if (!$this->user->hasPermission('modify', 'common/security')) {
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Edit: Ok, spotted. Group and filters without groups. That was a hard spot to catch.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
In controller is this:
Code: Select all
$history_total = $this->model_marketing_coupon->getCouponHistoriesUpgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Users browsing this forum: No registered users and 3 guests
