Page 6 of 6

Re: [RELEASED] Request Reviews

Posted: Tue Sep 17, 2013 7:02 am
by clapiana
if i do a test email i get the email in my gmail and it has the images and the links working fine. if i try to do a live run admin is added to the path and the images dont work and the link doesnt. i looked at the vqmod xml maybe i hard code my site into it?

Re: [RELEASED] Request Reviews

Posted: Tue Sep 17, 2013 12:45 pm
by i2Paq
I cannot reproduce this.

I'm running 1.5.4.1 and all is fine.

Re: [RELEASED] Request Reviews

Posted: Fri Sep 20, 2013 12:06 am
by clapiana
really strange.....i created a dummy order and waited a day. i just did a live email only selecting the dummy order and the images and links are broken because admin is being added to the path. i go back into the mod and do a test email to the same email address and the images are working and the link back to the site. any idea what file is used for sending a 'test center' email vs sending a live request to a customer's email?

Re: [RELEASED] Request Reviews

Posted: Fri Sep 27, 2013 3:22 am
by Madness Jason
Bugsafari wrote:Version 1.5.x.x on a 1.5.0 cart at bugsafari.co.uk. I've a couple of issues that I hope you can address:

1) I have sent several test emails to several addresses. Most of these have worked fine. However, in AOL, only the HTML code of the message was displayed. I frequently use AOL and have never before experienced problems viewing HTML messages. Do you have a fix for this?

2) Some images were not displayed correctly in Gmail. I understand from the forum that has been a problem displaying images with a space in their name. Are you aware of any other characters that affect the display of images? How can this be resolved?

I look forward to hearing from you.

Many thanks,
I know that the original question is old.

But I was indeed having trouble with images displaying incorrectly with Gmail, this being because for some reason on Gmail the spaces convert to + and Opencart does not understand that, it uses %20, therefore, I did the following edits:

Open up admin\controller\sale\request_review.php

From line 371 to 377, find and replace this:

Code: Select all

                    if (file_exists(DIR_IMAGE . $cached_image)) {
                        $product_image = $order['store_url'] . 'image/' . $cached_image;
                    } elseif (file_exists(DIR_IMAGE . $product['image'])) {
                        $product_image = $order['store_url'] . 'image/' . $product['image'];
                    } else {
                        $product_image = $order['store_url'] . 'image/no_image.jpg';
                    }
With this:

Code: Select all

                    if (file_exists(DIR_IMAGE . $cached_image)) {
                        $product_image = $order['store_url'] . 'image/' . str_replace(" ", "%20", $cached_image);
                    } elseif (file_exists(DIR_IMAGE . $product['image'])) {
                        $product_image = $order['store_url'] . 'image/' . str_replace(" ", "%20", $product['image']);
                    } else {
                        $product_image = $order['store_url'] . 'image/no_image.jpg';
                    }
And again from line 571 to 577, find and replace this:

Code: Select all

                    if (file_exists(DIR_IMAGE . $cached_image)) {
                        $product_image = $store_data['url'] . 'image/' . $cached_image;
                    } elseif (file_exists(DIR_IMAGE . $product['image'])) {
                        $product_image = $store_data['url'] . 'image/' . $product['image'];
                    } else {
                        $product_image = $store_data['url'] . 'image/no_image.jpg';
                    }
with:

Code: Select all

                    if (file_exists(DIR_IMAGE . $cached_image)) {
                        $product_image = $store_data['url'] . 'image/' . str_replace(" ", "%20", $cached_image);
                    } elseif (file_exists(DIR_IMAGE . $product['image'])) {
                        $product_image = $store_data['url'] . 'image/' . str_replace(" ", "%20", $product['image']);
                    } else {
                        $product_image = $store_data['url'] . 'image/no_image.jpg';
                    }

And it now displays correctly.

This simply replaces the spaces with %20 so Gmail or any other mail provider doesn't see the space but rather the %20.

Image

Re: [RELEASED] Request Reviews

Posted: Fri Sep 27, 2013 12:50 pm
by i2Paq
Madness Jason wrote: I know that the original question is old.
Thank you!

I've updated my post wit a link to your solution and I will add it to the zip with fixes.

Re: [RELEASED] Request Reviews

Posted: Tue Oct 15, 2013 7:21 pm
by OC2PS
Finally, it breaks!

Looks like 1.5.6 doesn't like this module.

Re: [RELEASED] Request Reviews

Posted: Tue Oct 15, 2013 7:55 pm
by i2Paq
1.5.6 sucks ;D

Re: [RELEASED] Request Reviews

Posted: Mon Apr 06, 2015 5:32 am
by varnco
I just installed this on 1.5.6 and I am getting a database error...

Does this not work with 1.5.6

Re: [RELEASED] Request Reviews

Posted: Mon Apr 06, 2015 6:32 am
by varnco
Okay, so now it's working with 1.5.6, and I did nothing to fix it.

I did still have to apply the above Gmail fix to get images to display in Gmail.

Re: [RELEASED] Request Reviews

Posted: Thu May 07, 2015 1:44 pm
by thbr02
This is a really good module. I wish it was rewritten for Opencart 2.0.2.0. Is there any chance to see this module for that version?