Opencart 4 Upgrade Fix

straightlight wrote: ↑

Thu Jul 06, 2023 7:26 am

Any reasons for those codes to be added?

// Rise files per batch limit
                    $php = str_replace("\$limit = 200;",
                    "\$limit = 1000;", $php);

// Fix file copy error display
                    $php = str_replace("\$this->language->get('error_copy')",
                        "'Failed to copy file %s to %s'", $php);

$json['text'] = 'Upgrading DB, this may take some time...';

$('#status').html(

MaxD wrote: ↑

Thu Jul 06, 2023 8:09 am

straightlight wrote: ↑

Thu Jul 06, 2023 7:26 am

Any reasons for those codes to be added?

Sure, each code is added for a reason )

Code: Select all

// Rise files per batch limit
                    $php = str_replace("\$limit = 200;",
                    "\$limit = 1000;", $php);

Current update implementation has super-slow zip extraction way - it actually opens zip for each file, extracts single file, and closes it. Fixing this increased unzip speed 10x at least. After that the limit to extract 200 files per request is very low, so it is raised. Even with limit 1000 single request takes like 2 seconds.

Code: Select all

// Fix file copy error display
                    $php = str_replace("\$this->language->get('error_copy')",
                        "'Failed to copy file %s to %s'", $php);

The "error_copy" string is simply missing in install/language/en-gb/upgrade/upgrade.php, and guess what? If upgrade step 2 (most files extraction) fails to write some file - it just says error_copy instead of any details )))

Code: Select all

$json['text'] = 'Upgrading DB, this may take some time...';

Upgrading DB takes most time in upgrade process now, and it is not indicated in any special way. People can think that the process got hung, so I added additional indication what's going on and that this will take some time.

Code: Select all

$('#status').html(

If some error happen (that gives error output instead of pretty JSON), the upgrade tool makes the worst thing it could do - nothing! Literally nothing, it keeps showing current step text (like 'Extracting files ...') forever. Poor user will wait some 10 minutes thinking the process is going - but it was finished with error long ago ))

This is the fix for that, if any sort of error happens - it will be displayed as big red text.

If you are wondering why there are 2 hardcoded text strings - I'm pretty sure that nobody will do translations specially for my fix.

straightlight wrote: ↑

Thu Jul 06, 2023 9:39 pm

Here's the answer: https://github.com/opencart/opencart/is ... 1623693891 .