Category?page=100 returns a page - how to prevent that?

straightlight wrote: ↑

Thu Sep 02, 2021 6:05 am

OC version. So, what are you referring about exactly?

https://www.carguygarage.com/storage/cabinets/polished-stainless-steel-cabinets?page=2

https://www.carguygarage.com/accessories/decor?sort=pd.name&order=DESC&limit=isjfgyevlvttii

by mona wrote: ↑

Thu Sep 02, 2021 3:34 pm

Redirecting page=10 to your home page is a bad idea.

So ideally, do not allow indexing of those, via htaccess and/or x-robot headers/meta-tags.
If they already are, give a 404 or a 410 when the page number requested exceeds the number-of-pages value you have in your controller, this would require a small alteration though.

JNeuhoff wrote: ↑

Thu Sep 02, 2021 4:48 pm

Try something like this in your robots.txt:

by mona wrote: ↑

Thu Sep 02, 2021 5:21 pm

Best way is to use meta tags or x-robot headers or both for these because then you can set them to noindex, follow.

                if (isset($this->request->get['limit'])) {
                        $limit = $this->request->get['limit'];
                        if( (!is_numeric($limit)) || (floor($limit) != $limit) ){
                                $this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
                        }

head_dunce wrote: ↑

Thu Sep 02, 2021 6:55 pm

by mona wrote: ↑

Thu Sep 02, 2021 5:21 pm

Best way is to use meta tags or x-robot headers or both for these because then you can set them to noindex, follow.

Ah, interesting approach! This looks like a good idea!

I was just looking at the /catalog/controller/product/category.php
And made a quick change to test. I'd have to do this for all the available parameters, but I like your idea better.

Code: Select all

                if (isset($this->request->get['limit'])) {
                        $limit = $this->request->get['limit'];
                        if( (!is_numeric($limit)) || (floor($limit) != $limit) ){
                                $this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
                        }

$limit = $this->request->get['limit'];

$limit = (int)$this->request->get['limit'];

head_dunce wrote: ↑

Thu Sep 02, 2021 6:55 pm

by mona wrote: ↑

Thu Sep 02, 2021 5:21 pm

Best way is to use meta tags or x-robot headers or both for these because then you can set them to noindex, follow.

Ah, interesting approach! This looks like a good idea!

I was just looking at the /catalog/controller/product/category.php
And made a quick change to test. I'd have to do this for all the available parameters, but I like your idea better.

Code: Select all

                if (isset($this->request->get['limit'])) {
                        $limit = $this->request->get['limit'];
                        if( (!is_numeric($limit)) || (floor($limit) != $limit) ){
                                $this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
                        }

$results = $this->model_catalog_product->getProducts($filter_data);

 if (!$results && (int)$page != 1) {
	$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
}

straightlight wrote: ↑

Thu Sep 02, 2021 7:32 pm

Code: Select all

$limit = $this->request->get['limit'];

for:

Code: Select all

$limit = (int)$this->request->get['limit'];

ADD Creative wrote: ↑

Thu Sep 02, 2021 8:28 pm

Check your pages have the correct canonical links and that you have correctly configured the URL Parameters for your site in Google's Search console. The canonical links should take care on any duplicates caused by URL parameters other than page. Be careful of adding noindex (and possibly 404) to pages that have a canonical link to a page you need to be indexed. It's something Google warn against doing. https://developers.google.com/search/do ... age%20when

ADD Creative wrote: ↑

Thu Sep 02, 2021 8:28 pm

For the original page issue. You could try. After.

Code: Select all

$results = $this->model_catalog_product->getProducts($filter_data);

Add.

Code: Select all

 if (!$results && (int)$page != 1) {
	$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
}

But again this could cause issues if the limit is set. For example category?page=2&limit=100 would return no products and a 404, but the canonical link to category?page=2 would be valid and require indexing.

 if (!$results && (int)$page != 1) {
	$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
}

head_dunce wrote: ↑

Thu Sep 02, 2021 11:16 pm

straightlight wrote: ↑

Thu Sep 02, 2021 7:32 pm

Code: Select all

$limit = $this->request->get['limit'];

for:

Code: Select all

$limit = (int)$this->request->get['limit'];

Actually that's a problem, and that's how the original OC source code has it. If what's supplied is not a number, (int) will return zero.
By using (!is_numeric($limit)) || (floor($limit) != $limit) you're able to check if it is a number and if it is an integer. If what was supplied was anything else, it should just give a 404 since whatever was given was not supplied by OC. As noted above, I am showing links in Google Search Console with "limit=" being random strings. No idea how or why Google found those pages, but OC shouldn't be allowing them anyway.

straightlight wrote: ↑

Fri Sep 03, 2021 12:06 am

May cause an undefined variable error message in the error triggers if it's not sanitized, that's why.

head_dunce wrote: ↑

Fri Sep 03, 2021 12:15 am

straightlight wrote: ↑

Fri Sep 03, 2021 12:06 am

May cause an undefined variable error message in the error triggers if it's not sanitized, that's why.

Yeah, but if it's not a positive integer then OC should return the 404 or do something else besides generating the page as if all is well. You can sanitize it after it's checked to avoid the php error if you'd like.

straightlight wrote: ↑

Fri Sep 03, 2021 1:18 am

Cinderella request. Browsers requires that the variable gets sanitized before the load completes, not after.

                if (isset($this->request->get['limit'])) {
                        $limit = $this->request->get['limit'];
                        if( (!is_numeric($limit)) || (floor($limit) != $limit) || ($limit < 1) ){
                                $this->response->redirect($this->url->link('error/not_found'));
                        }

ADD Creative wrote: ↑

Thu Sep 02, 2021 8:28 pm

For the original page issue. You could try. After.

Code: Select all

$results = $this->model_catalog_product->getProducts($filter_data);

Add.

Code: Select all

 if (!$results && (int)$page != 1) {
	$this->response->addHeader($this->request->server['SERVER_PROTOCOL'] . ' 404 Not Found');
}

But again this could cause issues if the limit is set. For example category?page=2&limit=100 would return no products and a 404, but the canonical link to category?page=2 would be valid and require indexing.

 if (!$results && (int)$page != 1) {
	$this->response->redirect($this->url->link('error/not_found'));
}