OCMOD question

I'm playing with some code to see if I understand the ins and outs of OCMOD, and came to an unexpected result.

Does ADD AFTER inserts the text right after the match, or in the next line?

Here are the details of my test:

order_list.twig has a line: My OCMOD xml says:
The goal is to show the currency code after the order total, but before the '</td>' closes the table cell.

But after applying the modification, the cache shows: So the 2nd variable was inserted as a new line, after the end of the line that contained the match, after the '</td>' even when the search string didn't contain '</td>'.

Is this how it is supposed to work, or am I doing something wrong?

Thanks

Hi

Try this:

Basically your code looks okay, maybe read this here: https://github.com/opencart/opencart/wi ... ion-System
If you use

<add position="after">

it is to supposed to add the line/code) directly after the searched item/code.
You can use also a new line in the section to add it in the next line,
Using trim (see Wiki) allows more.

But before you go ahead, forget all about OCMod and VQMod and similiar!
Better to work with Events, see: https://github.com/opencart/opencart/wiki/Events-System
and forum posting here:
viewtopic.php?f=144&t=221533

Why not OCMod anymore?
Events were introduced with OpenCart 2.3.x, extended with OpenCart 3.x and will be used only in OpenCart 4.x
Everything which is (and was) available in the past with VQ- & OCMods are also possible with Events.

OSWorX wrote: ↑

Wed Jun 02, 2021 2:43 pm

Everything which is (and was) available in the past with VQ- & OCMods are also possible with Events.

Total rubbish, what on Earth made you think that?

You can add events before and after methods but can you modify, remove, or add to code inside a method?

OC event system is super weak even in its latest state comparing to WP hooks and actions. Removing OCMod is quite bad idea, we'll just revert back to VQMod or somebody will create an OCMOd extension for OC 4.

paulfeakins wrote: ↑

Wed Jun 02, 2021 6:51 pm

OSWorX wrote: ↑

Wed Jun 02, 2021 2:43 pm

Everything which is (and was) available in the past with VQ- & OCMods are also possible with Events.

Total rubbish, what on Earth made you think that?

You can add events before and after methods but can you modify, remove, or add to code inside a method?

Guess you have not understood how events are working?
Simply override the method.
Practising this in a few extensions of me and works perfectly.

OSWorX wrote: ↑

Wed Jun 02, 2021 8:24 pm

Guess you have not understood how events are working?
Simply override the method.
Practising this in a few extensions of me and works perfectly.

So you're saying that to change a particular function a bit, to add a couple lines of code I will have to copy the function completely and then add these couple lines of code to the copy?

OSWorX wrote: ↑

Wed Jun 02, 2021 2:43 pm

it is to supposed to add the line/code) directly after the searched item/code.

In my case it doesn't do that exactly. It adds the code after the end of the line that contained the searched code.

That had me confused.

Thanks

DigitCart wrote: ↑

Wed Jun 02, 2021 2:30 pm

Try this:

This works.
Thanks!

cartuser9 wrote: ↑

Wed Jun 02, 2021 10:05 pm

OSWorX wrote: ↑

Wed Jun 02, 2021 2:43 pm

it is to supposed to add the line/code) directly after the searched item/code.

In my case it doesn't do that exactly. It adds the code after the end of the line that contained the searched code.

That had me confused.

Thanks

Which simply means you could use a /after event instead of a /before event. In addition, you could even call another modulated controller to use the rest of the code without the need to reproduce the entire function. An e.g to take a look into, as suggested many times on the forum, is the lookup into the catalog/controller/extension/analytics folder and look at the controllers that launches the events.

it is to supposed to add the line/code) directly after the searched item/code.

Wrong. When using OCmod the code is added after the line containing the search expression.
To add code right after the search expression, use the replace as explained above.

Thanks all.

Just for completion, the full code of my first mod ever, to show the currency in the orders table, would be:

OSWorX wrote: ↑

Wed Jun 02, 2021 8:24 pm

Simply override the method.

So 2 extensions cannot modify different lines of the same method?

JNeuhoff wrote: ↑

Wed Jun 02, 2021 10:13 pm

it is to supposed to add the line/code) directly after the searched item/code.

Wrong. When using OCmod the code is added after the line containing the search expression.
To add code right after the search expression, use the replace as explained above.

It depends also on the written code.
Writing:

<search><![CDATA[{{ order.total }}</td>]]></search>
<add position="after"><![CDATA[ {{ order.currency_code }}]]></add>

will add it directly after.
Instead writing:

<search><![CDATA[{{ order.total }}]]></search>
<add position="after"><![CDATA[
{{ order.currency_code }}
]]></add>

will add it next line.

Additonally the trim parameter (default = false) can be used.

Using replace will replace the searched code - also here depends how the replacement is defined.

Should I be wrong, no problem in learning ..

paulfeakins wrote: ↑

Thu Jun 03, 2021 7:50 pm

OSWorX wrote: ↑

Wed Jun 02, 2021 8:24 pm

Simply override the method.

So 2 extensions cannot modify different lines of the same method?

Why asking me?
You are the developer ..

OSWorX wrote: ↑

Fri Jun 04, 2021 5:55 pm

JNeuhoff wrote: ↑

Wed Jun 02, 2021 10:13 pm

it is to supposed to add the line/code) directly after the searched item/code.

Wrong. When using OCmod the code is added after the line containing the search expression.
To add code right after the search expression, use the replace as explained above.

It depends also on the written code.
Writing:

<search><![CDATA[{{ order.total }}</td>]]></search>
<add position="after"><![CDATA[ {{ order.currency_code }}]]></add>

will add it directly after.
Instead writing:

<search><![CDATA[{{ order.total }}]]></search>
<add position="after"><![CDATA[
{{ order.currency_code }}
]]></add>

will add it next line.

Additonally the trim parameter (default = false) can be used.

Using replace will replace the searched code - also here depends how the replacement is defined.

Should I be wrong, no problem in learning ..

OK, I stand corrected here,

OSWorX wrote: ↑

Fri Jun 04, 2021 5:56 pm

Why asking me?
You are the developer ..

Well your signature says "Full Stack Web Developer" ...

But if you're not a developer why are you making untrue statements like this?:

OSWorX wrote: ↑

Wed Jun 02, 2021 2:43 pm

Everything which is (and was) available in the past with VQ- & OCMods are also possible with Events.

The answer is NO events cannot do anything that vQmod and OCMOD can do.