Confirmed. Fixed.xxvirusxx wrote: ↑Mon Jun 01, 2020 6:56 pmCheck again both coupon files: from Marketing.
In controller is this:
when should be :getHistoriesCode: Select all
$history_total = $this->model_marketing_coupon->getCouponHistories
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Remove empty folder GoogleShopping from system/config
<< removed >>
Same wrong function _destroy in system/library/session
<< removed >>
Same wrong function _destroy in system/library/session
Last edited by straightlight on Mon Jun 01, 2020 7:13 pm, edited 1 time in total.
Reason: Removed the proposed links. Not relative to the core.
Reason: Removed the proposed links. Not relative to the core.
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Both fixed.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, package updated. I have also added the EST time with it in the releases logs. Change log updated accordingly.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
You have restored again..in database 
(10, 'activity_affiliate_add', 'catalog/model/account/affiliate/
This path doesn't exist
(10, 'activity_affiliate_add', 'catalog/model/account/affiliate/
This path doesn't exist
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Fixed.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Fixed upgrade 1009.php for account/customer path as well. Package re-uploaded.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
I don't understand how you work
mysql is there
LE. is the step_2 twig...
mysql is there
Code: Select all
$db = array(
'mysql',
'mysqli',
'pdo',
'pgsql'
);Code: Select all
<td>5.4+</td>
<td class="text-center">{% if php_version >= '5.4' %}Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Like I said, it's because of your login workaround with characters suggestion you posted earlier. I had to reverse the process and still some left overs. Please ensure to provide accurate commits, either, assigned or referenced by an OC admin. Even the merged ones can be inaccurate at times.xxvirusxx wrote: ↑Mon Jun 01, 2020 7:54 pmI don't understand how you work
mysql is thereIn language need to be changed to php 7Code: Select all
$db = array( 'mysql', 'mysqli', 'pdo', 'pgsql' );Code: Select all
$_['error_version'] = 'Warning: You need to use PHP 5.4 or above for OpenCart to work!';
As for the $_['error_version'], this is what I have and should already be in the latest package:
Code: Select all
$_['error_version'] = 'Warning: You need to use PHP 7.1 or above for OpenCart to work!';
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok, package re-updated by cleaning the mysql libraries from the install and fixing an affliate term to read affiliate.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Reinstall again to see if this error still show when login to admin
Code: Select all
2020-06-01 12:05:16 - PHP Warning: mysqli::query(): Couldn't fetch mysqli in /system/library/db/mysqli.php on line 23
2020-06-01 12:05:16 - PHP Warning: DB\MySQLi::query(): Couldn't fetch mysqli in /system/library/db/mysqli.php on line 25
2020-06-01 12:05:16 - PHP Warning: mysqli::real_escape_string(): Couldn't fetch mysqli in /system/library/db/mysqli.php on line 50
2020-06-01 12:05:16 - PHP Warning: mysqli::query(): Couldn't fetch mysqli in /system/library/db/mysqli.php on line 23
2020-06-01 12:05:16 - PHP Warning: DB\MySQLi::query(): Couldn't fetch mysqli in /system/library/db/mysqli.php on line 25Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
That is because of the __destruct() . Rename it back to __destroy() and see if the error persists.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
No errors if you change __destruct to destroy
- Mysqli connection not closed
https://github.com/opencart/opencart/co ... a98a56e621
- Mysqli connection not closed
https://github.com/opencart/opencart/co ... a98a56e621
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Ok, this is a major issue. Will add it now and update my reply with the new package.xxvirusxx wrote: ↑Mon Jun 01, 2020 8:22 pmNo errors if you change __destruct to destroy
- Mysqli connection not closed
https://github.com/opencart/opencart/co ... a98a56e621
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
So you are not committing the changes to GitHub!straightlight wrote: ↑Mon Jun 01, 2020 5:36 amSame place as it has always been announced for new releases: viewtopic.php?f=2&p=788947#p788947 - news & announcements section.
Also why have you renamed some of the methods, just so the match the master branch? Will this likely break any extension or modification that hook on to these? If so you need to follow your own versioning guidance in https://github.com/opencart/opencart/bl ... /README.md
Package re-uploaded with provided solution. Change log posted accordingly.straightlight wrote: ↑Mon Jun 01, 2020 8:25 pmOk, this is a major issue. Will add it now and update my reply with the new package.xxvirusxx wrote: ↑Mon Jun 01, 2020 8:22 pmNo errors if you change __destruct to destroy
- Mysqli connection not closed
https://github.com/opencart/opencart/co ... a98a56e621
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
I am committing the changes directly into the releases. As for the extensions, since this is a pre-release and not official, the goal is to catch up most of the codes with the master branch in the future. We're not there yet but slowly evolving to that direction. Right now, as I said, focusing on major incidents. Then, working on features.ADD Creative wrote: ↑Mon Jun 01, 2020 8:29 pmSo you are not committing the changes to GitHub!straightlight wrote: ↑Mon Jun 01, 2020 5:36 amSame place as it has always been announced for new releases: viewtopic.php?f=2&p=788947#p788947 - news & announcements section.
Also why have you renamed some of the methods, just so the match the master branch? Will this likely break any extension or modification that hook on to these? If so you need to follow your own versioning guidance in https://github.com/opencart/opencart/bl ... /README.md
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
@xxvirusxx: Is the database working now since the last suggestion of your last submitted commit?
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Ok. No updates since the last package revision so I presume everything is working as it should now. I'll start working on small features to keep things growing slowly so for everyone to keep on-track with the changes. Releases will be released less frequently unless there are still overlooked major incident situations.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
You didn't changed in session from_destruct to destroy.
Same issue
Same issue
Upgrade Service | OC 2.3.0.2 PHP 8 | My Custom OC 3.0.3.8 | Buy me a beer
Who is online
Users browsing this forum: No registered users and 7 guests
