Ok well then why don't you take your complaint to Daniel or do a pull request
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Also, should the UTF-8 be in quotes in the .htaccess? in the php.ini, it is not.
Billy, you have code that has UTF-8 (in capitals) in the extension, are you saying that that should be lowercase? BTW, none of these (utf-8 lowercase updates) changes have fixed cc_offline, still need to test PayPal.
Nowhere in the Opencart base has that declaration ever existed. I'm not sure how it made it's way in to your installation but you can verify what I'm saying by browsing the releases on github. In theory, the case shouldn't matter but the semi-colon might and there could very well be something else overriding your settings. Also, different web servers may interpret this directive differently and depends on PHP module. I've emailed you and we can talk tomorrow to get this straightened out. Cheers.
Issue still present in latest 3.x github repo.straightlight wrote: ↑Sun Feb 04, 2018 1:04 amIn catalog/controller/extension/payment/pp_standard.php file,
find:
replace:Code: Select all
'name' => htmlspecialchars($product['name']), 'model' => htmlspecialchars($product['model']),
Code: Select all
'name' => html_entity_decode($product['name'], ENT_QUOTES, 'UTF-8'), 'model' => html_entity_decode($product['model'], ENT_QUOTES, 'UTF-8'),
Note: I don't report issues on github anymore. Seen too many "you're an idiot" comments toward others and "this is not a bug" comments by "you-know-who" before closing legitimate bug reports. I just fix them in my own core-fix ocmod(s) for internal/client use
--------------------------------------------------
My Blog ↔ My Extensions ↔ OpenCart Templates
While you indicate the issue is still present on Github, and the user above on this topic did indicated the issue was resolved after the provided solution, did you tried the provided solution above? If so, what were the results?Issue still present in latest 3.x github repo.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Upon finding a solution on page one, did not continue to page 2 (topic seemed to derail thereafter). I checked my htaccess, and while it does not contain the directive, unexpectedly cPanel-generated INI files did. The "default_charset" problem (see below) can be reintroduced by a server manager (WHM) or domain admin (cPanel) using the "MultiPHP INI Editor" in "Basic Mode" without a site owner's knowledge. Explicit flags and encoding in the core should help avoid that.straightlight wrote: ↑Tue Apr 10, 2018 7:53 amWhile you indicate the issue is still present on Github, and the user above on this topic did indicated the issue was resolved after the provided solution, did you tried the provided solution above? If so, what were the results?
Code: Select all
; cPanel-generated php ini directives, do not edit
; Manual editing of this file may result in unexpected behavior.
; To make changes to this file, use the cPanel MultiPHP INI Editor (Home >> Software >> MultiPHP INI Editor)
; For more information, read our documentation (https://go.cpanel.net/EA4ModifyINI)
[PHP]
default_charset = "UTF-8;"
memory_limit = 128M
max_execution_time = 30
post_max_size = 8M
upload_max_filesize = 2M
mysql.connect_timeout = 20
session.auto_start = Off
session.use_only_cookies = On
session.use_cookies = On
session.use_trans_sid = Off
session.cookie_httponly = "On;"
session.gc_maxlifetime = 1440
;display_errors = 1;
;error_reporting = E_ALL;
display_errors = Off
max_input_time = 60
max_input_vars = 1000
session.save_path = "/var/cpanel/php/sessions/ea-php70"
zlib.output_compression = Off
--------------------------------------------------
My Blog ↔ My Extensions ↔ OpenCart Templates
Maybe if the setting was validated at 'install/step_3' it would avoid others reporting the same problem
--------------------------------------------------
My Blog ↔ My Extensions ↔ OpenCart Templates
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Just did a search for the same error and found this thread. The above is actually wrong. The correct code should be.straightlight wrote: ↑Sun Feb 04, 2018 1:04 amQuite unusual to use the htmlspecialchars for an API regarding PayPal for output purposes.
In catalog/controller/extension/payment/pp_standard.php file,
find:
replace with:Code: Select all
'name' => htmlspecialchars($product['name']), 'model' => htmlspecialchars($product['model']),
This should rectify the issue.Code: Select all
'name' => html_entity_decode($product['name'], ENT_QUOTES, 'UTF-8'), 'model' => html_entity_decode($product['model'], ENT_QUOTES, 'UTF-8'),
Code: Select all
'name' => $product['name'],
'model' => $product['model'],
The actual root cause of the problem is with this line in the php.ini. https://github.com/opencart/opencart/bl ... php.ini#L3 It should not have the semicolon on the end. It will not affect most setups, but can be a problem in some. One example is with the cPanel and it's MultiPHP INI Editor. It will interpret that value including the semicolon, outputting to the the following to .htaccess.
Code: Select all
php_value default_charset "UTF-8;"
Code: Select all
php_value default_charset "UTF-8"
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Regarding the UTF-8. That was the whole problem, line 3 of in https://github.com/opencart/opencart/bl ... php.ini#L3 should NOT have the semicolon on the end.
Thanks for elaborating the root cause for those who do encounter this issue as compared to others.Regarding the UTF-8. That was the whole problem, line 3 of in https://github.com/opencart/opencart/bl ... php.ini#L3 should NOT have the semicolon on the end.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Users browsing this forum: No registered users and 141 guests