Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text, Text,
Last edited by bottomthumper on Mon Nov 03, 2008 5:47 am, edited 1 time in total.
bottomthumper
The idea is nice, and I agree with the readme that it would be best put into the locator or layout.. but I personally don't really understand the implementation.
I see that I have to add some code to the tpl file, and then I have to create an includes/runtime file.
- Opencart doesn't have an "includes" folder
- This seems like it is just doing a php "includes" on all files matching the name.
Also I see in the classes/ocart_rci.php file there are lots of references to code like if filename == "stylesheet"
- OpenCart doesn't use the name "stylesheet" for any of its sheets. That should probably be if fileextension == "css" or something.
I kinda get that it includes all files in the "includes/runtime" folder so you don't need to type include more than once and can just edit the includes file for new stuff on the page. But while the idea is sound, the implementation seems a bit static and hardcoded. I might have some ideas on making it a bit less static and more robust in that the files could reside with a base-naming structure, so it can dynamically load all files matching the base name of the controller. This way multiple include files could be added from multiple contribs. This falls in line with some of the override ideas I had for phase 2 of the override system.
Still, nice to see more contribs coming to OpenCart. Nice work!
I see that I have to add some code to the tpl file, and then I have to create an includes/runtime file.
- Opencart doesn't have an "includes" folder
- This seems like it is just doing a php "includes" on all files matching the name.
Also I see in the classes/ocart_rci.php file there are lots of references to code like if filename == "stylesheet"
- OpenCart doesn't use the name "stylesheet" for any of its sheets. That should probably be if fileextension == "css" or something.
I kinda get that it includes all files in the "includes/runtime" folder so you don't need to type include more than once and can just edit the includes file for new stuff on the page. But while the idea is sound, the implementation seems a bit static and hardcoded. I might have some ideas on making it a bit less static and more robust in that the files could reside with a base-naming structure, so it can dynamically load all files matching the base name of the controller. This way multiple include files could be added from multiple contribs. This falls in line with some of the override ideas I had for phase 2 of the override system.
Still, nice to see more contribs coming to OpenCart. Nice work!
Last edited by Qphoria on Mon Sep 08, 2008 9:29 pm, edited 1 time in total.
Who is online
Users browsing this forum: No registered users and 3 guests
