2.2.0.0 Upgrade Script Improvements by Qphoria - TEST PLEASE

daniel2008 wrote:

pm-netti wrote: There is read: "Default Items Per Page (Admin)"
You save settings, please.

Hi pm-netti,

I've finally found Default Items Per Page under Option after clicking the edit of the store.
However I can't change anything there as the only error coming from the set of Encryption Key.
I don't know how to set Encryption Key. I tried to unable SSL but still need Encryption Key!

Please give me some hints for that. Thanks,

Daniel

See the error below,

error.jpg

daniel2008 wrote:the last question?

pm-netti wrote: Other issue: vqmod cache also do issues after upgrade.

pm-netti wrote:In current 1006.php line 24 is not work in OC version 2.0.3.1:

Code: Select all

if (strpos(strtoupper($line), 'DB_PORT') !== false) {

if (strpos(strtoupper($line), 'DB_PORT') !== false && is_dir(DIR_MODIFICATION)) {

Qphoria wrote:

pm-netti wrote:In current 1006.php line 24 is not work in OC version 2.0.3.1:

Code: Select all

if (strpos(strtoupper($line), 'DB_PORT') !== false) {

fixed.. thx, but your dir_modification/system thing still doesn't make a lot of sense.
It won't matter if DIR_MODIFICATION/system exists because I'm going to be deleting it.
Simply using

Code: Select all

if (strpos(strtoupper($line), 'DB_PORT') !== false && is_dir(DIR_MODIFICATION)) {

should be sufficient.

pm-netti wrote: This is always false, also versions 1.5.x?
Directory DIR_MODIFICATION (system/storage/modification) is found always, beacuse it is version 2.2 folder.

Qphoria wrote:

pm-netti wrote: This is always false, also versions 1.5.x?
Directory DIR_MODIFICATION (system/storage/modification) is found always, beacuse it is version 2.2 folder.

Ah ok I see what you mean. In any case, that really only affects adding the "/storage/" part to the config file which was a bad place for that. I've moved it to its own section now.

			$upgrade = true;

				$lines = file($file);

				foreach ($lines as $line) {
					if (strpos(strtoupper($line), 'DB_PORT') !== false && is_dir(DIR_MODIFICATION)) {
						$upgrade = false;

						break;
					}
				}

pm-netti wrote:

Qphoria wrote:

pm-netti wrote: This is always false, also versions 1.5.x?
Directory DIR_MODIFICATION (system/storage/modification) is found always, beacuse it is version 2.2 folder.

Ah ok I see what you mean. In any case, that really only affects adding the "/storage/" part to the config file which was a bad place for that. I've moved it to its own section now.

All foreach:

Code: Select all

			$upgrade = true;

				$lines = file($file);

				foreach ($lines as $line) {
					if (strpos(strtoupper($line), 'DB_PORT') !== false && is_dir(DIR_MODIFICATION)) {
						$upgrade = false;

						break;
					}
				}

If I use version 1.5.6.4 and upload version 2.2 files, that variable "upgrade" is false, it is not change config.php files. Are you checked this some other?

$output = str_replace('system/modification', 'system/storage/modification', $output);
$output = str_replace('system/upload', 'system/storage/upload', $output);
$output = str_replace('system/logs', 'system/storage/logs', $output);
$output = str_replace('system/cache', 'system/storage/cache', $output);

Qphoria wrote:But upgrade will be true if DB_PORT doesn't exist.

is_dir(DIR_MODIFICATION . 'system')

dmsims wrote:Q - When will v7 go into the core?

People are still coming on here (virtually every day) with a failed upgrade