How do I re-open an Issue in OC GitHub?

hendrachristian wrote:I posted the following few days ago
https://github.com/opencart/opencart/issues/4102
Daniel did a commit and thought he fixed the issue and close the thread.
I have since added some comments regarding the issue because it's not yet fixed.

How do I re-open that thread? Or should I submit a new issue?

budgetneon wrote:

hendrachristian wrote:I posted the following few days ago
https://github.com/opencart/opencart/issues/4102
Daniel did a commit and thought he fixed the issue and close the thread.
I have since added some comments regarding the issue because it's not yet fixed.

How do I re-open that thread? Or should I submit a new issue?

He made another commit yesterday: https://github.com/opencart/opencart/co ... 3e696f38fc

I would download the latest and create a new issue if the problem still exists. Daniel's not likely watching closed issues.

hendrachristian wrote:couldn't wait so I tested the fixes in latest branch and it works now as expected.

I do find another issue w/ Admin > System > Localisation > Language though. The screen is different from the docs http://docs.opencart.com/system/localisation/language/ and adding a Language is now more cumbersome because have to INSERT directly from DB. (No way to add Code, Directory, Image in this version from the Admin area)

 <img src="catalog/language/<?php echo $language['code']; ?>/<?php echo $language['code']; ?>.png" alt="<?php echo $language['name']; ?>" title="<?php echo $language['name']; ?>">
    <?php } ?>

budgetneon wrote: I think that may be on purpose. Since the directories are supposed to be like "en-gb" now instead of "english", the assumption is that the image will be "en-gb.png".

See here, for example: https://github.com/opencart/opencart/bl ... age.tpl#L8

Code: Select all

 <img src="catalog/language/<?php echo $language['code']; ?>/<?php echo $language['code']; ?>.png" alt="<?php echo $language['name']; ?>" title="<?php echo $language['name']; ?>">
 <?php } ?>

It looks like the intention is that people creating language packs will follow a more rigid naming process, which eliminates the need for the other fields. Code is driven by the directory name, as is image, etc.