Cache bug

Hi community,

ive just found that the cache is unable to produce the results in right orders. This is because of the caching of items are not ordering the results by using the sort_order column settings.

for example

in the library/language/language.php just produces the cache without using the sort_order rule.

replace the above sentence with the following: By replacing the line, you'll get the language sorted on everywhere, for example you can edit the product description by using the 0. sort ordered language (thats hungarian for me). If your shopping cart have other languages than english, this is a very useful modding, but doesnt causes any problem if you are use only 1 language.

You can done this cache modding on other modules also.

regards,
damoks


ps: please note that you have to delete the appropriate cache file that contains the old cache mirror after you made the changes. for example, delete the file cache.language.*.

I have found an another cache bug while using it on multilingual shops.

Some of the objects are produces the cache by patching its name with a language_id. Like this: cache.weight_class-2.1206608816
The -2 stands for the extra language id. Thats cool, but if you modify the cached table (like updating any value in the admin place) it cant delete the extra patched cache, but deletes only the standard named one.

To handle this problem, you have to place an additional asterix to the file name, to delete every language specific cache for the modified tables.

in library/cache/cache.php, at function delete()

foreach (glob(DIR_CACHE . 'cache.' . $key . '.*') as $file) {

This may looks ok, but unfortunately most of the objects has forgot to implement the language id to the $key while calling a cache deleting. So this one is generates the filename like this: cache.weight_class.* (but this file is not exists, because we use the engine in multilingual mode)

For the good result, use the above:

foreach (glob(DIR_CACHE . 'cache.' . $key . '*.*') as $file) {

It patches the filename, so it will look like this. cache.weight_class*.*
With this patch you can eliminate every language specific cache. But why not? If you modify anything, the shop have to recache the new values. It doesnt matter that you modified only the english or any other language based setting. The information must be refreshed!

thanks

thanks a lot for your work

thank you! it works!