OpenCart 1.5.3 Bug Thread

Qphoria wrote:

ruspect wrote:Have you guys fixed in 1.5.3 an issue with Canadian currency, I mean ISO CAD-CDN codding for paypal?
Thx

No such issue. Be sure you use "CAD" for currencies. Paypal already uses CAD as does the rest of the world

Qphoria wrote:

slingeraap wrote:When setting Company ID and Tax ID in the shop settings to 'Not required', during checkout (first step) both display an asterik as if they are required.

I think this only happens if you don't check a default group for registration in the System->Settings under the Options tab under the "Accounts" area for "Customer Groups:"

garydee77 wrote: If I choose Guest checkout, on step 2 I fill out all details and then the following error pops up:

Code: Select all

SyntaxError: JSON.parse: unexpected character
OK
<b>Notice</b>: Undefined index:  company_id in <b>/home/users/xxxxx/html/xxxxx.co.uk/catalog/controller/checkout/guest.php</b> on line <b>269</b><b>Notice</b>: Undefined index:  tax_id in <b>/home/users/xxxxx/html/xxxxx.co.uk/catalog/controller/checkout/guest.php</b> on line <b>270</b>[]

public function validate() {

if (!isset($this->request->post['tax_id'])) { $this->request->post['tax_id'] = false; }
if (!isset($this->request->post['company_id'])) { $this->request->post['company_id'] = false; }

dennykb-d wrote:Hi, ive just installed the latest opencart v1.5.3.1 with the dutch language pack
and i found this bug:
If i set the store settings language in dutch then there are no customers showing up.
when i set it in english then they are showing up.

If already compared the sale/customer.php language file but these are correct

i2Paq wrote:

dennykb-d wrote:Hi, ive just installed the latest opencart v1.5.3.1 with the dutch language pack
and i found this bug:
If i set the store settings language in dutch then there are no customers showing up.
when i set it in english then they are showing up.

If already compared the sale/customer.php language file but these are correct

You are the first to "see" this!

I'm pretty sure that you did something wrong.

En ik spreek uit zeer veel ervaring

Qphoria wrote:

garydee77 wrote: If I choose Guest checkout, on step 2 I fill out all details and then the following error pops up:

Code: Select all

SyntaxError: JSON.parse: unexpected character
OK
<b>Notice</b>: Undefined index:  company_id in <b>/home/users/xxxxx/html/xxxxx.co.uk/catalog/controller/checkout/guest.php</b> on line <b>269</b><b>Notice</b>: Undefined index:  tax_id in <b>/home/users/xxxxx/html/xxxxx.co.uk/catalog/controller/checkout/guest.php</b> on line <b>270</b>[]

If your getting that error, it is related to your theme not supporting the new company_id and tax_id fields.
For now you can try this for a temporary solution

1. EDIT 3 FILES:
catalog/controller/checkout/guest.php
catalog/controller/checkout/register.php
catalog/controller/account/register.php

2. FIND IN ALL 3:

Code: Select all

public function validate() {

3. AFTER, ADD (IN ALL 3):

Code: Select all

if (!isset($this->request->post['tax_id'])) { $this->request->post['tax_id'] = false; }
if (!isset($this->request->post['company_id'])) { $this->request->post['company_id'] = false; }

public function validate() {

mclaughlin wrote: I noticed that for Greek companies the VAT check system doesn't work correctly.

i2Paq wrote:

mclaughlin wrote: I noticed that for Greek companies the VAT check system doesn't work correctly.

This we all know!

The Greeks do not pay any takes and thats why they are in trouble now.

Qphoria wrote:OpenCart doesn't come with CDN pre-installed
You entered that yourself when you added that currency. But CDN is fake and non-official. A guess I would assume as to what your own currency code is, but an incorrect guess. Also see a lot of people incorrectly guess "CAN". Change it to "CAD" as that is the international Standard that all currency conversions and payment gateways use. When changing to CAD you might start seeing errors from older orders that can no longer convert so you may also need to run this command in phpmyadmin:

Code: Select all

update `order` set currency_code = 'CAD' where currency_code = 'CDN';

jurpro wrote:Hallo... I'm using OC 1.5.3.1 version with default currancy is IDR. The problem is when I was using OC 1.5.3 the currancies is fine with update daily. But in 1.5.3.1 the currancies become error for others except USD.
example:
IDR (default) = 1.000000
USD = 0.000105932
EUR = 0.0000837769

But the next day the currancies become :
IDR (default) = 1.000000
USD = 0.00010000
EUR = 0.0001000
All the same become flat rate to 0.0001

But if I'm using USD, the currancies will be fine for another next days.
Anyone could help??
Thank you

mclaughlin wrote:Hi guys, this is my first contribution to the opencart community.

I noticed that for Greek companies the VAT check system doesn't work correctly. This happens because the system/helper/vat.php file on line 38 inappropriately uses the array_search function which searches for the array values, not keys. Greece is the only country that uses different prefixes for VAT numbers and opencart language so the problem came to be for Greece only at the time.

So a simple fix is this:

1. Edit file:
system/helper/vat.php

2. Change lines 38-39 to:

Code: Select all

if (array_key_exists($prefix, $iso_code_2_data)) {
		$response = file_get_contents('http://ec.europa.eu/taxation_customs/vies/viesquer.do?ms=' . $iso_code_2_data[$prefix] . '&iso=' . $iso_code_2_data[$prefix] . '&vat=' . $number);
		

If you want you can also remove whitespace from the vat number which breaks checking (cases like 'GB 32323232') and always allows the registration:

Change line 35 to:

Code: Select all

$number = str_replace(' ','',substr($number, 2));

You can also remove dashes if you think someone mistakenly would use a "GB-32323232" format.