OpenCart 1.5.1.3 Released

JNeuhoff wrote:

Qphoria wrote: dunno.. just shootin out ideas.

Perhaps implement the old Tax::getRate($tax_class_id) in a VQmod XML file and let it call in turn the new methods? This way there might be no need to change all the addons, have to look into it. Certainly my Google Checkout module is broken now in 1.5.1.3 because of the changes with the tax.

Qphoria wrote:Patch Only Version:
I've compiled a zip of only the changed files, for those that want to limit the upgrade to only the changed or new files.
Only use this zip if you have an existing 1.5.1.x version

patch_151x_to_1513-v2.zip

ATTN DEVELOPERS:
There were some API impacts in this version...

1. New Tax System
The new tax system removes the old "Tax::getRate()" function from the system/library/tax.php file
This means any calls to "$this->tax->getRate()" will need to be replaced.

To show a coding example:
1.5.1.1:

Code: Select all

if ($this->session->data['shipping_method']['tax_class_id']) {
    if (!isset($taxes[$this->session->data['shipping_method']['tax_class_id']])) {
        $taxes[$this->session->data['shipping_method']['tax_class_id']] = $this->session->data['shipping_method']['cost'] / 100 * $this->tax->getRate($this->session->data['shipping_method']['tax_class_id']);
    } else {
        $taxes[$this->session->data['shipping_method']['tax_class_id']] += $this->session->data['shipping_method']['cost'] / 100 * $this->tax->getRate($this->session->data['shipping_method']['tax_class_id']);
    }
} 

Would be replaced with:

Code: Select all

if ($this->session->data['shipping_method']['tax_class_id']) {
    $tax_rates = $this->tax->getRates($this->session->data['shipping_method']['cost'], $this->session->data['shipping_method']['tax_class_id']);
    
    foreach ($tax_rates as $tax_rate) {
        if (!isset($taxes[$tax_rate['tax_rate_id']])) {
            $taxes[$tax_rate['tax_rate_id']] =  $tax_rate['amount'];
        } else {
            $taxes[$tax_rate['tax_rate_id']] +=  $tax_rate['amount'];
        }
    }
} 

Since this was done in a point release (unfortunately ), I recommend using a conditional to make it support both 1.5.1.1 and 1.5.1.3 in one file to save yourself from having to maintain 2 versions.
For this I use

Code: Select all

if (method_exists($this->tax, 'getRates')) { //v1.5.1.3 or later
   // Put the new method here
} else {
   // Put the old method here
} 

Take a look at the changes in other core order totals to get additional insight on the issue.

2. JSON library Changes

json.php was moved to the system/helper area
json is no longer loaded as a library because it is a helper. So you can remove the load step and
change "Json::encode" to "json_encode".
Again I recommend using a conditional for this change. I personally still use the tax change conditional as that is the most unique and monitorable change in this release:

Code: Select all

if (!method_exists($this->tax, 'getRates')) { //v1.5.1.2 or earlier
    $this->load->library('json');
    $this->response->setOutput(Json::encode($data));
} else {
    $this->response->setOutput(json_encode($data));
} 

Daniel wrote:the next one is going to be 1.5.2 it will have the order editing system and pdf invoices.

is 1.5.2 ok?

JNeuhoff wrote:I think 1.5.2 will be fine.

I general, if we could use the following simple version numbering standard:

1.x.y.z

where

x indicates major new changes, including differences in the API or DB
y indicates new features, but keeps the API or DB the same or at least backward compatible
z indicates a bugfix release (can be omitted the first time a new y or x is introduced)


So we'd expect for example something like this in the foreseeable future

1.5.2 (new features e.g. order editing and PDF invoices)
1.5.2.1 (future bugfix release for 1.5.2)
1.5.2.2 (2nd bugfix release for 1.5.2)
......

I think that's how most OpenCart users and contributors interpreted the version numbering.

JNeuhoff wrote:

Qphoria wrote: dunno.. just shootin out ideas.

Perhaps implement the old Tax::getRate($tax_class_id) in a VQmod XML file and let it call in turn the new methods? This way there might be no need to change all the addons, have to look into it. Certainly my Google Checkout module is broken now in 1.5.1.3 because of the changes with the tax.

framos41 wrote:Hello,

I had used this to upgrade my OC v1.5.1 to v1.5.1.3 and now in admin i cant see the images in the product setting, if i add a new image it is shown in front end but not shown in admin, anyone with this same problem?

Regards

Package opencart_v1.5.1.3.1.zip the installation folder, still have .svn folder and files

Qphoria wrote:

framos41 wrote:Hello,

I had used this to upgrade my OC v1.5.1 to v1.5.1.3 and now in admin i cant see the images in the product setting, if i add a new image it is shown in front end but not shown in admin, anyone with this same problem?

Regards

check your folder permissions on the image and image/data and image/cache folders

Daniel wrote:the next one is going to be 1.5.2 it will have the order editing system and pdf invoices.

is 1.5.2 ok?

Was the ability to manuel edit and add order included in this release?

opencartrules wrote:

Was the ability to manuel edit and add order included in this release?

No, next release 1.5.2 , but I am curious about how the solution will or should work.
When the customer goes to checkout, payment method is selected and payment is completed, how can you benefit from the ability to edit an order, add or delete rows, how about the payment - additional payments and credits ?

I have customers who change their mind about what they ordered. They send me an e-mail or phone me asking to adjust their order.

opencartrules wrote:I2Paq

I have customers who change their mind about what they ordered. They send me an e-mail or phone me asking to adjust their order.

Of course, I realize the benefits of it! In most Managament Information System it is a must.
But how about the payment solutions? If the customer has already paid with VISA card and the payment is completed?
Do you realize how much extra work it will create in the long run? Then you have to edit and adjust their order, make a credit or additional payments, how about the accounting ?

order edit is nearly done.