OpenCart 1.5.1.1 Bug Thread

JNeuhoff wrote:

rph wrote:To get back on topic a bit, for the country cache we have

Catalog

Code: Select all

if (!$country_data) {
    $query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country WHERE status = '1' ORDER BY name ASC");
    
    $country_data = $query->rows;
        
    $this->cache->set('country', $country_data);
} 

Admin

Code: Select all

if (!$country_data) {
    $query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country ORDER BY name ASC");
    
    $country_data = $query->rows;
            
    $this->cache->set('country', $country_data);
} 

For the Admin, in file admin/model/localisation/country.php, change it to:

Code: Select all

			.....
			$country_data = $this->cache->get('admin_country');
		
			if (!$country_data) {
				$query = $this->db->query("SELECT * FROM " . DB_PREFIX . "country ORDER BY name ASC");
	
				$country_data = $query->rows;
			
				$this->cache->set('admin_country', $country_data);
			}
			.....

It's a different query compared to the frontend, therefore needs a different cache name.

fixed in svn will upload in a bit.

I'm going to start tiding everything up to get another release out with all the bug fixes since the last release. i think the order editing system is nearly finished but i don't want to spend another week or 2 finishing it when there have been some important bugs reported.

Daniel wrote:I'm going to start tiding everything up to get another release out with all the bug fixes since the last release. i think the order editing system is nearly finished but i don't want to spend another week or 2 finishing it when there have been some important bugs reported.

good point

Renato Frota wrote:Hello.

I couldn't find it anywhere else. Seems to be a bug.

When ordering, if the customer is not registered and choose to register, after fill the form and click 'continue', nothing happens... I think the div above the form should be re-opened and an alert be shown "registering done - login to continue ordering" (or maybe the user be automatically logged in). Currently, the user should guess by himself he should click "edit" on the profile div to login.

Thanks.

Somebody confirm this? Posted already? Fixed?

Very minor bug:

In catalog/controller/product/manufacturer.php : This always returns a string (as substr returns a string).

Code should be changed to: Basically is_int() should be changed to is_numeric() to return what I'm assuming to be the expected behavior.

That's incorrect because manufacturers name is a string and substr is merely grabbing the first character of that string

is_numeric would work, but so should is_int, so I can't see a bug here.

More likely an SQL bug... but can be fixed by just correcting the language file for now...

When deleting an option, error states "option currently assigned to 3 products". But, infact it's actually assigned to 1 product, 3times... (id = 16)

Renato Frota wrote:

Renato Frota wrote:Hello.

I couldn't find it anywhere else. Seems to be a bug.

When ordering, if the customer is not registered and choose to register, after fill the form and click 'continue', nothing happens... I think the div above the form should be re-opened and an alert be shown "registering done - login to continue ordering" (or maybe the user be automatically logged in). Currently, the user should guess by himself he should click "edit" on the profile div to login.

Thanks.

Somebody confirm this? Posted already? Fixed?

this is a bug they caused themselfs from missing some files. maybe language files are missing.

jcsmithy wrote:More likely an SQL bug... but can be fixed by just correcting the language file for now...

When deleting an option, error states "option currently assigned to 3 products".

options.PNG

But, infact it's actually assigned to 1 product, 3times... (id = 16)

sql.PNG

i think some redundant data needs removing.

mersfire wrote:Very minor bug:

In catalog/controller/product/manufacturer.php :

Code: Select all

		foreach ($results as $result) {
			if (is_int(substr($result['name'], 0, 1))) {
				$key = '0 - 9';
			} else {
				$key = substr(strtoupper($result['name']), 0, 1);
			}

This always returns a string (as substr returns a string).

Code should be changed to:

Code: Select all

		foreach ($results as $result) {
			if (is_numeric(substr($result['name'], 0, 1))) {
				$key = '0 - 9';
			} else {
				$key = substr(strtoupper($result['name']), 0, 1);
			}

Basically is_int() should be changed to is_numeric() to return what I'm assuming to be the expected behavior.

fixed.

uksitebuilder wrote:That's incorrect because manufacturers name is a string and substr is merely grabbing the first character of that string

is_numeric would work, but so should is_int, so I can't see a bug here.

Thanks for the reply, but I believe the intended behavior is to show a set of links at the top of the page A - Z, but if there is a manufacturer who's name begins with a number, the link name should be "0-9". The way it was written before would create individual links for 0, 1, 2, etc, if the manufacturer name began with numeric character. Either way works, but aesthetically, having one link for 0-9 looks less cluttered.

In either case, thanks goes to Daniel for all of his hard work!

OpenCart 1.5.1.2 Bug

catalog/model /catalog/product.php 23 and 24 line variable defined in the model two times. I believe there are errors. What is your opinion? This definition also does not V.1511.

fixed.

a new release is nearly ready. i just have to update some tax stuff and finsih the remain bugs on the bug tracker.

minor bug (post in method)
file: /catalog/model/account/customer.php
function addCustomer
Line: 43 I think it's better:

I am seeing some of my products listed twice and some products not showing at all. This happens when my products can't fit all on one page. If my default products view is set to 15 and I have 24 products total, when I click on page 2, I am seeing some of the same products that were listed on page 1. The products that should be shown on Page 2 are not showing at all. The link below is an example of where I am seeing this issue.

I posted this issue in General Support and uksitebuilder suggested that my SEO Keyword data needs to be cleaned up so that there are no spaces or ,. I made sure all Category and Products SEO Keyword fields were udpated and I'm still having the issue.

http://www.dolcemode.com/necklace,%20ne ... ces?page=1

Daniel wrote:

Renato Frota wrote:

Renato Frota wrote:Hello.

I couldn't find it anywhere else. Seems to be a bug.

When ordering, if the customer is not registered and choose to register, after fill the form and click 'continue', nothing happens... I think the div above the form should be re-opened and an alert be shown "registering done - login to continue ordering" (or maybe the user be automatically logged in). Currently, the user should guess by himself he should click "edit" on the profile div to login.

Thanks.

Somebody confirm this? Posted already? Fixed?

this is a bug they caused themselfs from missing some files. maybe language files are missing.

I found the problem. This occurs when mail sending fails. After I configured the e-mail settings properly, the registering worked fine!

Daniel wrote:

shadowsdweller wrote:I don't know if those 2 bugs have been reported (both found on clear OC 1.5.1.1 installation), but I am doing it now:

- An affiliate cannot change his password. The system says the password has been successfully changed, but in fact the old password is working and the new one is not.
- An affiliate cannot see his current payment options (although they are visible at the admin panel). The affiliate just sees the reset form with no data in it.

I fixed the password thing but you can edit the payment details under index.php?route=affiliate/payment there is a link there.

Can anyone help by pointing to exactly where the fix for the affiliate password issue is?
I have spent all morning on the forums and cannot find the fix Daniel refers to above - apologies if this is obvious to everyone else!

Many thanks in advance :-)

debbiekipt wrote: Can anyone help by pointing to exactly where the fix for the affiliate password issue is?
I have spent all morning on the forums and cannot find the fix Daniel refers to above - apologies if this is obvious to everyone else!

Many thanks in advance :-)

I think it is fixed in the SVN.

freshbreeze wrote:Re: Shipping Estimator:

if you use button to "apply shipping" it is added to total on shopping cart page but when you checkout, your selection is not carried over and it defaults to whatever shipping method appears first in the list.

I have this same problem as freshbreeze.

When you estimate shipping in the cart and then checkout the cost is different then estimated(by alot) and the service you selected in the cart is not what is selected in checkout. I am using the USPS shipping.

SOLVED -
Affiliate password fix is here - http://code.google.com/p/opencart/source/detail?r=582

i2Paq wrote:

debbiekipt wrote: Can anyone help by pointing to exactly where the fix for the affiliate password issue is?
I have spent all morning on the forums and cannot find the fix Daniel refers to above - apologies if this is obvious to everyone else!

Many thanks in advance :-)

I think it is fixed in the SVN.

Thanks for the reply, I have I never heard of SVN before this - I tried to find it, but think the area I found with 'revision 604' is not the right one as the affiliate/password.php file gives a fatal error when uploaded?

Can anyone help by posting a link direct to the file/fix where the affiliate password issue is please?

Apologies again if this is obvious to everyone else and thanks in advance for your help!