This is a new bug report and a proposed bugfix solution. I hope Q will add it in 1.4.9.5 and later.toejamm10 wrote:JNeuhoff, is this for my question\problem or for eric1998?
Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig
Code: Select all
public function output() {
//Q: Add width/height tags to all images for Google Page Speed tip:
//http://code.google.com/speed/page-speed/docs/rendering.html#SpecifyImageDimensions
preg_match_all('/<img[^>]+>/i', $this->output, $result);
$img = array();
foreach($result[0] as $img_tag) {
preg_match_all('/(width|height|src)=("[^"]*")/i',$img_tag, $img[$img_tag]);
}
foreach ($img as $k => $info) {
if (count($info) == 3 && $info[1][0] == 'src') {
if (file_exists(str_replace('"', '', $info[2][0]))) {
$image_info = getImageSize(str_replace('"', '', $info[2][0]));
$k = trim($k, '/>');
$k = trim($k, '>');
$this->output = str_replace($k, ($k . ' ' . $image_info[3]), $this->output);
}
}
}
//
if ($this->level) {
$ouput = $this->compress($this->output, $this->level);
} else {
$ouput = $this->output;
}
if (!headers_sent()) {
foreach ($this->headers as $header) {
header($header, TRUE);
}
}
echo $ouput;
}I've added this category fix to 1.4.9.5JNeuhoff wrote:This is a new bug report and a proposed bugfix solution. I hope Q will add it in 1.4.9.5 and later.toejamm10 wrote:JNeuhoff, is this for my question\problem or for eric1998?
Q.: I have a number of other 1.4.9.4 bugfixes specified in a VQmod XML file. If you afre interested, I can send it to you.
Well the word "ouput" is a typo.. but it is just a variable name and it matches in all places it needs to so it doesn't break anythingBrook wrote:I have OpenCart 1.4.9.4 installed. Not sure if this is a typo, a bug or what?
Notice the variable "$ouput" in the code below, should it be "$output", not sure what the code really does so don't want to break anything by making a change to the code... Any suggestions?
Code: Select all
$option_value_data = array();
foreach ($results as $result) {Code: Select all
foreach ($results as $result) {
$option_value_data = array();https://www.lotnllc.com is your one stop shop for all your computer needs!
Code: Select all
if (isset($data['filter_name']) && !is_null($data['filter_name'])) {
$implode[] = "CONCAT(c.firstname, ' ', c.lastname) LIKE '%" . $this->db->escape($data['filter_name']) . "%'";
}
if (isset($data['filter_email']) && !is_null($data['filter_email'])) {
$implode[] = "c.email = '" . $this->db->escape($data['filter_email']) . "'";
}Code: Select all
if (isset($data['filter_name']) && !is_null($data['filter_name'])) {
$implode[] = "LCASE(CONCAT(c.firstname, ' ', c.lastname)) LIKE '%" . $this->db->escape($data['filter_name']) . "%'";
}
if (isset($data['filter_email']) && !is_null($data['filter_email'])) {
$implode[] = "LCASE(c.email) LIKE '%" . $this->db->escape($data['filter_email']) . "%'";
}-Ryan
This was already fixed in 1.4.9.5.rph wrote:I would recommend the following changes to get admin customer filtering working properly:
admin/model/sale/customer.php
public function getCustomerstoCode: Select all
if (isset($data['filter_name']) && !is_null($data['filter_name'])) { $implode[] = "CONCAT(c.firstname, ' ', c.lastname) LIKE '%" . $this->db->escape($data['filter_name']) . "%'"; } if (isset($data['filter_email']) && !is_null($data['filter_email'])) { $implode[] = "c.email = '" . $this->db->escape($data['filter_email']) . "'"; }Code: Select all
if (isset($data['filter_name']) && !is_null($data['filter_name'])) { $implode[] = "LCASE(CONCAT(c.firstname, ' ', c.lastname)) LIKE '%" . $this->db->escape($data['filter_name']) . "%'"; } if (isset($data['filter_email']) && !is_null($data['filter_email'])) { $implode[] = "LCASE(c.email) LIKE '%" . $this->db->escape($data['filter_email']) . "%'"; }
UPS defaults to 12x12x12 which is considered a "regular package". Anything from 1x1x1 to 12x12x12 is the sameDemon5 wrote:1.4.9.5 Bug
UPS Shipping bug.
110602: Missing/Illegal Combination of Package/Dimensions
If I flat out put a package size into the ups settings to get rid of the error it will overcharge for small items and undercharge for large items.. My distrib's csv does not provide me with shipping dimensions and updating 6k products after googling each and every one of them with hopes of finding dimensions would be horrid.. Can we get the old ups module with just added insurance to it?
You are right.. I made the fix in the order filter but not customer filter. But I should note your change is only half right as well. You need strtolower on the "$data['filter_name']" part as well or it won't find capital lettersrph wrote:It's not Q. I checked before submitting. It's only half fixed in the latest 1.5.0 SVN too.Qphoria wrote:This was already fixed in 1.4.9.5.
Code: Select all
$quote_data['airsure'] = array(
'id' => 'royal_mail.surface',Code: Select all
$quote_data['surface'] = array(
'id' => 'royal_mail.surface',Already fixed in 1.4.9.5DefProc wrote:There is an error with the royal_mail module which means it's not possible to select either AIrsure or Surface Mail if they're both active, and it's never possible to select Surface Mail.
as I have another things to do to keep my tiny business running 
Sometimes, upgrading to newer version isn't an option if you've made some customizations to your installation (custom pages, translations, extra text, etc.)tl;drSimplicity wrote: When visiting DOWNLOAD section I see that 1.4.9.4 was released on March 19, 2011 and there's no additional information about bugs and fixes.
Users browsing this forum: No registered users and 86 guests
