Post by tdweb » Tue Jun 15, 2010 6:23 pm

Hi

I have a little suggestion about the presentation on payment comments:

For example if the client chose bank transfer as payment option, the information about the bank account only apear in the confirmation page, before submitting the order. It is not passed to the email message and that is an important issue.

I know that the information is presented in the client account history, but I think it was better if that info appear also in email message.

Other think. Like cheque payment option the payment comments shouldn't be presented in the confirmation page. That can induce the client to think that the order have been accepted, and he could forget to click the confirm button.

(Sorry for my English)

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by Qphoria » Tue Jun 15, 2010 9:42 pm

in 1.4.8 comments were fixed for emails

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by tdweb » Tue Jun 15, 2010 10:15 pm

humm

I have upgrade from 1.4.7. but the only comments included in the email are just de comments fielded in the comment text box (by the client) the coments about the Bank Transfer payment ( Bank Transfer Instructions fielded in backoffice) are presented in the confirm page and in the order history (as history entry not as comment), but they are not being included in the email message.

Can you confirm this? Or is some problem whit my upgrade.

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by Qphoria » Tue Jun 15, 2010 10:25 pm

oh .. you mean you want the bank transfer data included in the email... I've never used it but I guess it has its own box. That can be arranged

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by tdweb » Tue Jun 15, 2010 11:13 pm

Yes that's it. I well wait for any tip. I'm developing a new module based on "pay by cheque" and need that the information about payment is passed to the email.

Thank's for your fast reply.

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by Qphoria » Tue Jun 15, 2010 11:19 pm

Try this....

1. EDIT: catalog/model/checkout/order.php

2. FIND at row 176:

Code: Select all

$template->data['comment'] = $order_query->row['comment']; 
3. REPLACE WITH:

Code: Select all

$template->data['comment'] = ($order_query->row['comment'] . '<br /><br />' . nl2br($comment)); 
Last edited by i2Paq on Wed Jun 16, 2010 3:13 am, edited 1 time in total.
Reason: Added line-number

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Tue Jun 15, 2010 11:31 pm

Qphoria wrote:oh .. you mean you want the bank transfer data included in the email... I've never used it but I guess it has its own box. That can be arranged
That would be a good change as a lot of people still pay by bank transfer and forget to wright down the info displayed on the site.
Having it in the e-mail will solve a lot of headaches ;)

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Tue Jun 15, 2010 11:36 pm

Well it actually "was" in the old text based email. Looks like it was left out in the html email version.

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by tdweb » Wed Jun 16, 2010 12:06 am

it work, but it's not assuming line brakes (<br> tags). Can you helpe me?

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by tdweb » Wed Jun 16, 2010 12:16 am

I do not explain correctly, in admin there is a text field for Bank "Transfer Instructions:" it's not html it's a simple text box. I wright text in 3 diferent lines but in the email it put all together in just one line. I'm not using <br> tags.

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by i2Paq » Wed Jun 16, 2010 1:14 am

Qphoria wrote:Well it actually "was" in the old text based email. Looks like it was left out in the html email version.
Will you add at back?

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Wed Jun 16, 2010 1:55 am

I just did above

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Wed Jun 16, 2010 1:58 am

tdweb wrote:I do not explain correctly, in admin there is a text field for Bank "Transfer Instructions:" it's not html it's a simple text box. I wright text in 3 diferent lines but in the email it put all together in just one line. I'm not using <br> tags.
I updated it above... try that new line with nl2br() around it

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Wed Jun 16, 2010 2:06 am

Qphoria wrote:I just did above
I mean, in the OpenCart core.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Wed Jun 16, 2010 2:27 am

well as soon as you freaks test out my change, I will put it in :)
Less questions.. more testin's!

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Wed Jun 16, 2010 3:16 am

Qphoria wrote:well as soon as you freaks test out my change, I will put it in :)
Less questions.. more testin's!
Testing, testing, testing.

Succes!

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by tdweb » Wed Jun 16, 2010 3:03 pm

Today I have no time. I will try later. Thank you.

New member

Posts

Joined
Fri Jun 04, 2010 10:35 pm

Post by Joxe » Wed Jul 21, 2010 6:05 am

Thanks!!!
Just what I needed!

ps: my code was in line 170, not 176 ;)

v. 1.4.9.6 & v. 2.0.2.0


Active Member

Posts

Joined
Wed Apr 28, 2010 6:12 am

Post by blsuk » Thu Feb 03, 2011 3:56 pm

Hey guys!

I have read the above and still have an issue with the customer comments from an order being tranferred to email when using 'registered user'. It works perfectly on guest checkout.

I have tried to fathom it out but I'm not confident on which part needs to be changed, i have compared the guest_step_3.php and confirm.php files and have also looked at the suggestions above in order.php but I'm pretty sure the problem lies with the confirm.php file or confirm.tpl.

Any help would be massively appreciated :O))

Newbie

Posts

Joined
Wed Dec 08, 2010 12:25 am

Post by andrixx » Tue Sep 06, 2011 10:32 pm

this line is completely removed in the Opencart 1.5.1.1 core.
$template->data['comment'] = ($order_query->row['comment'] . '<br /><br />' . nl2br($comment));

if this was supposed to be added to the core, then it's not there.

I am using it now and it works. It is very important that the costumer gets this payment information in their email. So I recommend it's in the core.

Maybe people don't use bank-transfer, I translated my module to work as BankGiro.

New member

Posts

Joined
Sat Jun 18, 2011 7:23 pm
Who is online

Users browsing this forum: No registered users and 13 guests