Awesome! I was looking at doing this at some point but good to see someone else got it working.
One note I would add from a developer standpoint is to try to edit as few of the core files as possible.
For example, the catalog/model/catalog/product.php file
You could have just made your own tags.php file and referenced that from the module. This way you wouldn't have to edit the core file.. similar steps can be taken to avoid editing in other files too.
You will see the importance of this during upgrades and as more mods come out and start replacing the same files.
But otherwise nice work!
One note I would add from a developer standpoint is to try to edit as few of the core files as possible.
For example, the catalog/model/catalog/product.php file
You could have just made your own tags.php file and referenced that from the module. This way you wouldn't have to edit the core file.. similar steps can be taken to avoid editing in other files too.
You will see the importance of this during upgrades and as more mods come out and start replacing the same files.
But otherwise nice work!
@dav:
1. the url looks like this: ../index.php?route=product/search&keyword=tag&description=1
2. can you please tell me how to remove the hardcoded line? my site isn't in english, and i'd like to comment it out please.
3. yes, i have added tags to products.
is there some minimum number of tags that must be present to show up in the sidebar?
1. the url looks like this: ../index.php?route=product/search&keyword=tag&description=1
2. can you please tell me how to remove the hardcoded line? my site isn't in english, and i'd like to comment it out please.
3. yes, i have added tags to products.
is there some minimum number of tags that must be present to show up in the sidebar?
also: the tags do not display accented characters (in other languages using the latin script)
how does one fix this? presumably from the sql tables, yes? could you tell me the right way to do this? will i need to make tags again?
how does one fix this? presumably from the sql tables, yes? could you tell me the right way to do this? will i need to make tags again?
davy: ah yes, editing the module leads to the tags showing up in the sidebar, cool.
search is still broken: so clicking on the tags in the sidebar lead to a zero result page.
if i were to upgrade to the new mod, what files do i have to change?
search is still broken: so clicking on the tags in the sidebar lead to a zero result page.
if i were to upgrade to the new mod, what files do i have to change?
dave: i did a diff on my existing product.php and the one you have modified in the new contrib.
here is the result of the diff: http://pastebin.ca/1603885
in your last post you mention changes on line 77 and 133, but the diff shows up a lot more changes.
should i change them all?
here is the result of the diff: http://pastebin.ca/1603885
in your last post you mention changes on line 77 and 133, but the diff shows up a lot more changes.
should i change them all?
Does anyone have an idea on how to repair this module for v1.3.4 ?
Matt
Matt
Code: Select all
It was like that when I found it, honest!
Norman in 't Veldt
Moderator OpenCart Forums
_________________ READ and Search BEFORE POSTING _________________
Our FREE search: Find your answer FAST!.
[How to] BTW + Verzend + betaal setup.
Who is online
Users browsing this forum: No registered users and 134 guests