Post by Qphoria » Wed Oct 07, 2009 11:46 pm

Awesome! I was looking at doing this at some point but good to see someone else got it working.

One note I would add from a developer standpoint is to try to edit as few of the core files as possible.
For example, the catalog/model/catalog/product.php file
You could have just made your own tags.php file and referenced that from the module. This way you wouldn't have to edit the core file.. similar steps can be taken to avoid editing in other files too.

You will see the importance of this during upgrades and as more mods come out and start replacing the same files.

But otherwise nice work!

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Qphoria » Thu Oct 08, 2009 4:36 am

Yea, I dont mean to insinuate you could keep ALL code out of the core files..there are ways I've found to "limit" the editing of other core files whenever possible.

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by madany » Thu Oct 08, 2009 11:55 am

hi davgothic... could u remark your code/script, so i know where to insert code into each existing files
Thx :)

New member

Posts

Joined
Mon Aug 31, 2009 2:03 pm

Post by yegga » Thu Oct 08, 2009 4:05 pm

hi davy and qphoria,

i uploaded the files ands ran the sql - but clicking on the tags doesnt show up in search. thoughts?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 4:52 pm

furthermore, the text showing up in the sidebar is 'No tags to display'

this string isn't in tagcloud.php in the language files: it isn't heading_title or text_notags; so where is it coming from?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 5:16 pm

@dav:

1. the url looks like this: ../index.php?route=product/search&keyword=tag&description=1

2. can you please tell me how to remove the hardcoded line? my site isn't in english, and i'd like to comment it out please.

3. yes, i have added tags to products.

is there some minimum number of tags that must be present to show up in the sidebar?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 5:21 pm

also: the tags do not display accented characters (in other languages using the latin script)

how does one fix this? presumably from the sql tables, yes? could you tell me the right way to do this? will i need to make tags again?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 6:22 pm

davy: ah yes, editing the module leads to the tags showing up in the sidebar, cool.

search is still broken: so clicking on the tags in the sidebar lead to a zero result page.

if i were to upgrade to the new mod, what files do i have to change?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 6:35 pm

also: is there a way of specifying how many words go on one line?

i'd like to limit it to 3 words per line

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 6:55 pm

dave: i did a diff on my existing product.php and the one you have modified in the new contrib.

here is the result of the diff: http://pastebin.ca/1603885

in your last post you mention changes on line 77 and 133, but the diff shows up a lot more changes.

should i change them all?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 7:07 pm

further: you're right, i used css to fix the number of words per line.

also: right now the tag cloud orders the tags randomly, is there any way of doing this alphabetically?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 8:18 pm

dav: i went through all the steps you mention; its still off. clicking on tags leads to zero search result page.

am i messing something up in the admin perhaps?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 8:27 pm

edit: its all good now. i was updating an ancient version of product.php.

looks good davy, thakn you for this mod!

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by yegga » Thu Oct 08, 2009 8:32 pm

a suggestion: how would you go about pulling all tags on one page?

Active Member

Posts

Joined
Tue Sep 08, 2009 5:03 am

Post by moggiex » Sun Nov 15, 2009 8:52 pm

Does anyone have an idea on how to repair this module for v1.3.4 ?

Matt

Code: Select all

It was like that when I found it, honest!


User avatar
Active Member

Posts

Joined
Mon Nov 09, 2009 9:55 pm

Post by Skyhigh » Wed Nov 25, 2009 4:09 am

Maybe my browsers b0rked, but the original post with the download link seems to have disappeared?

Does anyone have a link to a download of the 1.3.2 version please?

(looks like the mod I've been looking for, for months!)

New member

Posts

Joined
Fri Sep 11, 2009 8:12 pm

Post by matt5409 » Fri Feb 19, 2010 12:39 am

me too! this is really the deciding factor for me, product tags are very important :)

Newbie

Posts

Joined
Wed Feb 17, 2010 9:41 pm

Post by Qphoria » Fri Feb 19, 2010 12:49 am

Ya, I'm not sure what happened here.

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by i2Paq » Fri Feb 19, 2010 12:52 am

Qphoria wrote:Ya, I'm not sure what happened here.
It wasn't me! ;D

Here.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by Qphoria » Fri Feb 19, 2010 1:04 am

i2Paq wrote:
Qphoria wrote:Ya, I'm not sure what happened here.
It wasn't me! ;D

Here.
I confess you were my first suspect :P

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am
Who is online

Users browsing this forum: No registered users and 4 guests