Post by Pamella » Wed Jun 16, 2021 7:45 pm

Not a bug ;) but it seems a clearfix is missing (account register and contact pages)

Code: Select all

        {% if text_agree %}
        <div class="buttons">
          <div class="pull-right">{{ text_agree }}
            {% if agree %}
            <input type="checkbox" name="agree" value="1" checked="checked" />
            {% else %}
            <input type="checkbox" name="agree" value="1" />
            {% endif %}
            &nbsp;
            <input type="submit" value="{{ button_continue }}" class="btn btn-primary" />
          </div>
        </div>
        {% else %}
        <div class="buttons">
          <div class="pull-right">
            <input type="submit" value="{{ button_continue }}" class="btn btn-primary" />
          </div>
        </div>
        {% endif %}
https://github.com/opencart/opencart/bl ... ister.twig

Code: Select all

        <div class="buttons">
          <div class="pull-right">
            <input class="btn btn-primary" type="submit" value="{{ button_submit }}" />
          </div>
        </div>
https://github.com/opencart/opencart/bl ... ntact.twig

It should be, isn't ?

Code: Select all

<div class="buttons clearfix">
Last edited by Pamella on Mon Jun 21, 2021 10:04 pm, edited 1 time in total.

OC 3.0.3.7 EN (default theme) running on PHP 7.3 MariaDB 10.3 Linux / Apache 2.4


New member

Posts

Joined
Tue Oct 25, 2011 4:22 am

Post by straightlight » Wed Jun 16, 2021 8:10 pm

Create a new Pull Request on the Opencart Github repository about it. A maintenance branch could be added to your commit if the issue has never been reported before about it. This could still be considered as a bug, also depending on the Bootstrap version being used compared to these two OC releases.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Pamella » Fri Jun 18, 2021 9:55 pm

Well, thanks @straightlight one more time ;) useful info

PS: No GitHub account but already done by the following user, then may be ;) somebody else could be add it to OpenCart pull requests ?
https://github.com/condor2/Opencart_30x ... 802d08b661

OC 3.0.3.7 EN (default theme) running on PHP 7.3 MariaDB 10.3 Linux / Apache 2.4


New member

Posts

Joined
Tue Oct 25, 2011 4:22 am

Post by straightlight » Fri Jun 18, 2021 10:26 pm

Pamella wrote:
Fri Jun 18, 2021 9:55 pm
Well, thanks @straightlight one more time ;) useful info

PS: No GitHub account but already done by the following user, then may be ;) somebody else could be add it to OpenCart pull requests ?
https://github.com/condor2/Opencart_30x ... 802d08b661
The issue you're addressing about is not from the Opencart Github repository but outside of its repository.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Pamella » Fri Jun 18, 2021 10:42 pm

Yep, commits by "condor2" but for example you can't push it to OpenCart's pull requests? if theses changes 've not been made by you? Sorry I don't know how GitHub is working

OC 3.0.3.7 EN (default theme) running on PHP 7.3 MariaDB 10.3 Linux / Apache 2.4


New member

Posts

Joined
Tue Oct 25, 2011 4:22 am

Post by straightlight » Fri Jun 18, 2021 11:18 pm

Pamella wrote:
Fri Jun 18, 2021 10:42 pm
Yep, commits by "condor2" but for example you can't push it to OpenCart's pull requests? if theses changes 've not been made by you? Sorry I don't know how GitHub is working
Since the commit has been closed, and not re-opened, then the probabilities to have those changes to be expected are more than the lower level.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by Pamella » Mon Jun 21, 2021 10:03 pm

Ok, then I 'll close this topic, thank to @straightlight

OC 3.0.3.7 EN (default theme) running on PHP 7.3 MariaDB 10.3 Linux / Apache 2.4


New member

Posts

Joined
Tue Oct 25, 2011 4:22 am
Who is online

Users browsing this forum: No registered users and 6 guests