Probably should patch this one since bots like to hit this form, not a huge issue, but it fills up error logs, etc.
Link to thread. - viewtopic.php?t=215547#p773734
Was able to replicate on v3.0.3.4 a few versions back, not sure if you patched this one.
Full Stack Web Developer :: Send a PM for Custom Work.
Backup and learn how to recover before you make any changes!
It was fixed based on the master branch but I think the solution we both worked on might be better as we already have the input from the OP of that topic indicating it did solved the issue. Let's see how it goes on this one.sw!tch wrote: ↑Mon Jun 22, 2020 8:02 amA non-numeric value encountered - From Voucher when a non-number is entered in amount..
Probably should patch this one since bots like to hit this form, not a huge issue, but it fills up error logs, etc.
Link to thread. - viewtopic.php?t=215547#p773734
Was able to replicate on v3.0.3.4 a few versions back, not sure if you patched this one.
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Fixed catalog/controller/account/affiliate.php with custom fields.
- Fixed catalog/controller/account/forgotten.php
- Fixed catalog/controller/account/register.php
- Fixed catalog/controller/account/voucher.php as per post provided by sw!tch: viewtopic.php?f=201&t=218203&p=791513#p791499 .
- Fixed catalog/controller/account/wishlist.php
- Fixed catalog/controller/affiliate/register.php
- Fixed catalog/controller/checkout/payment_address.php
- Fixed catalog/controller/checkout/shipping_address.php
- Fixed catalog/controller/extension/module/banner.php with html_entity_decode on the $result['image'] . Not yet in master branch
- Fixed catalog/controller/tool/upload.php as per master branch
- Fixed admin/controller/tool/upload.php as per master branch
- Fixed catalog/controller/extension/module/bestseller.php with review_status config; not yet on master branch
- Fixed admin/controller/catalog/filter.php as per this commit: https://github.com/opencart/opencart/pull/8026
- Reverted to leafo vendor
- Replaced all JSON redirection / links with str_replace from & to '&' characters on the URL. Not yet on master branch
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Added more warnings in the OC admin as per this commit: https://github.com/opencart/opencart/pu ... d825dcf60b .
- Fixed admin/controller/report/statistics.php as per this commit: https://github.com/opencart/opencart/pu ... c28e6588ec
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Fixed wishlist conventional array names in catalog account/account and account/wishlist.
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
Code: Select all
if (is_file(DIR_IMAGE . $banner_image['image'])) {
Code: Select all
if (is_file(DIR_IMAGE . html_entity_decode($banner_image['image'], ENT_QUOTES, 'UTF-8'))) {
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Ok, fixed.xxvirusxx wrote: ↑Wed Jun 24, 2020 6:50 amadmin/controller/design/banner.php, change:
to:Code: Select all
if (is_file(DIR_IMAGE . $banner_image['image'])) {
Code: Select all
if (is_file(DIR_IMAGE . html_entity_decode($banner_image['image'], ENT_QUOTES, 'UTF-8'))) {
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
Change:
Code: Select all
$data['payment_bank_transfer'] = array();
Code: Select all
$data['payment_bank_transfer_bank'] = array();
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Fixed.xxvirusxx wrote: ↑Wed Jun 24, 2020 1:57 pmBank Transfer missing value: admin/controller/extension/payment/bank_transfer.php
Change:toCode: Select all
$data['payment_bank_transfer'] = array();
https://github.com/opencart/opencart/pull/7936/filesCode: Select all
$data['payment_bank_transfer_bank'] = array();
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Fixed admin banner image, bank transfer array and removed text_empty in account/wishlist.
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Fixed all html_entity_decode with image post, database insertions and database updates.
- Fixed reserved terms with database with escaped quotes such as type and description.
- Fixed voucher as per this commit: https://github.com/opencart/opencart/pull/8040 .
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
- Completed description database fields with escaped quotes.
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
LE. You have updated Bootstrap? Because you use...
Code: Select all
<i class="fas fa-cog">
Code: Select all
<div class="float-right">
Attachments
Screenshot_2020-06-25_20-24-10.png (10.05 KiB) Viewed 3098 times
Screenshot_2020-06-25_20-21-33.png (68.82 KiB) Viewed 3102 times
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Looked everywhere for fas and can't find any of it.
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
Now on Firefox I have this error..
Code: Select all
Parse error: syntax error, unexpected 'template' (T_STRING), expecting variable (T_VARIABLE) in catalog/controller/event/theme.php on line 3
The function is:
Code: Select all
public function index($route, $args, &template) {
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Ok, fixed and package updated.xxvirusxx wrote: ↑Fri Jun 26, 2020 4:01 amIs fking weird...
Now on Firefox I have this error..Downloaded: opencart-3.0.3.4-core-pre.zipCode: Select all
Parse error: syntax error, unexpected 'template' (T_STRING), expecting variable (T_VARIABLE) in catalog/controller/event/theme.php on line 3
The function is:
Code: Select all
public function index($route, $args, &template) {
The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.
Regards,
Straightlight
Programmer / Opencart Tester
Some text is missing. From Admin login page, Add to cart from catalog, some text from footer (informations)..etc
LE. catalog/controller/event/language.php
When you change from:
Code: Select all
public function index($route, $args) {
Code: Select all
public function index(&$route, &$args) {
Same for admin. admin/controller/event/language.php
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Jim
https://www.carguygarage.com
Yahoo Store since 2006 moved to OpenCart on January 24, 2020
Change this:
Code: Select all
'href' => $this->url->link('customer/customer/login', 'user_token=' . $this->session->data['user_token'] . '&customer_id=' . $result['customer_id'] . '&store_id=' . $result['store_id'], true)
Code: Select all
'href' => $this->url->link('customer/customer/login', 'user_token=' . $this->session->data['user_token'] . '&customer_id=' . $result['customer_id'] . '&store_id=' . $store['store_id'], true)
Same file. You forgot to change as Master

Code: Select all
$results = $this->model_customer_customer->getRewards($this->request->get['customer_id'], ($page - 1) * 10, 10);
Code: Select all
$results = $this->model_customer_customer->getRewards($customer_id, ($page - 1) * 10, 10);
Change this:
Code: Select all
$this->db->query("DELETE FROM " . DB_PREFIX . "location WHERE location_id = " . (int)$location_id);
Code: Select all
$this->db->query("DELETE FROM " . DB_PREFIX . "location WHERE location_id = '" . (int)$location_id . "'");
Change this:
Code: Select all
$('#input-code').on('keyup', function() {
Code: Select all
$('#input-code').on('keyup', function(e) {
Code: Select all
<small class="form-text text-muted">{{ help_code }}</small>
- admin/controller/sale/voucher.php, delete line 640
Code: Select all
$this->load->model('sale/voucher_theme');
- catalog/controller/extension/total, remove credit.php file, is a model not controller.
- why you have changed from:
Code: Select all
$json['redirect'] = str_replace('&', '&', $this->url->link('checkout/cart', '', true));
Code: Select all
$json['redirect'] = str_replace('&', '&', $this->url->link('checkout/checkout', '', true));
- /catalog/view/theme/default/template/checkout/register.twig
Change this: (line 322)
Code: Select all
{% if custom_field.type == 'time' %}
Code: Select all
{% if custom_field.type == 'datetime' %}
Extensions converted by me for Free | Custom 3.0.3.7 | Store upgrade service | Buy me a beer
Users browsing this forum: No registered users and 6 guests