Post by straightlight » Tue Oct 31, 2017 9:36 pm

In that file,

find:

Code: Select all

if (isset($this->request->get['method']) && $this->request->get['method'] == 'decline') {
add above:

Code: Select all

if (empty($this->session->data['order_id'])) {
	$this->session->data['error'] = $this->language->get('error_declined');

	$this->response->redirect($this->url->link('checkout/cart'));
}

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by yodapt » Wed Nov 01, 2017 5:09 am

In the same file, find these two occurrences :

Code: Select all

$this->currency->getCode()

Code: Select all

$currency
replace with

Code: Select all

$order_info['currency_code']

Opencart Developer - My Extension Showcase
Contact me at aeon.yoda@gmail.com


User avatar
Active Member

Posts

Joined
Fri Jun 17, 2011 6:39 pm


Post by straightlight » Wed Nov 01, 2017 7:00 am

On that file, the only line I can see regarding the currency steps you provided is this one:

Code: Select all

$data['amount'] = $this->currency->format($order_info['total'], 'GBP', false, false);
The same at: https://raw.githubusercontent.com/openc ... nochex.php

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by yodapt » Wed Nov 01, 2017 9:47 pm

Hmm, I was thinking of this file : https://support.nochex.com/kb/faq.php?id=146

If you download the v3 package, you'll find what I ment, and also some other issues. This was after a client tried to install that extension and couldnt get it to work.

Opencart Developer - My Extension Showcase
Contact me at aeon.yoda@gmail.com


User avatar
Active Member

Posts

Joined
Fri Jun 17, 2011 6:39 pm


Post by straightlight » Wed Nov 01, 2017 9:51 pm

The URL should of been posted with your last correction. At least, now, we have both versions posted.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by yodapt » Wed Nov 01, 2017 10:11 pm

I didnt noticed that module was already included in v3. I guess those changes I mentioned can be discarded then, and rather a notice about the module from the official website not being ready for production?

Opencart Developer - My Extension Showcase
Contact me at aeon.yoda@gmail.com


User avatar
Active Member

Posts

Joined
Fri Jun 17, 2011 6:39 pm


Post by straightlight » Wed Nov 01, 2017 10:25 pm

I am currently investigating these comparisons.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 6 guests