Image Popup Resize

Qphoria wrote:Maybe the image class should be changed to do that that. If you leave the size blank, then use the default image size.

hubba wrote:I have went to the settings and blank out the image pop up size field when I test it in the store , it gives me error alot of errors.

Qphoria wrote:Well my fix works at the image level. If you leave things like product thumb set to x then you will see the default image size

But the popup has 2 controllers
1 - The popup size in admin
2 - The thickbox auto-size

If you have firebug you can inspect the thickbox popup and see:

Code: Select all

<img width="406" height="406" alt="" src="http://localhost/v144/image/cache/data/apple_cinema_30-500x500.jpg" id="TB_Image">

Even tho my image is set to 500x500 the width and height is 406x406

Same with 700x700

Code: Select all

<img width="406" height="406" alt="" src="http://localhost/v144/image/cache/data/apple_cinema_30-700x700.jpg" id="TB_Image">

I looked at the thickbox code briefly and it seems to be doing additional calculations based on pagesize and other coords so it is limiting the max size. I guess that is why thickbox was discontinued

Qphoria wrote:did you make the code change in the image.php file?

<?php
function image_resize($filename, $width, $height) {
	if (!file_exists(DIR_IMAGE . $filename)) {
		return;
	} 
	
	if (!$width || !$height) {
      list($width, $height) = getimagesize(DIR_IMAGE . $filename); 
   }	
$old_image = $filename;
	$new_image = 'cache/' . substr($filename, 0, strrpos($filename, '.')) . '-' . $width . 'x' . $height . '.jpg';
	
	if (!file_exists(DIR_IMAGE . $new_image) || (filemtime(DIR_IMAGE . $old_image) > filemtime(DIR_IMAGE . $new_image))) {
		$image = new Image(DIR_IMAGE . $old_image);
		$image->resize($width, $height);
		$image->save(DIR_IMAGE . $new_image);
	}

	if (isset($_SERVER['HTTPS']) && (($_SERVER['HTTPS'] == 'on') || ($_SERVER['HTTPS'] == '1'))) {
		return HTTPS_IMAGE . $new_image;
	} else {
		return HTTP_IMAGE . $new_image;
	}	
}
?>