Post by fido-x » Sat May 23, 2015 7:15 pm

OSWorX wrote:But does no matter, Australia will win the Eurovision Song Contest 2015 tonight and everything is good.
Nah, that'll be tomorrow morning. It's already tonight where I am, while it's only this afternoon for you

You forget, I'm from Australia, and we're from the future. :joker:

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by OSWorX » Sat May 23, 2015 7:29 pm

fido-x wrote:
OSWorX wrote:But does no matter, Australia will win the Eurovision Song Contest 2015 tonight and everything is good.
Nah, that'll be tomorrow morning. It's already tonight where I am, while it's only this afternoon for you

You forget, I'm from Australia, and we're from the future. :joker:
No, I know ...
When the contest starts, it is here 21:00, at you it is then 05:00

Austria --> Australia .. what comes first ;-)

Custom Development | Individuelle Entwicklung | Support & Bugfixes

Image Image Image


User avatar
Guru Member

Posts

Joined
Mon Jan 11, 2010 10:52 pm
Location - Austria

Post by virgotch » Sat May 23, 2015 7:32 pm

it is just a new business release ))

New member

Posts

Joined
Sun Oct 26, 2014 4:10 am

Post by fido-x » Sat May 23, 2015 7:40 pm

OSWorX wrote:When the contest starts, it is here 21:00, at you it is then 05:00
Yeah, that's 5:00 am Sunday morning in Australia, but 9:00 pm Saturday night in Austria. By our standards, that will be "last night".

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by fido-x » Sun May 24, 2015 1:46 am

JNeuhoff wrote:I could also use an OCmod XML file for this, that's not a big issue.
Good idea! Then Daniel could use it to build a set of files that fix the bugs. Here's the first fix for you.
html_content.jpg

html_content.jpg (60.84 KiB) Viewed 11042 times

admin/controller/module/html.php
Line 99:

Code: Select all

$data['module_description'] = '';
SHOULD BE AN ARRAY!!!

Code: Select all

$data['module_description'] = array();

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by JNeuhoff » Sun May 24, 2015 2:46 am

fido-x: Well spotted, the same bug exists in OpenCart 2.0.2.0, too.

Now included in the respective bugfix files, see forum threads at

OpenCart 2.0.2.0 bugfixes in a VQmod xml file
OpenCart 2.0.3.0 bugfixes in a VQmod xml file

Also posted on github.

BTW.: I am sticking to VQmod XML for the time being, OCmod is not yet stable enough!

MHC Web Design
Override Engine * Integrated VQMod * Unused Images Manager * Instant Option Price Calculator * TrustPilot Reviews * Google Rich Snippets * Google Tag Manager * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by yodapt » Sun May 24, 2015 2:53 am

Why not propose a better version of the modification system to be included in the upcoming versions and replace the current ones, with backwards compatibility?

Oh right ... >:D

Opencart Developer - My Extension Showcase
Contact me at aeon.yoda@gmail.com


User avatar
Active Member

Posts

Joined
Fri Jun 17, 2011 6:39 pm


Post by fido-x » Sun May 24, 2015 3:21 am

JNeuhoff wrote:fido-x: Well spotted, the same bug exists in OpenCart 2.0.2.0, too.
And 2.0.1.x and 2.0.0.0

Here's a couple more:

admin/controller/payment/securetrading_pp.php
Line 277:

Code: Select all

$data['cancel'] = $this->url->link('extension/payment', 'token=' . $this->session->data['token']);
Should be:

Code: Select all

$data['cancel'] = $this->url->link('extension/payment', 'token=' . $this->session->data['token'], 'SSL');
admin/controller/payment/securetrading_ws.php
Line 278:

Code: Select all

$data['cancel'] = $this->url->link('extension/payment', 'token=' . $this->session->data['token']);
Should be:

Code: Select all

$data['cancel'] = $this->url->link('extension/payment', 'token=' . $this->session->data['token'], 'SSL');

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by rph » Sun May 24, 2015 7:45 am

This is a positive step forward though some clarity on whether we're in a feature freeze (no new features will be added but bugs will be fixed) or a code freeze (no code will be changed anywhere) would be helpful. I'd prefer a feature freeze since fixing bugs is unlikely to effect third-party extensions.

It would also be helpful to stretch the pre-release period to 10 business days rather than the ~4 here. Some developers and designers have a lot of work to do testing/upgrading for a new version of OpenCart.

EDIT: It is a code freeze according to the last update in the Github readme.md file so there will be known bugs when v2.0.3.0 ships.

https://github.com/opencart/opencart/bl ... d#releases

-Ryan


rph
Expert Member

Posts

Joined
Fri Jan 08, 2010 5:05 am
Location - Lincoln, Nebraska

Post by JNeuhoff » Sun May 24, 2015 10:06 pm

fido-x wrote:
JNeuhoff wrote:fido-x: Well spotted, the same bug exists in OpenCart 2.0.2.0, too.
And 2.0.1.x and 2.0.0.0

Here's a couple more:

admin/controller/payment/securetrading_pp.php
...
admin/controller/payment/securetrading_ws.php
...
Well, I just did a quick search, and the 'SSL' is missing for the Cancel links in the following files:

admin/controller/payment/amazon_checkout.php
admin/controller/payment/amazon_login_pay.php
admin/controller/payment/securetrading_pp.php
admin/controller/payment/securetrading_ws.php

Now posted on github, and I'll include it in the bugfix XML files, too.

MHC Web Design
Override Engine * Integrated VQMod * Unused Images Manager * Instant Option Price Calculator * TrustPilot Reviews * Google Rich Snippets * Google Tag Manager * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Iamdbat » Mon May 25, 2015 6:51 am

How about finishing the default template to a professional industry standard first?

Active Member

Posts

Joined
Sat Jan 28, 2012 7:32 am

Post by fido-x » Mon May 25, 2015 6:13 pm

I don't know whether this one causes any problems, as I haven't tested with multiple languages, but the potential is there.

admin/view/template/catalog/information_form.tpl
Line 53:

Code: Select all

<label class="col-sm-2 control-label" for="input-description"><?php echo $entry_description; ?></label>
Should be:

Code: Select all

<label class="col-sm-2 control-label" for="input-description<?php echo $language['language_id']; ?>"><?php echo $entry_description; ?></label>
This is a label for a form field with an id of "input-description<?php echo $language['language_id']; ?>". The "for" attribute of the label tag should match the "id" attribute of the form field that it is for. In this case a "textarea" tag found at line 55, which reads:

Code: Select all

<textarea name="information_description[<?php echo $language['language_id']; ?>][description]" placeholder="<?php echo $entry_description; ?>" id="input-description<?php echo $language['language_id']; ?>" class="form-control"><?php echo isset($information_description[$language['language_id']]) ? $information_description[$language['language_id']]['description'] : ''; ?></textarea>
This is also present in OC 2.0.1.0, 2.0.1.1 and 2.0.2.0, and has been previously reported in the "Bug Reports" section of this forum, as have all the bugs I've found in this new upcoming 2.0.3.0 release.

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by fido-x » Mon May 25, 2015 7:11 pm

Here's another.

admin/controller/payment/authorizenet_sim.php
Line 17:

Code: Select all

$this->redirect($this->url->link('extension/payment', 'token=' . $this->session->data['token'], 'SSL'));
This should be:

Code: Select all

$this->response->redirect($this->url->link('extension/payment', 'token=' . $this->session->data['token'], 'SSL'));

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by qahar » Mon May 25, 2015 7:40 pm

Heather wrote: OpenCart 2.0.3.0 is available to download now exclusively for developers. Download 2.0.3.0 from GitHub now to have a sneak peek at the new system and get a head start in updating your modules before the full release next Wednesday (May 27th 2015).
Even though a week, it's better than sudden release.

But once the release tags made on github, people will always assume it's stable release.
I want to tweet about this release but cancel it, because I'm afraid there will be silence release and we get confused about 2.0.3.0 before and after 27 May ;D

Next time, if it's not yet released/ published on OpenCart Download mark the tags on github as pre-release.
It's just simply to tick the checkbox
github-pre-release-1.png

github-pre-release-1.png (10.08 KiB) Viewed 10895 times

github-pre-release-2.png

github-pre-release-2.png (2.89 KiB) Viewed 10895 times

Assuming there is no change made, just edit and un-tick the checkbox.
If change made, delete the pre-release and create new tags to get new date release.

User avatar
Expert Member

Posts

Joined
Tue Jun 29, 2010 10:24 pm
Location - Indonesia

User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by fido-x » Mon May 25, 2015 9:07 pm

JNeuhoff wrote:You are the bug hunter of the day :)
Bug hunter of the day, eh? Cool!

What's the reward? Ooh, can I take a guess? Can I? Can I?

Is it a stable and bug-free release of OpenCart 2.0.3.0?

That would be nice!

Image
Modules for OpenCart 2.3.0.2
Homepage Module [Free - since OpenCart 0.7.7]
Multistore Extensions
Store Manager Multi-Vendor/Multi-Store management tool

If you're not living on the edge ... you're taking up too much space!


User avatar
Expert Member

Posts

Joined
Sat Jun 28, 2008 1:09 am
Location - Tasmania, Australia

Post by JAY6390 » Mon May 25, 2015 9:14 pm

fido-x wrote:Is it a stable and bug-free release of OpenCart 2.0.3.0?
Might want to aim for something a little more realistic :P

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by i2Paq » Tue May 26, 2015 12:33 am

I wonder if Heather will show her face in this topic reading all the crap we find in this and previous 2.x releases which are still NOT solved.

I almost start crying seeing what has become of OC.

Remind me what happened to Website Baker.

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by JNeuhoff » Tue May 26, 2015 3:20 am

fido-x wrote:
JNeuhoff wrote:You are the bug hunter of the day :)
Bug hunter of the day, eh? Cool!

What's the reward? Ooh, can I take a guess? Can I? Can I?

Is it a stable and bug-free release of OpenCart 2.0.3.0?

That would be nice!
I think we'll give you this trophy, well done ;D
trophy-bug-hunter.png

trophy-bug-hunter.png (32.68 KiB) Viewed 11252 times


MHC Web Design
Override Engine * Integrated VQMod * Unused Images Manager * Instant Option Price Calculator * TrustPilot Reviews * Google Rich Snippets * Google Tag Manager * Export/Import Tool * Template Switcher PHP/Twig


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am

Who is online

Users browsing this forum: No registered users and 12 guests