I want to show the instructions for bank transfer just like this but I don't know how to achieve that
Version 3.0.3.2
I want to show the instructions for bank transfer just like this but I don't know how to achieve that
I want to show the instructions for bank transfer just like this but I don't know how to achieve that
You might add some content, and also some html code like <br> <p></p> etc. to the
text_description or text_payment line:
OC_3.0.2.0/catalog/language/en-gb/extension/payment/bank_transfer.php
text_description or text_payment line:
OC_3.0.2.0/catalog/language/en-gb/extension/payment/bank_transfer.php
Code: Select all
<?php
// Text
$_['text_title'] = 'Bank Transfer';
$_['text_instruction'] = 'Bank Transfer Instructions';
$_['text_description'] = 'Please transfer the total amount to the following bank account.';
$_['text_payment'] = 'Your order will not ship until we receive payment.';My Github OC Site: https://github.com/IP-CAM
5'600 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
Completely wrong approach or solution!
Since OpenCart 3.x you can edit any language variable with the already integrated Language Editor.
Simply call that via the Menu > Language Editor.
Then hit the PLUS Button right top.
Select then the Store and the Language.
Third select in the field route this here: extension/payment/bank_transfer
Then select text_payment in the field key.
And finally add your own text in the last fields > save.
No matter how you do it (direct edit) or via the Language Editor, the moment you want to use some styling (e.g. HTML-Codes like b, color, etc.), this will work only if you edit the controller file (direct or as OCMod [preferred]):
catalog/controller/extension/payment/bank_transfer.php
There you have to insert inside the function index() after
this here:
Now your custom text with HTML-Codes are displayed correct.
Since OpenCart 3.x you can edit any language variable with the already integrated Language Editor.
Simply call that via the Menu > Language Editor.
Then hit the PLUS Button right top.
Select then the Store and the Language.
Third select in the field route this here: extension/payment/bank_transfer
Then select text_payment in the field key.
And finally add your own text in the last fields > save.
No matter how you do it (direct edit) or via the Language Editor, the moment you want to use some styling (e.g. HTML-Codes like b, color, etc.), this will work only if you edit the controller file (direct or as OCMod [preferred]):
catalog/controller/extension/payment/bank_transfer.php
There you have to insert inside the function index() after
Code: Select all
$this->load->language('extension/payment/bank_transfer');Code: Select all
$data['text_instruction'] = html_entity_decode( $this->language->get( 'text_instruction' ), ENT_QUOTES, 'UTF-8' );
$data['text_payment'] = html_entity_decode( $this->language->get( 'text_payment' ), ENT_QUOTES, 'UTF-8' );Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
You, of course, DO CAN add HTML to language files and you DO NOT need to add anything to controller to make it work.OSWorX wrote: ↑Thu Jan 30, 2020 8:04 pmNo matter how you do it (direct edit) or via the Language Editor, the moment you want to use some styling (e.g. HTML-Codes like b, color, etc.), this will work only if you edit the controller file (direct or as OCMod [preferred]):
catalog/controller/extension/payment/bank_transfer.php
Professional OpenCart extensions, support and custom work.
Contact me via email or Skype by support@thekrotek.com
Oh yes, YOU can if you want.thekrotek wrote: ↑Thu Jan 30, 2020 10:37 pmYou, of course, DO CAN add HTML to language files and you DO NOT need to add anything to controller to make it work.OSWorX wrote: ↑Thu Jan 30, 2020 8:04 pmNo matter how you do it (direct edit) or via the Language Editor, the moment you want to use some styling (e.g. HTML-Codes like b, color, etc.), this will work only if you edit the controller file (direct or as OCMod [preferred]):
catalog/controller/extension/payment/bank_transfer.php
But then you will see only something like this:
Code: Select all
This is <b>your</b> <span style="color:green">Payment Instruction</span>Guess you haven't try it before posting.
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
I'm afraid, my friend, this is YOU who haven't tried it before posting, because even default OC language files have HTML in them. For example, footer.php:
Code: Select all
$_['text_powered'] = 'Powered By <a href="http://www.opencart.com">OpenCart</a><br /> %s © %s';Professional OpenCart extensions, support and custom work.
Contact me via email or Skype by support@thekrotek.com
Guys, GUYS - let's not argue about this. The OP is using OC v3.x releases anyways which means the |format notations can be used in TWIG files which is why most of developers don't understand why language definitions are no longer used in controllers but rather used directly into TWIG files so to avoid parsing language files from PHP to prevent XSS vulnerabilities by people who understands the purpose even less while other platform developers have also considered using the same path as much as Opencart did. We're not the only ones!
To clarify both postings; Using HTML entities in language files are not good practices and editing controller core files by parsing html_entity_decode can still be achieved but requires a controller and language file to be created / edited while TWIG files already captures the language files from the controllers. There are multiple TWIG files from the core where the format notations can be referred from in order to avoid editing controller files or adding HTML codes into language files. Both answers provides different methods but also both ways can still lead to the wrong answers. Let's not forget by using html_entity_decode that .user.ini / php.ini can already handle this without the need to use a PHP function which is why it has been added in the OC package from opencart.com originally in the first place and, on the other way around, using HTML codes in language files are no longer necessary since each can be applied from theme files on anyhow.
To clarify both postings; Using HTML entities in language files are not good practices and editing controller core files by parsing html_entity_decode can still be achieved but requires a controller and language file to be created / edited while TWIG files already captures the language files from the controllers. There are multiple TWIG files from the core where the format notations can be referred from in order to avoid editing controller files or adding HTML codes into language files. Both answers provides different methods but also both ways can still lead to the wrong answers. Let's not forget by using html_entity_decode that .user.ini / php.ini can already handle this without the need to use a PHP function which is why it has been added in the OC package from opencart.com originally in the first place and, on the other way around, using HTML codes in language files are no longer necessary since each can be applied from theme files on anyhow.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Well I had, otherwise I would not post such things!thekrotek wrote: ↑Fri Jan 31, 2020 4:42 amI'm afraid, my friend, this is YOU who haven't tried it before posting, because even default OC language files have HTML in them. For example, footer.php:
So yes, it is possible to add HTML to language files. I was referring specifically to this part of your reply, where you say something about editing the controller to display HTML.Code: Select all
$_['text_powered'] = 'Powered By <a href="http://www.opencart.com">OpenCart</a><br /> %s © %s';
Here 2 images as it would be displayed (Original OC 3.0.3.2 Installation) without extra modification:
And for @straightlight:
Is heavy midleading, because since the OC 1.4.x days the language file (translation) is loaded in the controller always byused directly into TWIG files
Code: Select all
$this->load->language('extension/payment/bank_transfer');Code: Select all
$data = $this->load->language('extension/payment/bank_transfer');And before OC 3.x it was like this (sample bank_transfer):
Code: Select all
$this->load->language('extension/payment/bank_transfer');
$data['text_instruction'] = $this->language->get('text_instruction');
$data['text_description'] = $this->language->get('text_description');
$data['text_payment'] = $this->language->get('text_payment');
$data['text_loading'] = $this->language->get('text_loading');And to complete all, the twig syntax "format" is not used in any template (as fas as I know currently).
https://twig.symfony.com/doc/2.x/filters/format.html
And has has no relevance here, because here are no placeholders a sprintf would use.
Full Stack Web Developer :: Dedicated OpenCart Development & Support DACH Region
Contact for Custom Work / Fast Support.
What was meant by definition over there is the fact that users can directly call the language tag without the need to play with core controllers as mentioned above as well. Since that part was also mentioned, it is not misleading but rather informative.Is heavy midleading, because as the OC 1.4.x days the language file (translation) is loaded in the controller always by
As for the rest of your above reply, it simply describes in technical form how the theory has been explained on my previous reply regarding the $data array.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Who is online
Users browsing this forum: No registered users and 3 guests
