Post by brik » Thu Jun 02, 2016 10:19 pm

as above on a clean install of 2.2.0.0

Newbie

Posts

Joined
Thu May 19, 2016 5:34 pm

Post by florinsith » Fri Jun 03, 2016 6:55 pm

Its some module or extension that doesnt send the currecy code to format as required by opencart 2.2. Where does this happen exactly?

Image
My Extensions - SuperTheme - Opencart templates - Opencart modules


User avatar
Expert Member

Posts

Joined
Fri May 14, 2010 2:36 am


Post by dragonfly-ie » Fri Jun 03, 2016 8:37 pm

brik wrote:undefined index in currency.php lines 25, 26, 27, 30 on a clean install of 2.2.0.0
Same error here. ???

“May the best day of your past be the worst day of your future.”


User avatar
New member

Posts

Joined
Sat Nov 09, 2013 2:31 am
Location - 52°N 7°37'W

Post by i2Paq » Fri Jun 03, 2016 9:30 pm

When do you see that error?

Norman in 't Veldt
Moderator OpenCart Forums

_________________ READ and Search BEFORE POSTING _________________

Our FREE search: Find your answer FAST!.

[How to] BTW + Verzend + betaal setup.


User avatar
Global Moderator

Posts

Joined
Mon Nov 09, 2009 7:00 pm
Location - Winkel - The Netherlands

Post by brik » Sat Jun 04, 2016 11:23 pm

i2Paq wrote:When do you see that error?

Changing the status on an order from 'Processing' to 'Shipped'.

It happens on orders that are not foreign currency (ie they're in UK GBP)
It happens on about 1 in 4 or 1 in 5 orders.
Not possible to say that there's anything unique about the orders where it does happen.
After the error occurred the order processing went on and completed correctly, it sent the email out that we expected it to.

Newbie

Posts

Joined
Thu May 19, 2016 5:34 pm

Post by dragonfly-ie » Tue Jun 07, 2016 10:09 pm

I have refreshed currency values manually (system>localisation>currencies) and the error seems to have vanished. HTH.

“May the best day of your past be the worst day of your future.”


User avatar
New member

Posts

Joined
Sat Nov 09, 2013 2:31 am
Location - 52°N 7°37'W

Post by florinsith » Tue Jun 07, 2016 11:34 pm

Ive checked the default order model and all currency formats have the currency param. Maybe try the above trick d by @dragonfly-ie

Image
My Extensions - SuperTheme - Opencart templates - Opencart modules


User avatar
Expert Member

Posts

Joined
Fri May 14, 2010 2:36 am


Post by ebuild » Wed Jun 08, 2016 1:08 am

Did anyone have any luck with this. I'm still having this issue on a fresh install.

It happens after a user makes a payment.

Newbie

Posts

Joined
Wed Jun 08, 2016 12:58 am

Post by straightlight » Wed Jun 08, 2016 6:34 am

Can you provide the full path to currency.php file? Obviously, an error message wouldn't just pop-up a file name without its path.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by brik » Wed Jun 08, 2016 5:06 pm

straightlight wrote:Can you provide the full path to currency.php file? Obviously, an error message wouldn't just pop-up a file name without its path.
cart/system/library/cart/currency.php on line 30

Newbie

Posts

Joined
Thu May 19, 2016 5:34 pm

Post by pm-netti » Wed Jun 08, 2016 6:08 pm

brik wrote:
straightlight wrote:Can you provide the full path to currency.php file? Obviously, an error message wouldn't just pop-up a file name without its path.
cart/system/library/cart/currency.php on line 30
Opencart 2.2 is bug currency in method 'format' call in file catalog/contoller/account/voucher.php. You add bugs fix file:

https://github.com/pekka2/OpenCart-Migr ... .ocmod.xml

Image
- - - OpenCart Upgrade Service - - -


User avatar
Active Member

Posts

Joined
Sat Apr 07, 2012 11:22 pm
Location - Kittilä-Finland

Post by straightlight » Wed Jun 08, 2016 6:39 pm

Thanks pm-netti. It is good to know that the currencies in the 2.2.0.0 are strictly based on the store ID nowadays.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ebuild » Wed Jun 08, 2016 7:49 pm

Have installed the bugs fix file as mentioned by pm-netti and still get this after making payment through Realex sandbox:

Notice: Undefined index: in /home/customername/public_html/system/library/cart/currency.php on line 25Notice: Undefined index: in /home/customername/public_html/system/library/cart/currency.php on line 26Notice: Undefined index: in /home/customername/public_html/system/library/cart/currency.php on line 27Notice: Undefined index: in /home/customername/public_html/system/library/cart/currency.php on line 30

This error is above the line that says "Your payment has been authorised.Please click here to continue"

Any other suggestions?

Thanks.

Newbie

Posts

Joined
Wed Jun 08, 2016 12:58 am

Post by straightlight » Wed Jun 08, 2016 7:52 pm

That is because the XML modifications does not include Realex while I do agree that this module is part of the core, however.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ebuild » Wed Jun 08, 2016 8:05 pm

straightlight wrote:That is because the XML modifications does not include Realex while I do agree that this module is part of the core, however.
So should I contact Realex for an update to their code to try resolve the issue, or do you think its still a Opencart bug?

Thanks for you help.

Newbie

Posts

Joined
Wed Jun 08, 2016 12:58 am

Post by straightlight » Wed Jun 08, 2016 8:18 pm

The issue you're reporting above is with Opencart, It is not non-relative to Realex, in this case. Additional patching needs to be done over the XML in order to resolved these error lines.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by ebuild » Wed Jun 08, 2016 9:09 pm

straightlight wrote:The issue you're reporting above is with Opencart, It is not non-relative to Realex, in this case. Additional patching needs to be done over the XML in order to resolved these error lines.
Okay good to know. Hopefully someone will find a solution to the error.

Fingers crossed.

Newbie

Posts

Joined
Wed Jun 08, 2016 12:58 am

Post by straightlight » Thu Jun 09, 2016 12:18 am

Fingers can now be stopped to be crossed: http://forum.opencart.com/viewtopic.php?f=191&t=163674

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON

Post by dragonfly-ie » Sun Jun 19, 2016 12:03 am

@straightlight et al: Is there a fix to stop WARNING on front page with SSL?
The page at https://yoursite.com/ contains a form which targets an insecure URL http://yoursite.com/common/currency/currency.

line 41 index-page: <form action="http://yoursite.com/common/currency/currency" method="post" enctype="multipart/form-data" id="form-currency">

“May the best day of your past be the worst day of your future.”


User avatar
New member

Posts

Joined
Sat Nov 09, 2013 2:31 am
Location - 52°N 7°37'W

Post by straightlight » Sun Jun 19, 2016 9:35 am

dragonfly-ie wrote:@straightlight et al: Is there a fix to stop WARNING on front page with SSL?
The page at https://yoursite.com/ contains a form which targets an insecure URL http://yoursite.com/common/currency/currency.

line 41 index-page: <form action="http://yoursite.com/common/currency/currency" method="post" enctype="multipart/form-data" id="form-currency">
It has been known that the currency from forms may not redirect to its target due to a hidden input form which most of web providers these days may decline due to CSRF vulnerabilities. It is also not in common programming practice to generically assign a post URL as a hidden field from an HTML form to redirect the browser to another location.

I can, however, recommend the use of the CSRF protection form to see if that will solved the issue. It is also compatible over SSL but not yet tested on TLS encryption.

Contribution: http://www.opencart.com/index.php?route ... on_id=4773

Take note that this contribution does not reflect on any Opencart version since it is a globalized library. The only difference on its integration is with the new nowadays functionality of Opencart v2.2.0.0 and above into the framework but is still NOT an obligation to integrate it globally into your store as I do rather recommend that you initiate this library directly into your catalog/controller/common/currency.php file into the index() method. Then, as per my documentation indicates, to add the echo line right below the: <form tag line into your catalog/view/theme/<your_theme>/template/common/currency.tpl file.

Afterwards, clear out your cache navigation. Close the browser, re-open the browser and see if that solves the issue.

The most generated errors being found on Opencart forum originates from contributed programming. The increased post counters are caused by redundancies of the same solutions that were already provided prior.


Regards,
Straightlight
Opencart.com Administrator / Quality Assurance Analyst / Programmer / Opencart Tester


Legendary Member

Posts

Joined
Mon Nov 14, 2011 11:38 pm
Location - Canada, ON
Who is online

Users browsing this forum: No registered users and 4 guests