Post by hendrachristian » Mon Mar 14, 2016 9:11 pm

I posted the following few days ago
https://github.com/opencart/opencart/issues/4102
Daniel did a commit and thought he fixed the issue and close the thread.
I have since added some comments regarding the issue because it's not yet fixed.

How do I re-open that thread? Or should I submit a new issue?

------------------------------------
Hendra
https://www.primanada.com


User avatar
New member

Posts

Joined
Mon Mar 23, 2015 4:34 pm
Location - Jakarta, Indonesia

Post by budgetneon » Mon Mar 14, 2016 9:19 pm

hendrachristian wrote:I posted the following few days ago
https://github.com/opencart/opencart/issues/4102
Daniel did a commit and thought he fixed the issue and close the thread.
I have since added some comments regarding the issue because it's not yet fixed.

How do I re-open that thread? Or should I submit a new issue?
He made another commit yesterday: https://github.com/opencart/opencart/co ... 3e696f38fc

I would download the latest and create a new issue if the problem still exists. Daniel's not likely watching closed issues.

New member

Posts

Joined
Sat Sep 20, 2014 11:32 pm


Post by hendrachristian » Mon Mar 14, 2016 10:04 pm

budgetneon wrote:
hendrachristian wrote:I posted the following few days ago
https://github.com/opencart/opencart/issues/4102
Daniel did a commit and thought he fixed the issue and close the thread.
I have since added some comments regarding the issue because it's not yet fixed.

How do I re-open that thread? Or should I submit a new issue?
He made another commit yesterday: https://github.com/opencart/opencart/co ... 3e696f38fc

I would download the latest and create a new issue if the problem still exists. Daniel's not likely watching closed issues.
yup, I just saw that minutes after I posted this thread. I'll check that out for sure. Looks like he committed a number of changes to url.php and related files. I've also added my comment to reflect this on GitHub.

Thanks.

------------------------------------
Hendra
https://www.primanada.com


User avatar
New member

Posts

Joined
Mon Mar 23, 2015 4:34 pm
Location - Jakarta, Indonesia

Post by hendrachristian » Mon Mar 14, 2016 10:34 pm

couldn't wait so I tested the fixes in latest branch and it works now as expected.

I do find another issue w/ Admin > System > Localisation > Language though. The screen is different from the docs http://docs.opencart.com/system/localisation/language/ and adding a Language is now more cumbersome because have to INSERT directly from DB. (No way to add Code, Directory, Image in this version from the Admin area)

------------------------------------
Hendra
https://www.primanada.com


User avatar
New member

Posts

Joined
Mon Mar 23, 2015 4:34 pm
Location - Jakarta, Indonesia

Post by budgetneon » Mon Mar 14, 2016 10:56 pm

hendrachristian wrote:couldn't wait so I tested the fixes in latest branch and it works now as expected.

I do find another issue w/ Admin > System > Localisation > Language though. The screen is different from the docs http://docs.opencart.com/system/localisation/language/ and adding a Language is now more cumbersome because have to INSERT directly from DB. (No way to add Code, Directory, Image in this version from the Admin area)
I think that may be on purpose. Since the directories are supposed to be like "en-gb" now instead of "english", the assumption is that the image will be "en-gb.png".

See here, for example: https://github.com/opencart/opencart/bl ... age.tpl#L8

Code: Select all

 <img src="catalog/language/<?php echo $language['code']; ?>/<?php echo $language['code']; ?>.png" alt="<?php echo $language['name']; ?>" title="<?php echo $language['name']; ?>">
    <?php } ?>
It looks like the intention is that people creating language packs will follow a more rigid naming process, which eliminates the need for the other fields. Code is driven by the directory name, as is image, etc.

New member

Posts

Joined
Sat Sep 20, 2014 11:32 pm


Post by hendrachristian » Thu Mar 17, 2016 1:12 pm

budgetneon wrote: I think that may be on purpose. Since the directories are supposed to be like "en-gb" now instead of "english", the assumption is that the image will be "en-gb.png".

See here, for example: https://github.com/opencart/opencart/bl ... age.tpl#L8

Code: Select all

 <img src="catalog/language/<?php echo $language['code']; ?>/<?php echo $language['code']; ?>.png" alt="<?php echo $language['name']; ?>" title="<?php echo $language['name']; ?>">
 <?php } ?>
It looks like the intention is that people creating language packs will follow a more rigid naming process, which eliminates the need for the other fields. Code is driven by the directory name, as is image, etc.
Yeah I guess you're right. I respect the idea of improving the naming process. Just hope that it was documented properly so people don't need to delve into the code to postulate what the developer team are trying to do.

------------------------------------
Hendra
https://www.primanada.com


User avatar
New member

Posts

Joined
Mon Mar 23, 2015 4:34 pm
Location - Jakarta, Indonesia
Who is online

Users browsing this forum: No registered users and 37 guests