Post by jonghwa » Fri Dec 07, 2012 2:57 pm

hi,

i'm not sure if it was intended or not.

i found the codes like:

Code: Select all

if ($zone_info)
isn't it better if we change the code like this:

Code: Select all

if (isset($zone_info))
i see lots of warnings when debugging. i don't know opencart team code convention rule, but i hope you find a way to reduce printing errors.

Thank you.

핀코인 (http://pincoin.co.kr)

extensions by pincoin


User avatar
New member

Posts

Joined
Thu Oct 25, 2012 12:29 pm
Location - Seoul

Post by Daniel » Sun Dec 09, 2012 2:10 pm

on which page? does not happen to me.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by jonghwa » Mon Dec 10, 2012 12:41 pm

Daniel wrote:on which page? does not happen to me.

it actually occurs when i remove "geo zone id" required field. i might not happen if you don't remove the required field.

my php warning level is "notice", so i saw some warning messages:

Code: Select all

PHP Notice:  Undefined index: comment in /home/pincoin/upload/catalog/controller/checkout/shipping_method.php on line 151
PHP Notice:  Undefined index: comment in /home/pincoin/upload/catalog/controller/checkout/payment_method.php on line 192
it seems to be the same issue. it is a very tiny issue, but i just wanted to remind you.

thank you for your contribution.

핀코인 (http://pincoin.co.kr)

extensions by pincoin


User avatar
New member

Posts

Joined
Thu Oct 25, 2012 12:29 pm
Location - Seoul
Who is online

Users browsing this forum: No registered users and 13 guests