OpenCart Community

• Removed all the duplicate posts
• Removed all the non-bugs
• Removed all the upgrade confusions
• Removed all the off topic commentary

Johnathan wrote:The customer form IP list needs to be changed from a 3 colspan to a 4 colspan when there are no results:

IN:
/admin/view/template/sale/customer_form.tpl

REPLACE:
colspan="3"

WITH:
colspan="4"

kpeu3u wrote:Hello,
i get an Warning error at admin page when i make a copy of product.

1. FIX:
Open to edit: /admin/controller/catalog/product.php
2. FIND:

Code: Select all

if (isset($this->request->get['filter_name'])) {
				$url .= '&filter_name=' . urlencode(html_entity_decode($this->request->get['filter_name']), ENT_QUOTES, 'UTF-8');
			}
		
			if (isset($this->request->get['filter_model'])) {
				$url .= '&filter_model=' . urlencode(html_entity_decode($this->request->get['filter_model']), ENT_QUOTES, 'UTF-8');
			}

3. REPLACE WITH:

Code: Select all

if (isset($this->request->get['filter_name'])) {
				$url .= '&filter_name=' . urlencode(html_entity_decode($this->request->get['filter_name'], ENT_QUOTES, 'UTF-8'));
			}
		
			if (isset($this->request->get['filter_model'])) {
				$url .= '&filter_model=' . urlencode(html_entity_decode($this->request->get['filter_model'], ENT_QUOTES, 'UTF-8'));
			}

Johnathan wrote:Just found a bug that has apparently existed since at least 1.4.1:

When deleting a category in the admin panel, it doesn't delete any data in the product_to_category table, which means functions like getProductCategories() return values that no longer exist. If you're using this data to determine something based on the categories to which the product belongs, it can mess up the results.

The fix should just be a one-line database query added to the /admin/model/catalog/category.php file in the deleteCategory() function.

Also, just so I don't lose it, the database query I worked out to fix this issue for someone is as follows:

Code: Select all

DELETE FROM product_to_category WHERE NOT EXISTS (SELECT * FROM category WHERE category_id = product_to_category.category_id)

Use at your own risk.

ccM wrote:Has anyone tested their gift voucher purchase since r973? The update changed this

Code: Select all

 $this->data['amount'] = '25.00';

to

Code: Select all

$this->data['amount'] = $this->currency->format(25);

On a clean install of 1.5.2.1 plus latest patch I am getting $25.00 entered in to the amount field (including the dollar sign) which it won't accept when submitting the form.

$this->currency->format(25);

$this->currency->format(25, $this->config->get('config_currency'), false, false);

moneycarlo wrote:I just upgraded to 1.5.2.2 and noticed when I went into the Admin to edit an order, I received an error:

Use of undefined constant HTTPS_CATALOG - assumed 'HTTPS_CATALOG' in /admin/controller/sale/order.php on line 756

I then went into the admin/config.php and added the HTTPS_CATALOG entry into the HTTPS section and it got rid of the error.

Code: Select all

define('HTTPS_CATALOG', 'https://www.domain.com/');

Here's to hoping that was the right move

JNeuhoff wrote:I think the following code in catalog/controller/product/product.php should be chnged from

Code: Select all

					foreach ($option['option_value'] as $option_value) {
						if (!$option_value['subtract'] || ($option_value['quantity'] > 0)) {
							.....

to

Code: Select all

					foreach ($option['option_value'] as $option_value) {
						if (!$option_value['subtract'] || ($option_value['quantity'] > 0) || ($this->config->get('config_stock_checkout'))) {
							.....

because we still want to see out of stock options on the product page when the 'Stock Checkout' in the store settings is set to 'Yes', that is, allow customers to still checkout if the products they are ordering are not in stock.

JNeuhoff wrote:In file admin/model/report/sale.php, in function getTotalTaxes, the following line

Code: Select all

		if (!is_null($data['filter_order_status_id'])) {

should be replaced with

Code: Select all

		if (!empty($data['filter_order_status_id'])) {

as is the case in function getTaxes.

The same bug exists in the functions getShipping and getTotalShipping.

The same bug also exists in the file admin/model/report/customer.php, for the functions getOrders and getTotalOrders.

has been done for a while on the svn.


The $data['filter_order_status_id'] is never null, but it can have the value '0', meaning to include all order statuses into the resulting list.