Page 2uksitebuilder wrote:Sorry but I dont see iPod Classic repeated on the link you gave above ?
Celestial - Martín Abel Rosales
WhatsApp: 50671482211
Email: martinrosales2012@hotmail.com
Skype: martin.abel.rosales
San José , Costa Rica
I get different products each time I look, but I think I see what you are referring to.
Just tested by opening page 2 in a new tab and you are correct. Thanks for the heads-up
In system/library/cart.php the getProducts() method checks if the product is in stock or not. There are 3 stock checks in this method, the first two are related to the stock of Product Options, the last one is for the Product. The Product Options checks ignore the Product Option's stock if "Subtract Stock" is false, however the Product check doesn't.
The 3 checks in question are
1. Radio Options
Code: Select all
Line 66: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
Code: Select all
Line 111: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
Code: Select all
Line 213: if (!$product_query->row['quantity'] || ($product_query->row['quantity'] < $quantity)) {
In most cases I would imagine that if decrease stock is set to false, stock should be ignored.
Thanks,
Simon
Johnathan wrote:Yeah, I just noticed that it's a different duplicated product every time.uksitebuilder wrote:Very weird behaviour.
I get different products each time I look, but I think I see what you are referring to.
Just tested by opening page 2 in a new tab and you are correct. Thanks for the heads-up
can not replicate. one is an ipod nqano and another is the ipod classic
OpenCart®
Project Owner & Developer.
this is a bug thread and not a thread for how you want opencart changed to suite your needs.strigona wrote:I found an inconsistency with regards to how a product is considered "Out of Stock".
In system/library/cart.php the getProducts() method checks if the product is in stock or not. There are 3 stock checks in this method, the first two are related to the stock of Product Options, the last one is for the Product. The Product Options checks ignore the Product Option's stock if "Subtract Stock" is false, however the Product check doesn't.
The 3 checks in question are
1. Radio Options2. Select OptionsCode: Select all
Line 66: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
3. Product StockCode: Select all
Line 111: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
Personally for how I'm managing the stock in my store I want to be able to set an upper limit of the number of items to put into the cart but not decrease the stock so I will be changing the Product Options' conditions to look like the Product Stock condition.Code: Select all
Line 213: if (!$product_query->row['quantity'] || ($product_query->row['quantity'] < $quantity)) {
In most cases I would imagine that if decrease stock is set to false, stock should be ignored.
Thanks,
Simon
OpenCart®
Project Owner & Developer.
I would consider the inconsistency a bug. I mearly suggested the two possibile solutions and how each can be useful. I have made the changes that I want to my store already. I'm posting here so that the next person who comes across this bug doesn't waste an hour figuring out why the decrease stock feature acts completly different in two locations.Daniel wrote:this is a bug thread and not a thread for how you want opencart changed to suite your needs.strigona wrote:I found an inconsistency with regards to how a product is considered "Out of Stock".
In system/library/cart.php the getProducts() method checks if the product is in stock or not. There are 3 stock checks in this method, the first two are related to the stock of Product Options, the last one is for the Product. The Product Options checks ignore the Product Option's stock if "Subtract Stock" is false, however the Product check doesn't.
The 3 checks in question are
1. Radio Options2. Select OptionsCode: Select all
Line 66: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
3. Product StockCode: Select all
Line 111: if ($option_value_query->row['subtract'] && (!$option_value_query->row['quantity'] || ($option_value_query->row['quantity'] < $quantity))) {
Personally for how I'm managing the stock in my store I want to be able to set an upper limit of the number of items to put into the cart but not decrease the stock so I will be changing the Product Options' conditions to look like the Product Stock condition.Code: Select all
Line 213: if (!$product_query->row['quantity'] || ($product_query->row['quantity'] < $quantity)) {
In most cases I would imagine that if decrease stock is set to false, stock should be ignored.
Thanks,
Simon
So for the sake of future opencart users please consider this a bug.
Thanks,
Simon
its like playing a guessing game. read carefully what you have writen. it tells us nothing apart from you think there is inconsistency.
OpenCart®
Project Owner & Developer.
Sorry Daniel, I'll re-explain - sorry if I wasn't clear enough earlier.Daniel wrote:you have not even reported what is actually not happening and what is supposed to happen.
its like playing a guessing game. read carefully what you have writen. it tells us nothing apart from you think there is inconsistency.
The inconsistency is that for a Product if the "Decrease Stock" is set to "No", the cart quantity cannot exceed the product quantity. For Product Options if the "Decrease Stock" is set to "No", the cart quantity can exceed the product option quantity.
Any news regarding the Update issue?
It would be nice if you could clarify the position on that one, there is probably some users who have begun to enter a lot of products in the current OC release 1.5.0.5 and given that 1.5.0.6 is around the corner so you have to wonder how to upgrade and if it is safe. Hope you understand. Thank you!Can we just upload the install folder and run through the installer again?
Or will that mess up the database? Are you planning on making an upgrade script from 1.5.0.5 to whatever the next version is you're planning on releasing?
I think Q is back from his holiday now.Daniel wrote:i was thinking of releasing 1.5.1. there is one db change at the moment. it might be an idea to wait for Q to come back from his holidays.
I'm glad you're going to number it 1.5.1 if there's a database change. It'll help those of us with extensions support entire point releases (such as 1.5.0.x) at once.
Yep, he is already back.Daniel wrote:i was thinking of releasing 1.5.1. there is one db change at the moment. it might be an idea to wait for Q to come back from his holidays.
make sure you change the version in the \admin\index.php to reflect the correct version please.
Norman in 't Veldt
Moderator OpenCart Forums
_________________ READ and Search BEFORE POSTING _________________
Our FREE search: Find your answer FAST!.
[How to] BTW + Verzend + betaal setup.
Great! Given there is one db change at the moment, will you attach some upgrade instructions or is it safe to upgrade from 1.5.0.5 to 1.5.1 ?i was thinking of releasing 1.5.1. there is one db change at the moment. It might be an idea to wait for Q to come back from his holidays.
umm make your banner smaller. I would not call that a bug. Images always push the design around if you make them too big.reynierpm wrote:Sorry if this isn't a bug but also a problem. When I have a banner and I have content or modules enabled the banner image broken the design. See the image at this link http://www.dropmocks.com/mXL7a, Any solve this?
OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter
Users browsing this forum: No registered users and 118 guests