Post OpenCart 1.4.4 Bugs Here!

working on it now. going to try to get a release out monday. i'm just solly working on oc at the moment.

Found a bug, here goes:

Step 1: Add something to your cart and then register
Step 2: On the account/success page you get instead of clicking continue click checkout in the header
Step 3: You'll notice your address doesn't have the radio button checked.
Step 4: Click continue underneath that and you'll get lots of errors about undefined indexes in \checkout\address.php


Now while this is stupidity on the users parts (for not clicking continue and/or checking the radio button), either the radio button should be set or throw up an error saying please select an address.

Google Sitemap have a wrong:

"XML parsing error: not well-organized
Location: http://www.yourdomain.com/index.php?rou ... le_sitemap
Line: 1, Column: 176:"

why?

Hello Daniel,
I am testing v1.44 and found another bug: I added a product in admin and insert some pics, it showed successed in admin. but when i check in the front, the pics don't show. is this a bug?

Jacob_chan wrote:

Daniel wrote:working on it now. going to try to get a release out monday. i'm just solly working on oc at the moment.

Dear Daniel,thanks for your great work! though there are still some bugs, i think everybody should appreciated your hard working. Now, very few modules works on OC 1.44, maybe when the OC is steadable enough, people who skill the coding will fix and release some new modules which work fine on new version OC. am i right?

You are talking about third party modules. If they are still suported by their builders: yes.

Jacob_chan wrote:Hello Daniel,
I am testing v1.44 and found another bug: I added a product in admin and insert some pics, it showed successed in admin. but when i check in the front, the pics don't show. is this a bug?

No.

i2Paq wrote:

Jacob_chan wrote:Hello Daniel,
I am testing v1.44 and found another bug: I added a product in admin and insert some pics, it showed successed in admin. but when i check in the front, the pics don't show. is this a bug?

No.

How is this not a bug?

Johnathan wrote:

i2Paq wrote:

Jacob_chan wrote:Hello Daniel,
I am testing v1.44 and found another bug: I added a product in admin and insert some pics, it showed successed in admin. but when i check in the front, the pics don't show. is this a bug?

No.

How is this not a bug?

Because no-one has this problem.

What do you see when you do a right-mouse-click on the images and past the path of that image in your browser?

Correct. It is not a bug. More likely you forgot to choose which stores it will be visible on. Or the www vs non-www issue is causing it. Or you are missing the / in the store url

hottiger wrote:Found a bug, here goes:

Step 1: Add something to your cart and then register
Step 2: On the account/success page you get instead of clicking continue click checkout in the header
Step 3: You'll notice your address doesn't have the radio button checked.
Step 4: Click continue underneath that and you'll get lots of errors about undefined indexes in \checkout\address.php


Now while this is stupidity on the users parts (for not clicking continue and/or checking the radio button), either the radio button should be set or throw up an error saying please select an address.

chekc that you don;t have approve account set to on. i have followed your steps but they don;t make sense.

Because no-one has this problem.

What do you see when you do a right-mouse-click on the images and past the path of that image in your browser?

Yes, it's not a bug,problem sloved! thank you all!

Redirect error

/catalog/controller/account/login.php
Line 31 fix

It looks like the wrong quantities are being returned for all getTotal[whatever] functions in /catalog/model/catalog/product.php causing only one page to be generated for more than 12 products. I believe
should be

rph wrote:Redirect error

/catalog/controller/account/login.php
Line 31

Code: Select all

$this->redirect($this->request->post['redirect']);

fix

Code: Select all

$this->redirect(str_replace('&', '&', $this->request->post['redirect']));

thx!

rph wrote:It looks like the wrong quantities are being returned for all getTotal[whatever] functions in /catalog/model/catalog/product.php causing only one page to be generated for more than 12 products. I believe

Code: Select all

			if ($query->num_rows) {
				return $query->row['total'];	
			} else {
				return 0;
			}

should be

Code: Select all

			if ($query->num_rows) {
				return $query->num_rows;	
			} else {
				return 0;
			}

thansk for letting me know this. i have added the fixes in the next release already.

jayson wrote:

Daniel wrote:

allenshea wrote:What should I do with "Approve" in customer, should I Approve all the customer here?

But when I try to Approve customer, I got

Code: Select all

Error: E-Mail sender required!

is this a bug?

I think my mail works, I can got info of Update Order and New Customer mail(added some code in create.php). But I can not got new order, Why?

Thanks,

Allen

tjhat is a bug i need to fix.

Hallo Daniel,

Thanks for the wonderful job. I know this has already been asked previously, in any case just wondering if
you had already made this minor fixed...

I have already added a fix for the 1.4.5 version. it will be out soon. I have done a lot of work over the weekend to get OC bug free.

Daniel wrote:

hottiger wrote:Found a bug, here goes:

Step 1: Add something to your cart and then register
Step 2: On the account/success page you get instead of clicking continue click checkout in the header
Step 3: You'll notice your address doesn't have the radio button checked.
Step 4: Click continue underneath that and you'll get lots of errors about undefined indexes in \checkout\address.php


Now while this is stupidity on the users parts (for not clicking continue and/or checking the radio button), either the radio button should be set or throw up an error saying please select an address.

chekc that you don;t have approve account set to on. i have followed your steps but they don;t make sense.

Approve account wasn't set to on. I'm not sure why my steps don't make sense?

the don't send the people "your account appoved" mail!

Daniel wrote:the don't send the people "your account appoved" mail!

Sorry but that sentence makes absolutely no sense to me! I don't understand what you're trying to say

There are some inconsistencies in the way a customer's e-mail is validated.

The DB field customer.email is declared as varchar(96) yet the validate function in the files admin/controller/sale/customer.php, /catalog/controller/account/edit.php always tests a for maximum length of no more than 32 characters, while in the /catalog/controller/account/create.php the validate omits a check for a proper maximum length altogether.

The same inconsistency appears to be in OpenCart 1.3.4 or 1.4.0, possibly in other versions, too.