Post by JNeuhoff » Thu Aug 11, 2011 8:40 pm

This modification of the Paypal payment module makes sure that the discount (reward+credit+coupon+voucher), shipping, handling, low-order-fee and tax are passed on to Paypal as separate entries and then shown as such on the Paypal gateway. If the discount is not less than the sub-total then only the grand total is passed on to Paypal with the store-name and invoice number as the item name.

Attachments

Paypal Standard payment module fixes for Opencart 1.5.1.1


Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Qphoria » Thu Aug 11, 2011 9:29 pm

Great. if this works we should go ahead and add it to the core file

Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Maansy » Fri Aug 12, 2011 6:34 am

Thanks
I will take it for a spin.

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by Maansy » Fri Aug 12, 2011 10:11 am

Note: testing coupons only. not tax, shipping or gv
in Paypal it shows this:

Code: Select all

Your order summary
DescriptionsAmount

            Product5 $54.95
            Item number: product_5
            Item price: $54.95
            Options: Website: test.com
            Quantity: 1
    Discount -$53.95

    Item total $1.00

    Total $1.00 USD
seems working for coupons ;)

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by Maansy » Fri Aug 12, 2011 10:41 am

test2
i added gv, tax, shipping to the coupon and this is what i got in step 6 before it lunches to paypal:

Price Total

$54.95 $54.95
Voucher(121212): $0.00 <----- it should show $2.00. maybe it was ignored since a coupon applied
Sub-Total: $54.95
Flat Rate: $1.00
Coupon(crafty): $-1.95
VAT 17.5%: $9.45 <--------not showing in paypal
Total: $63.45 <--------Total is different in paypal


in paypal i got this:

Your order summary
DescriptionsAmount
Product5 $54.95

Item number: product_5
Item price: $54.95
Options: Website: test.com
Quantity: 1
Flat Rate Item price: $1.00
Quantity: 1
Discount -$1.95

Item total $54.00

Total $54.00 USD

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by JNeuhoff » Fri Aug 12, 2011 5:46 pm

Strange, I am unable to reproduce your error. I just tested it with both a voucher and a coupon, and 2 taxable products and taxable shipping costs, and it worked just fine. Both discounts were applied as expected. And the tax showed up in Paypal as expected (I am using the 'tax_cart' variable for this). Do you have a URL where I can see this error and try it out? I'd like to see it in Firefox's Firebug, especially the exact hidden variables list before its sent off to Paypal.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Maansy » Fri Aug 12, 2011 9:18 pm

i tested it on a 2nd store and here is the results. 100% working correctly

Attachments

pp_paypal_standerd.png

pp_paypal_standerd.png (59.42 KiB) Viewed 12182 times

Last edited by Maansy on Sat Aug 13, 2011 12:36 am, edited 1 time in total.

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by Maansy » Fri Aug 12, 2011 9:42 pm

and here when i tested it on the 1st store
notice that in store GV is 0.00. It should be -$2.00
tax is not transferred to paypal.

Attachments

pp_paypal_standerd2.png

pp_paypal_standerd2.png (21.4 KiB) Viewed 12180 times

Last edited by Maansy on Sat Aug 13, 2011 12:38 am, edited 4 times in total.

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by Maansy » Fri Aug 12, 2011 9:45 pm

now which files are involved in here so i can fix the 1st store?

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by JNeuhoff » Fri Aug 12, 2011 11:05 pm

You are not providing enough details of your error, I am unable to reproduce your error. Judging by the screenshots, your are not using a standard Opencart 1.5.1.1 checkout.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Maansy » Sat Aug 13, 2011 12:30 am

J
The 1st screenshot is ok. Everything was meant to transit, went fine. All data was sent to paypal.
The 2nd screenshot is another store. Seems like gv didn't add to total. In paypal, tax is missing.

My question is, which files involve in the whole checkout process so I can backup the store with these files?

Another thing. in the back end, I know there are 14 order status. I only see 11 in the drop down.

Thanks

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by JNeuhoff » Sat Aug 13, 2011 12:39 am

My vQmod XML file modifies the Opencart core files

catalog/controller/payment/pp_standard.php
catalog/view/theme/default/template/payment/pp_standard.tpl

As regards your second screenshot: Can you reproduce the same error when you use the standard Opencart 1.5.1.1 web theme?

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by uksitebuilder » Sat Aug 13, 2011 2:27 am

Maansy wrote:i tested it on a 2nd store and here is the results. 100% working correctly
On the post above with the black background


the tax is out by 0.01

User avatar
Guru Member

Posts

Joined
Thu Jun 09, 2011 11:37 pm
Location - United Kindgom

Post by Maansy » Sat Aug 13, 2011 2:29 am

uksitebuilder wrote:
Maansy wrote:i tested it on a 2nd store and here is the results. 100% working correctly
On the post above with the black background


the tax is out by 0.01
yep i noticed that. is it paypal or store effecting that. 0.01 is not that big of a deal IMHO

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by Maansy » Sat Aug 13, 2011 4:17 am

here you go. i did 2 tests with and with out your mod in the store that had an issue with it before.

this mod works fine in one store, but for some reason it doesnt work correctly on another store.
now i cant tell why GV do show the correct amount instead it shows 0.00
it says "Success: Your gift voucher discount has been applied!" after i apply the GV but it still shows $0.00.
knowing that after i disable tax and shipping (in product, store and module) now GV shows fine and your mod works again. hmmmmm
my head is spinning. :crazy:

Attachments

pp_paypal_standerd4.png

pp_paypal_standerd4.png (105.49 KiB) Viewed 12218 times


ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by JNeuhoff » Sat Aug 13, 2011 5:58 am

Below is what I get with bugfixes-pp-standard.xml. As I said, I am unable to reproduce your error unless you can give me access to your store URL so I can replicate your error.

Attachments

screenshot-paypal.png

screenshot-paypal.png (4.9 KiB) Viewed 12209 times

screenshot-confirm-order-gbp1.png

screenshot-confirm-order-gbp1.png (8.61 KiB) Viewed 12209 times


Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by Maansy » Sat Aug 13, 2011 7:56 am

i backed up all the pp_standard files front/back end. now its working fine :)
that's weird cuz i never altered any of these files before :ponder:

now this fix should be added to the core :)

ALL Templates :: 1.5.1+ Templates :: 50%-75% PRICE DROP ONLY at OpencartStuff.com


User avatar
Active Member

Posts

Joined
Thu Jun 24, 2010 6:04 am


Post by CanadaPleco » Sat Sep 24, 2011 2:40 am

The fixes are not working for me. Always brings up paypal screen with $0.00 from different computers and what not as well. I have re-uploaded all the core paypal files and still nothing.
Screen shot 2011-09-23 at 2.36.20 PM.png

Screen shot 2011-09-23 at 2.36.20 PM.png (45.15 KiB) Viewed 12014 times


New member

Posts

Joined
Sat Aug 20, 2011 1:06 am

Post by markman-b » Tue Oct 11, 2011 9:38 pm

Thanx for the vQmod.

Any idea if you can fix this problem: http://forum.opencart.com/viewtopic.php?f=113&t=40181

by moderating your vQmod?

OC version 1.5.4.1


Active Member

Posts

Joined
Wed Aug 24, 2011 7:13 pm

Post by JNeuhoff » Tue Oct 11, 2011 10:26 pm

markman-b wrote:Thanx for the vQmod.

Any idea if you can fix this problem: http://forum.opencart.com/viewtopic.php?f=113&t=40181

by moderating your vQmod?
There are a number of rounding issues with OpenCart, I reported a similar bug here, but it was never picked by Daniel or Q, as far I know the rounding bug is still there, might be worth testing it again in 1.5.1.3.

Export/Import Tool * SpamBot Buster * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Tag Manager * Survey Plus * OpenTwig


User avatar
Guru Member
Online

Posts

Joined
Wed Dec 05, 2007 3:38 am

Who is online

Users browsing this forum: No registered users and 16 guests