Page 4 of 5

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Sun Mar 04, 2012 3:54 am
by Xsecrets
alex1 wrote:Will this work with 1.5.2? I just downloaded 1.5.2 and want to make sure before I install and modify the module. thanks!
Well considering I did not even know that 1.5.2 had been released and this module makes tons of changes it is VERY unlikely that it will work with 1.5.2. I will update it, but I'm very busy. I would say it will be at least a month to get it updated depending on how big the changes for 1.5.2 are.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Sun Mar 04, 2012 7:00 am
by alex1
Qphoria says there should be no module changes necessary... can you confirm? would be great, so we can build the 1.5.2 site

thanks

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Sun Mar 04, 2012 7:09 am
by Xsecrets
This is not some simple standard module. It modifies basically every single database query in the store, so while I haven't tested yet I would be comfortable betting it won't work.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Wed Mar 07, 2012 12:23 pm
by alex1
Ok, please let us know, thanks.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Wed Mar 07, 2012 1:13 pm
by Xsecrets
I just posted an update earlier tonight.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Sat Mar 31, 2012 12:50 am
by alex1
Confirming this works with the latest patch (1.5.2.2)

thanks

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu Apr 05, 2012 9:12 pm
by alex1
yes/no? :)

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu Apr 05, 2012 10:02 pm
by Xsecrets
don't know haven't had time to test it, but I don't think the patch should break anything.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Tue Apr 10, 2012 8:22 pm
by budgieoc18
Can Someone help me out with this problem...

Assume I have a product "Oil Filter" which has the Part Number "ABC123"
This is stored in my product table with the product_id "1"
This product would fit many vehicles, for example Chevrolet Aveo 1.6 and Chevrolet Neon 1.4

This would be represented in my product_ymm import file as:
product_id|make|model|begin_year|end_year|engine
1|Chevrolet|Aveo|2004|2007|1.6
1|Chevrolet|Neon|2005|2009|1.4

My problem is that both of those cars may have different fitment detail for the same product_id.
For example the part may only fit the Aveo with Automatic Transmission and the Neon with Manual Transmission. This scenario is not possible to represent in the current module. I would propose the following design to the product_ymm import:

product_id|make|model|begin_year|end_year|engine|application_fitment_detail
1|Chevrolet|Aveo|2004|2007|1.6|w/Automatic Transmission
1|Chevrolet|Neon|2005|2009|1.4|w/Automatic Transmission

Would it be possible to enhance the module to be able to handle this scenario?

Thank you in advance.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Tue Apr 10, 2012 9:22 pm
by Xsecrets
well yes that can be done. Problem is that it is not an easy or quick thing to do. The mod is not designed to add additional filters.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Fri May 04, 2012 10:43 pm
by alex1
Sent you two emails about a question, but haven't heard back... please check your email :)

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Mon May 14, 2012 5:14 am
by alex1
guess not :)

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Mon May 14, 2012 5:23 am
by Xsecrets
yeah sorry I've just been really busy lately, and unfortunately no I do not have time right now to port this mod back to the 1.4.9 series.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu May 24, 2012 12:44 pm
by alex1
Can you confirm this works with 1.5.3? Thank you

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu May 24, 2012 1:01 pm
by Xsecrets
I haven't had a chance to look at 1.5.3 yet. It will probably be this weekend before I get a chance to look at it and test my mods.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu May 24, 2012 10:09 pm
by winklab
If you can confirm this works for 1.5.3, you will have two things...

1) A new customer.
2) A REALLY grateful customer.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Thu May 24, 2012 10:32 pm
by Xsecrets
Well as I said I won't have time to look at it till this weekend, but I can tell you it will be made to work with 1.5.3 if it does not already.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Mon May 28, 2012 10:15 pm
by Xsecrets
Tested the mod and everything works fine with 1.5.3.1 using the existing 1.5.2 files.

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Wed May 30, 2012 1:21 pm
by alex1
Found a bug.

Have a product with fitment of:

Make Model Engine 2000 to 2005
Make Model Engine1 2002 to 2004
Make Model Engine2 2000 to 2005
Make Model Engine3 2000 to 2005

When selecting Make Model Engine1, I get year ranges for all of them, it should only be for 2002 to 2004.

How can I update the code to fix this so I don't need to redownload?

thanks

Re: [Released][Commercial] Vehicle Year/Make/Model Filter mo

Posted: Wed May 30, 2012 2:06 pm
by Xsecrets
well it's not so much a bug as a design limitation. You'll notice that the year actually becomes available when you choose the model. This is because the engine is not required and can be turned off. You would have to add the engine to the query for the years and change up the javascript to trigger when the engine is selected instead of when the model is selected.