OpenCart Community

storm-cloud wrote:Ryan, could you clarify why this method would be considered sloppy code? Is it bad practice to call these attributes within a model/tool file?

<img src="<?php echo $thumb; ?>" width="<?php echo $width; ?>" height="<?php echo $height; ?>" alt="<?php echo $heading_title; ?>" />

http://store.com/image/cache/data/image-60x60.jpg

http://store.com/image/cache/data/image-60x60.jpg" width="60" height="60

rph wrote:The potential problem is if there's an error in the template and the closing double-quote is missing or there's some non-template area of the cart using the ModelToolImage class (such as a custom feed). Also any non-resized images like logo won't have the tags added.

rph wrote: The proper method would be for the controller to pass the width and height measurements then have the template put it all together similar to how alt and title tags work. Something like:

Code: Select all

<img src="<?php echo $thumb; ?>" width="<?php echo $width; ?>" height="<?php echo $height; ?>" alt="<?php echo $heading_title; ?>" />

<img src="<?php echo $product['thumb']; ?>" width="<?php echo $width; ?>" height="<?php echo $height; ?>" alt="<?php echo $product['name']; ?>" />

<file name="/catalog/controller/module/bestseller.php">	
	<operation>
      <search position="after"><![CDATA[
	  $image = $this->model_tool_image->resize($result['image'], $setting['image_width'], $setting['image_height']);
      ]]></search>
      <add><![CDATA[
	   $this->data['width'] = $setting['image_width'];
	   $this->data['height'] = $setting['image_height'];
	  ]]></add>
    </operation>
	</file>

MaryMary wrote:all my products in my opencart sites in my google merchant acct are suspended cause of this problem

Qphoria wrote:According to Google Page Speed tips. One tip is for web pages to include the width/height tags in the rendered html.
http://code.google.com/speed/page-speed ... Dimensions

So I did some playing with regex on the output code and it seems to be working.
This code will automatically generate the image size tags and insert them into every img tag in your page to comply with the Google Page Speed image tips automatically.

Not sure of the overall performance hit but it works. YMMV:

1. EDIT: system/library/response.php
2. FIND:

Code: Select all

if ($this->level) {

3. BEFORE, ADD:

Code: Select all

//Q: Add width/height tags to all images for Google Page Speed tip:
	        //http://code.google.com/speed/page-speed/docs/rendering.html#SpecifyImageDimensions
	        preg_match_all('/<img[^>]+>/i', $this->output, $result);

	        $img = array();
	        foreach($result[0] as $img_tag) {
	            preg_match_all('/(width|height|src)=("[^"]*")/i',$img_tag, $img[$img_tag]);
	        }

	        foreach ($img as $k => $info) {
	            if (count($info) == 3 && $info[1][0] == 'src') {
					//if (curl_init(str_replace('"', '', $info[2][0]))) {
					$imgfile = str_replace('"', '', $info[2][0]);
					$imgfile = str_replace(HTTP_SERVER, DIR_IMAGE . '../', $imgfile);
					$imgfile = str_replace(HTTPS_SERVER, DIR_IMAGE . '../', $imgfile);
	                if (file_exists($imgfile)) {
	                    $image_info = getImageSize(str_replace('"', '', $imgfile));
	                    $k = trim($k, '/>');
	                    $k = trim($k, '>');
	                    $this->output = str_replace($k, ($k . ' ' . $image_info[3]), $this->output);
	                }
	            }
	        }
	        //