Post by JNeuhoff » Mon Dec 02, 2019 9:58 pm

The OpenCart marketplace needs a better vetting process and quality control.

We have come across so many poorly written extensions it's not funny anymore. One recent example is the Purpletree Multi-Vendor which has promising features. But it's underlying PHP-code looks like spaghetti to me (see attached screenshot before.png), where simple proper line indentations can make such a difference (see attached screenshot after.png).

Also, OpenCart has been supporting event handlers for quite a while now, yet the vast majority of extensions still rely on OCmod or VQmod based modification systems (where an XML notification describes modifications to be applied to OpenCart PHP core files).

The worst area are the so-called web themes, hardly any of them abide by the simple OpenCart standards for themes, see this forum thread.

Attachments

before.png

spaghetti code - before.png (136.11 KiB) Viewed 840 times

after.png

cleaned up code - after.png (128.74 KiB) Viewed 840 times


MHC Web Design
Override Engine * Integrated VQMod * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Rich Snippets * Google Tag Manager * Export/Import Tool * SpamBot Buster


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by IP_CAM » Mon Dec 02, 2019 11:21 pm

It all starts much earlier, so better don't blame the Followers ... :laugh:
https://www.opencart.com/index.php?rout ... n_id=32694

Please don't send me OC Forum Personal Messages, just contact: jti@jacob.ch
---
OC 1.5.6.5 LIGHT Test Site: http://www.bigmax.ch/shop/
OC 1.5.6.5 V-PRO Test Site: http://www.jacob.ch/shop/
My Github OC Site: https://github.com/IP-CAM
2'450+ FREE OC Extensions from the World's largest Github OC Repository Archive Site.


User avatar
Legendary Member

Posts

Joined
Tue Mar 04, 2014 1:37 am
Location - Switzerland

Post by purpletreesoft » Thu Dec 19, 2019 2:23 pm

JNeuhoff wrote:
Mon Dec 02, 2019 9:58 pm
The OpenCart marketplace needs a better vetting process and quality control.

We have come across so many poorly written extensions it's not funny anymore. One recent example is the Purpletree Multi-Vendor which has promising features. But it's underlying PHP-code looks like spaghetti to me (see attached screenshot before.png), where simple proper line indentations can make such a difference (see attached screenshot after.png).

Also, OpenCart has been supporting event handlers for quite a while now, yet the vast majority of extensions still rely on OCmod or VQmod based modification systems (where an XML notification describes modifications to be applied to OpenCart PHP core files).

The worst area are the so-called web themes, hardly any of them abide by the simple OpenCart standards for themes, see this forum thread.
Hi @JNeuhoff, You had raised this issue with us in the recent past in a ticket using our helpdesk. Then you posted a public comment about this, and now you have made this forum posting. Every time we gave you a positive reply, but you are not stopping and keeping on posting this everywhere. We can only assume all of your posting are in good faith, though they suggest otherwise, because our extension has not caused any serious issue like security etc for your shop.
The issue you had mentioned, about the code style, we had already acknowledged it and informed you about the future course of action. We believe this is not a deal breaker for you, and not an immediate threat to your shop's existence. We are committed to keep on solving any issues as we move forward.
Then your statements about OCmod vs Events, we hope you are aware, that not all changes can be covered using events, especially when it is about making changes in view and not in controller. So what you said is not fully correct.

Purpletree Software LLP
New features launched for Multivendor Marketplace Extension


User avatar
New member

Posts

Joined
Thu Jun 22, 2017 10:17 pm


Post by JNeuhoff » Fri Dec 20, 2019 8:45 pm

@purpletreesoft :

Thank you for your reply. As we also said, your multi-vendor extension has useful features which will appeal to many users. And we are happy to send you a list of all the bugfixes we have implemented so far for your extension.

However, your code is very difficult to read, and like so many other 3rd party extensions, makes heavy use of OCmod-XML based modifications of OpenCart core files. OpenCart 3.x supports event handlers. No other popular framework that we know of uses such a strange system of XML-based modifications for framework core files. XML is a markup language that defines a set of rules for encoding documents in a format that is both human-readable and machine-readable. It is not meant to be a programming language.

IMHO future OpenCart releases should get rid of OCmod altogether, this will force 3rd part developers to clean up their messy code.

MHC Web Design
Override Engine * Integrated VQMod * Unused Images Manager * Instant Option Price Calculator * Number Option * Google Rich Snippets * Google Tag Manager * Export/Import Tool * SpamBot Buster


User avatar
Expert Member

Posts

Joined
Wed Dec 05, 2007 3:38 am


Post by purpletreesoft » Wed Jan 15, 2020 2:37 pm

JNeuhoff wrote:
Fri Dec 20, 2019 8:45 pm
@purpletreesoft :

Thank you for your reply. As we also said, your multi-vendor extension has useful features which will appeal to many users. And we are happy to send you a list of all the bugfixes we have implemented so far for your extension.

However, your code is very difficult to read, and like so many other 3rd party extensions, makes heavy use of OCmod-XML based modifications of OpenCart core files. OpenCart 3.x supports event handlers. No other popular framework that we know of uses such a strange system of XML-based modifications for framework core files. XML is a markup language that defines a set of rules for encoding documents in a format that is both human-readable and machine-readable. It is not meant to be a programming language.

IMHO future OpenCart releases should get rid of OCmod altogether, this will force 3rd part developers to clean up their messy code.
Thanks, it will be nice if you can share the details of modifications you made, at our email id support@purpletreesoftware.com .
Regarding Ocmod, yeah we agree it is not a pretty thing, and XML is not meant to be used like this. We hope Opencart takes some step for this, and we will surely follow suit.

Purpletree Software LLP
New features launched for Multivendor Marketplace Extension


User avatar
New member

Posts

Joined
Thu Jun 22, 2017 10:17 pm


Post by timstudio » Fri Jan 17, 2020 5:16 pm

As a fulltime opencartshop owner the best advice I can give users to search for a good independent developer. I made the mistake too many times to have an extension installed or a problem fixed by the developer himself. That often resulted in a fix 'covering up' the problem but creating a bunch of new problem which are disregarded as 'contact that developer.' Then you get in an endless loop. I also had a developer install a bunch of unwanted additional crap. Security scanners, custom installers etc. Removing it killed my admin. Also there are a lot of extension that, once installed, turn out to have a update subscription and loose functionality unless you pay a 6 months fee (triple the amount of the exention initial costs.)

Most of my problems went away after I found (trial and error) a good independent developer. One man that fixes problems as they should be fixed. It took me several attempts to find one. Stick with that guy.

New member

Posts

Joined
Sun Oct 25, 2015 3:51 pm

Post by cyclops12 » Fri Jan 17, 2020 7:03 pm

timstudio wrote:
Fri Jan 17, 2020 5:16 pm
As a fulltime opencartshop owner the best advice I can give users to search for a good independent developer. I made the mistake too many times to have an extension installed or a problem fixed by the developer himself. That often resulted in a fix 'covering up' the problem but creating a bunch of new problem which are disregarded as 'contact that developer.' Then you get in an endless loop. I also had a developer install a bunch of unwanted additional crap. Security scanners, custom installers etc. Removing it killed my admin. Also there are a lot of extension that, once installed, turn out to have a update subscription and loose functionality unless you pay a 6 months fee (triple the amount of the exention initial costs.)

Most of my problems went away after I found (trial and error) a good independent developer. One man that fixes problems as they should be fixed. It took me several attempts to find one. Stick with that guy.
This seems to be excellent advise and should save alot of time effort and money in the long run

Expert Member

Posts

Joined
Sun Sep 27, 2015 1:10 am

Post by purpletreesoft » Thu Feb 20, 2020 8:05 pm

timstudio wrote:
Fri Jan 17, 2020 5:16 pm
As a fulltime opencartshop owner the best advice I can give users to search for a good independent developer. I made the mistake too many times to have an extension installed or a problem fixed by the developer himself. That often resulted in a fix 'covering up' the problem but creating a bunch of new problem which are disregarded as 'contact that developer.' Then you get in an endless loop. I also had a developer install a bunch of unwanted additional crap. Security scanners, custom installers etc. Removing it killed my admin. Also there are a lot of extension that, once installed, turn out to have a update subscription and loose functionality unless you pay a 6 months fee (triple the amount of the exention initial costs.)

Most of my problems went away after I found (trial and error) a good independent developer. One man that fixes problems as they should be fixed. It took me several attempts to find one. Stick with that guy.
Excellent advice. Actually everyone takes opencart as "easy software" and thinks they can manage it on their own, without having any development knowledge. And then the extension developers etc are also hassled a lot of such customers. It is best that they hire a developer to work on something they do not know about.

Purpletree Software LLP
New features launched for Multivendor Marketplace Extension


User avatar
New member

Posts

Joined
Thu Jun 22, 2017 10:17 pm

Who is online

Users browsing this forum: No registered users and 19 guests