Post by Daniel » Sat Sep 25, 2010 9:08 am

JAY6390 wrote:Well I was just pointing out that it's not 100% separated as an MVC architecture :) To get the menu output requires recursion if it has sub cats, which means you'll always be mixing the C with the V :P

not with 1.5.0. with only 3 category levels max showing there are only 3 loops required.

OpenCart®
Project Owner & Developer.


User avatar
Administrator

Posts

Joined
Fri Nov 03, 2006 6:57 pm

Post by JAY6390 » Sat Sep 25, 2010 6:52 pm

Ah, why the reduction in category levels?

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by Skyhigh » Thu Sep 30, 2010 1:47 am

One question:
Will the theme for 1.5.0 have all it's CSS in external files?

Up to 1.4.9.1 some of the CSS is embedded (e.g. the icons for the module headers for Bestsellers, etc).
Having all the CSS moved to external files will make it easier to skin*.

* It's not a big job, and I'd be happy to do it, even if just for the SEO benefits**, as long as it can be committed to the trunk so it takes effect for future releases.

** Yes, I'm going on about the height-width image issues, again. :)

LoveMoissanite.com - Moissanite Rings - Proudly Powered by Opencart
[How To] Speed Up Page Content with Opencart - Opencart advocate since 2009


New member

Posts

Joined
Fri Sep 11, 2009 8:12 pm

Post by JAY6390 » Thu Sep 30, 2010 1:57 am

Skyhigh wrote:* It's not a big job, and I'd be happy to do it, even if just for the SEO benefits**, as long as it can be committed to the trunk so it takes effect for future releases.
inline styles have no effect on SEO

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by Qphoria » Thu Sep 30, 2010 4:27 am

I believe Daniel said he was aiming to use external css for 1.5.0

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Skyhigh » Fri Oct 01, 2010 3:33 pm

JAY6390 wrote:inline styles have no effect on SEO
Unfortunately wrong, even though my point is very particular - it's still right in terms of SEO :)

Page load speed does have an effect on SEO - so it there's frequently used CSS placed inline that HTML is being re-loaded every time, increasing page size and hence load time* - if all CSS is in external file (cached) it won't be loaded. **
Plus it makes it much easier to re-style.

I was more referring to the fact that many of the images used in the standard theme (which is good looking), don't specify the image Height&Width, for example the icons used in the header titles - which again, Page Speed doesn't like so much.***

Yes, my point is small but so is the removal of inline CSS - and it all helps.
(as I said, I'm happy to edit the theme to remove inline css and commit it to the trunk, I've already done it a fair few times on various versions of OpenCart :))

* Google likes fast sites, as of....about last April
** Yes theres a TINY amount of inline styling in OpenCart, but being a perfectionist and wanting the best, I move it.
*** Yes, although this doesn't affect the actual page load time, giving all images a height&width makes the page 'look' like it loads faster to the user, so its a better all-round experience. Just the same as loading the CSS at the top and JS at the bottom with a jQuery document load wrapper - it all helps.
**** I wanted more stars.

LoveMoissanite.com - Moissanite Rings - Proudly Powered by Opencart
[How To] Speed Up Page Content with Opencart - Opencart advocate since 2009


New member

Posts

Joined
Fri Sep 11, 2009 8:12 pm

Post by JAY6390 » Fri Oct 01, 2010 5:36 pm

There's far more that could be done to reduce code size of a page than removing the small amount of css that's inline. If you have compression set you should notice that the page load speed is practically identical between the inline and non-inline versions. Yes google takes into account page speed, but it's not base on a per microsecond difference. Its weighting on the overall seo will be minimal at best

Image


User avatar
Guru Member

Posts

Joined
Wed May 26, 2010 11:47 pm
Location - United Kingdom

Post by Skyhigh » Fri Oct 01, 2010 8:11 pm

JAY6390 wrote:Its weighting on the overall seo will be minimal at best
Indeed, which is what I said - my main point was to make it easier to re-style the site.
(which would also include setting the height&width's on images, making the user experience better).

Even so, any effect on SEO in a positive way is a good thing, no matter how small :)
(you never know when this weeks 'small thing' could be Googles next 'really important ranking factor')

LoveMoissanite.com - Moissanite Rings - Proudly Powered by Opencart
[How To] Speed Up Page Content with Opencart - Opencart advocate since 2009


New member

Posts

Joined
Fri Sep 11, 2009 8:12 pm

Post by creativa » Fri Oct 01, 2010 11:17 pm

I think, that beyond the graphic style,
would be really helpful have 4 blocks for modules.
To locate items more freely and even to repeat them in several locations.

For example
Image

Also in advance, I am available on what can I help.
(some little time ago, I uploaded a free theme in extensions without inline styles)

Opencart Template Store
Commercial themes: Sweet Rose, Sweet Yellow, Electronic Blue, Electronic Pink and more...
Free theme: Non Inline Css


New member

Posts

Joined
Thu Jul 23, 2009 2:01 pm
Location - Uruguay

Post by OC2PS » Wed Oct 06, 2010 7:44 am

Daniel wrote:
celestial wrote:What happend if i need more categories on the principal home tab menu
you need to split them up into sub ctegories. it will be mega menu style. so there will be 3 levels of categories showing when you haover over the menu.
:o ??? :-[ :'( :'( :'( :'( :'( :'(

OC2PS
OC 2.3.0.2, vQmod 2.6.2, Journal2 theme
Arcfesték, Csillámtetoválás, Henna
Image
Check out: All my extensions | My FREE extensions


User avatar
Active Member

Posts

Joined
Wed Jul 22, 2009 4:15 am
Location - Hungary

Post by ThePath » Wed Oct 06, 2010 9:06 pm

Hi folks Ive not posted for a while, need to make more of an effort! ;)

OK so all the themes posted so far look good.

@Daniel: Personally I would drop the tabs all together. Keep the Home link as part of the horizontal menu and stick all the others in the little accessibility menu at very top or in footer somewhere. Very nice though, Im looking forward to the cool filter/search options. It would be cool if there was an easy way to switch the categories from horizontal to module style! Unless you have a huge amount of main cats then the horizontal way with dropdown is much nicer for me.

With regards to the extra themes in the downloads I agree with Jay. Just have the one default and release any others as freebies in the extensions section. From my experience any serious shop owner will want a bespoke theme anyway.

Also it might be a good idea to seperate out the main download from the modules. So you would have the basic OC install then a pack of additional modules. You could even split them down further into their respective categories.

O0

Image

OpenCart Theme Options - See All My Extensions - OpenCart Themes and Mods


User avatar
Active Member

Posts

Joined
Fri Jun 26, 2009 11:53 pm
Location - Scotland

Post by qahar » Wed Oct 06, 2010 10:49 pm

creativa wrote:I think, that beyond the graphic style,
would be really helpful have 4 blocks for modules.
To locate items more freely and even to repeat them in several locations.
Agree.. :)

User avatar
Expert Member

Posts

Joined
Tue Jun 29, 2010 10:24 pm
Location - Indonesia

Post by Xsecrets » Thu Oct 07, 2010 6:27 am

qahar wrote:
creativa wrote:I think, that beyond the graphic style,
would be really helpful have 4 blocks for modules.
To locate items more freely and even to repeat them in several locations.
Agree.. :)
Q had discussed doing this for 1.4.9 not sure what happened with that.

OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter


Guru Member

Posts

Joined
Sun Oct 25, 2009 3:51 am
Location - FL US

Post by Iwao » Sun Oct 10, 2010 5:17 am

Hello,
When you will have a good template i recomend you to use this website : http://www.conceptfeedback.com/
they have a lot of skilled people that give very good advise.

And for the template system i am learning css and php and i still have no clue on how template a cms or OC, if you have a good tutorial maybe i can make some good template.

Newbie

Posts

Joined
Wed Apr 14, 2010 1:10 am

Post by Qphoria » Wed Oct 13, 2010 9:32 pm

Xsecrets wrote:
qahar wrote:
creativa wrote:I think, that beyond the graphic style,
would be really helpful have 4 blocks for modules.
To locate items more freely and even to repeat them in several locations.
Agree.. :)
Q had discussed doing this for 1.4.9 not sure what happened with that.
I don't understand the idea

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by Xsecrets » Wed Oct 13, 2010 10:26 pm

Qphoria wrote:I don't understand the idea
basically it's the header and footer module spots you had discussed a bit a while back. so that you can put modules horizontally at the top and bottom of the site.

OpenCart commercial mods and development http://spotonsolutions.net
Layered Navigation
Shipment Tracking
Vehicle Year/Make/Model Filter


Guru Member

Posts

Joined
Sun Oct 25, 2009 3:51 am
Location - FL US

Post by Qphoria » Wed Oct 13, 2010 10:52 pm

That is in 1.5.0 already. I believe daniel has done it using CSS so that depending on position, it automagically uses the correct css to make it look right. Haven't looked at the code for that yet. But I guess it works like
If "left or right" use the .box css stuff
if "home" use the .home css stuff
if "footer" use the .footer css stuff

That is at least how the grid/list stuff works and it works quite well. It is a single TPL.. the tpl code doesn't change.. only the css for .grid or .list

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by jones » Thu Oct 14, 2010 12:22 am

I suggest OC 1.5.0 still use one template default as existing. because you can find thousands free OC templates out there then this is also will giving more opportunity for oc commercial theme developers

do you agree with me?

Active Member

Posts

Joined
Tue Aug 24, 2010 1:05 pm

Post by Qphoria » Thu Oct 14, 2010 1:41 am

Yes.. it will be one theme. And if done correctly, it should work as a good base theme for other themes. And really good custom themes should be theme-able with simple CSS and images assuming the html code is good and semantic.

Image
Donate!|OpenCart Basics|GeoZones
Image


User avatar
Administrator

Posts

Joined
Tue Jul 22, 2008 3:02 am

Post by alex1 » Sat Oct 16, 2010 9:50 am

I think this template: http://www.opencart.com/opencart/image/ ... sign_4.png absolutely knocks it out of the ball park. Best looking template for any opensource ecommerce website hands down.

Go with it! I'll eagerly be waiting for 1.5!

Thanks for your hard work!

Alex

Active Member

Posts

Joined
Sat Oct 16, 2010 9:49 am
Who is online

Users browsing this forum: No registered users and 15 guests