OpenCart 3.0.3.7 2x faster and with PHP 5.4 to PHP 8 support

MaxD wrote: ↑

Fri Jun 11, 2021 11:54 am

Nope, there is no any DB mods. To upgrade just overwrite all files except both config.php

glolar wrote: ↑

Mon Oct 11, 2021 5:18 pm

I am about to upload your distribution, to update OC 3.0.2.0, but I noticed you have an /install folder in the distribution. I assume I can ignore that folder (i.e., not upload it), since I am doing an UPGRADE from 3.0.2.0 to 3.0.3.7, correct?

Sygate wrote: ↑

Mon Oct 11, 2021 9:49 pm

I got an error, how can i solve this?
PHP Fatal error: Uncaught Error: Cannot use object of type Registry as array in /home/otikbutik/public_html/system/storage/modification/system/library/template/template.php:12

Sygate wrote: ↑

Mon Oct 11, 2021 9:49 pm

Hi Max,

I got an error, how can i solve this?

PHP Fatal error: Uncaught Error: Cannot use object of type Registry as array in /home/otikbutik/public_html/system/storage/modification/system/library/template/template.php:12

MaxD wrote: ↑

Fri Oct 15, 2021 11:48 pm

glolar wrote: ↑

Mon Oct 11, 2021 5:18 pm

I am about to upload your distribution, to update OC 3.0.2.0, but I noticed you have an /install folder in the distribution. I assume I can ignore that folder (i.e., not upload it), since I am doing an UPGRADE from 3.0.2.0 to 3.0.3.7, correct?

You need to ugrade to 3.0.3.7 in regular way (with original Opencart) and after that upload my distribution (withou install folder and config.php and admin/config.php).

Sygate wrote: ↑

Mon Oct 11, 2021 9:49 pm

I got an error, how can i solve this?
PHP Fatal error: Uncaught Error: Cannot use object of type Registry as array in /home/otikbutik/public_html/system/storage/modification/system/library/template/template.php:12

Hard to say, that is some mod issue. Does that mod works on regular Opencart 3.0.3.7?

JNeuhoff wrote: ↑

Sat Oct 16, 2021 12:37 am

Sygate wrote: ↑

Mon Oct 11, 2021 9:49 pm

Hi Max,

I got an error, how can i solve this?

PHP Fatal error: Uncaught Error: Cannot use object of type Registry as array in /home/otikbutik/public_html/system/storage/modification/system/library/template/template.php:12

Is your website otikbutik.com ? If so, then most likely it won't work with MaxD's version of OC 3.0.3.7 because your are using the Journal3 framework, which is not the same as the OpenCart framework, and which doesn't use a proper standard-compliant web theme.

MaxD wrote: ↑

Sat Oct 16, 2021 3:47 pm

That is not because of Journal. Can you post that template.php here?

<?php
namespace Template;
final class Template {
	private $data = array();
		
	public function add_data($data = false) {
		if (!$this->data) $this->data = $data;
		else $this->data = array_merge($this->data, $data);
	}
	
	public function set($key, $value) {
		$this->data[$key] = $value;
	}
	
	public function render($template) {
		$file = DIR_TEMPLATE . $template . '.tpl';

		if (is_file($file)) {
			extract($this->data);

			ob_start();

			require($file);

			return ob_get_clean();
		}

		throw new \Exception('Error: Could not load template ' . $file . '!');
		exit();
	}	
}

xxvirusxx wrote: ↑

Sat Oct 16, 2021 4:38 pm

Better post the code from here: system/storage/modification/system/library/template/template.php:12

Also more details.
If was clean install or upgrade.

LE.

@MaxD there is some warnings

Code: Select all

2021-10-16 8:49:22 - PHP Unknown:  join(): Passing glue string after array is deprecated. Swap the parameters in \system\storage\cache\twix\journal3_template_journal3_module_master_slider.php on line 113
2021-10-16 8:49:22 - PHP Unknown:  join(): Passing glue string after array is deprecated. Swap the parameters in \system\storage\cache\twix\journal3_template_journal3_module_master_slider.php on line 122
2021-10-16 8:49:28 - PHP Unknown:  join(): Passing glue string after array is deprecated. Swap the parameters in \system\storage\cache\twix\journal3_template_common_header.php on line 30

<?php
namespace Template;
final class Template {
	private $data = array();
		
	public function add_data($data = false) {
		if (!$this->data) $this->data = $data;
		else $this->data = array_merge($this->data, $data);
	}
	
	public function set($key, $value) {
		$this->data[$key] = $value;
	}
	
	public function render($template) {
		$file = DIR_TEMPLATE . $template . '.tpl';

		if (is_file($file)) {
			extract($this->data);

			ob_start();

			require(modification($file));

			return ob_get_clean();
		}

		throw new \Exception('Error: Could not load template ' . $file . '!');
		exit();
	}	
}

Sygate wrote: ↑

Sat Oct 16, 2021 5:14 pm

Hi, It's clean install.

Sygate wrote: ↑

Sat Oct 16, 2021 5:14 pm

I try to made an update and now it gives a language file error

xxvirusxx wrote: ↑

Sat Oct 16, 2021 5:23 pm

Sygate wrote: ↑

Sat Oct 16, 2021 5:14 pm

Hi, It's clean install.

Clean install work just fine with Journal3.

Sygate wrote: ↑

Sat Oct 16, 2021 5:14 pm

I try to made an update and now it gives a language file error

What update?

Give more details.
Words are free...

Sygate wrote: ↑

Sat Oct 16, 2021 5:32 pm

I have installed all files except config files and install folder.

xxvirusxx wrote: ↑

Sat Oct 16, 2021 5:44 pm

Sygate wrote: ↑

Sat Oct 16, 2021 5:32 pm

I have installed all files except config files and install folder.

So isn't clean install as you said....

You just copied all files and folders from MaxD version to your current opencart version.

What OC version was before?
Where was storage path before?
What ocmod extension you have?
You have refreshed ocmod modifications and cleaned theme cache, sase cache, jourlna3 cache?

Sygate wrote: ↑

Sat Oct 16, 2021 6:01 pm

Where was storage path before? outside of public_html

xxvirusxx wrote: ↑

Sat Oct 16, 2021 6:08 pm

Sygate wrote: ↑

Sat Oct 16, 2021 6:01 pm

Where was storage path before? outside of public_html

And you have moved all content from MaxD storage version to your storage folder?

<?php
class ControllerEventLanguage extends Controller {
	public function index(&$route, &$args) {
		$args = array_merge($this->language->data, $args);
	}

	// 1. Before controller load store all current loaded language data
	public function before(&$route, &$output) {
		$this->language->set('backup', $this->language->all());
	}

	// 2. After contoller load restore old language data
//	public function after(&$route, &$args, &$output) {
//		$data = $this->language->get('backup');

//		if (is_array($data)) $this->language->set_all($data);
//	}
}

JNeuhoff wrote: ↑

Sat Oct 16, 2021 7:21 pm

Well, as I said, Journal3 modifies OpenCart core files, including the system/library/template.php, because Journal3 uses its own framework, it's not standard-compliant with OpenCart. Also, the template file you posted appears to be another file anyway, namely the system/library/template/template.php.

Therefore, find out from MaxD whether his version of OpenCart even supports Journal3 at all. And if so, post the correct contents of the template.php here, namely the /home/otikbutik/storage/modification/system/library/template.php !

Or use a proper standard compliant web theme!

<?php
namespace Template;
final class Template {
	private $data = array();
		
	public function add_data($data = false) {
		if (!$this->data) $this->data = $data;
		else $this->data = array_merge($this->data, $data);
	}
	
	public function set($key, $value) {
		$this->data[$key] = $value;
	}
	
	public function render($template) {
		$file = DIR_TEMPLATE . $template . '.tpl';

		if (is_file($file)) {
			extract($this->data);

			ob_start();

			require(modification($file));

			return ob_get_clean();
		}

		throw new \Exception('Error: Could not load template ' . $file . '!');
		exit();
	}	
}

JNeuhoff wrote: ↑

Sat Oct 16, 2021 7:21 pm

Well, as I said, Journal3 modifies OpenCart core files, including the system/library/template.php

            // Journal Theme Modification
            if (defined('JOURNAL3_ACTIVE')) {
                $this->adaptor->set('j3', \Journal3::getInstance());
                $this->adaptor->set('j3s', \Journal3::getInstance()->settings);
            }
		    // End Journal Theme Modification