Apparently there are significant performance increases, see this article - https://kinsta.com/blog/php-7-hhvm-benchmarks/
and it did not change a thing for OC. But since you want to find out,
what's keeping you from trying it out, you won't have to change
anything in the OC configuration.
Ernie
My Github OC Site: https://github.com/IP-CAM
5'200 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
Look at the benchmarks (in the link I posted) they speak for themselves....
I will test it, just didn't want to waste my time in case someone else already had.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Normally, we prefer the Opencart system to run in PHP 5.6.
There may be some bug or error with you run in PHP 7.X.
If you have any question, please feel free to let us know.
Thanks and regards,
Alex
Opencart Team
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Well, those benchmarks do NOT include OpenCart, and I have made a bunch of real-timeLook at the benchmarks (in the link I posted) they speak for themselves....
Tests, by use of my peaked Test OC's, and always packed at least with 2K Products,
and not getting ANY result, better than before. But I am also aware of, that getting an OC
20 products Category GTMetrix Result from 98% up to 99% is not that easy either...
And what counts for me is, what a Visitor gets, and not some theoretical Benchmarks.
However, I cannot speak for latest OC Versions, since I use v.1.5.6.5, but combined
with V.2.x Bootstrap Themes, and PHP 7.0.x will be the End of the Line for this Version,
without changing some of the existing Code. Still, there was no measusable difference
to PHP 5.x, used before, performance-wise, and from a Visitor Point of View.
But I am also aware of the Fact, that some Responsive Themes drop GTMetrix Results
by 15%+ Performance Points, without adding anything else, but themselfs...
As you can see on the image just below...
But for those, using MySql before, the also required change to MySqli is a giant
step upwards, but this has nothing to do with PHP-7 either, just to mention this as well.
There are lots of things, keeping OC from doing, what it could, but as long as
OC Users fill their Pages with all that crab, available in the Extension Sections,
it's just a Dream, to expect an OC to work better, just by changing to PHP 7.2.x.
Ernie
---
Another Theme, and I tried everything, but that's the best I got out of it, so, I dropped it from the list...
---
---
Link to large image:
download/file.php?mode=view&id=34065
My Github OC Site: https://github.com/IP-CAM
5'200 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
# PHP CodeSniffer Compatibility
Test against PHP between version 5.4 - 7.3
Code: Select all
phpcs -p . --extensions=php --standard=PHPCompatibility --runtime-set testVersion 5.4-7.3 --report-summary=./phpcs_compat_summary.txt --report-full=./phpcs_compat_full.txt
Detailed report in attachment.
Quite details report including files, code line and the description.
# PHP CompatInfo
Test command
Code: Select all
php phpcompatinfo.phar analyser:run . --output=phpcompatinfo_result.txt
Conclusion: Requires PHP 5.6.0 (min), PHP 7.0.2 (all)
Detailed report in attachment.
Contain summary for required PHP ext; namespace, class, method enalysis etc
I suggest to take look both result, because in PHP CodeSniffer compatibility report there is errors indicating issue in PHP 7.1 and 7.2
But it was only at certain library and vendor which not all user might use them.
.
PHP 7.2 removed mcrypt extension. Since OC3, mcrypt was replaced, so I guess, it will work fine as well. The functions changed in the newest PHP versions don't affect OC. However, some extensions might be not up to date but from my experience with professional, large extension developers, that should not be a problem.
Try this one instead:davidcropley wrote: I found that OC 3.0.1.1 Would run with php 7.2 but very slowly and I kept getting Server error pop-up.
system/library/encryption.php
should work with most all OC Versions, I guess,
just remove the File End php Tag ?> , if you use OC v.2+ Versions.
( aware of, that I would not need it either, but I like it, like it or not )
My Way of closing doors, just to make real sure, they're locked ...
It seems to have some advantages over other ways of coding aes-xx,
but I'm not capable to judge on such, I just use it, and it works well
up to PHP v.7.2x so far.
Good Luck!
Ernie
Code: Select all
<?php
final class Encryption {
public function encrypt($key, $value) {
$encryption_key = base64_decode($value);
$iv = openssl_random_pseudo_bytes(openssl_cipher_iv_length('aes-256-gcm'));
if (in_array('aes-256-gcm', openssl_get_cipher_methods())) {
$tag = base64_encode($iv);
$encrypted = openssl_encrypt($key, 'aes-256-gcm', $encryption_key, 0, $iv, $tag);
return base64_encode($encrypted . '::' . $iv);
}
}
public function decrypt($key, $value) {
if (in_array('aes-256-gcm', openssl_get_cipher_methods())) {
$encryption_key = base64_decode($value);
list($encrypted_data, $iv) = explode('::', base64_decode($key), 2);
$tag = base64_decode($iv);
return openssl_decrypt($encrypted_data, 'aes-256-gcm', $encryption_key, 0, $iv, $tag);
}
}
}
?>
My Github OC Site: https://github.com/IP-CAM
5'200 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
If you did want an improved system/library/encryption.php, try looking at the two examples here.
viewtopic.php?p=737628#p737628
You might also want to find the right explanation for PHP v7.3+. Unfortunately, both versions may seem to be wrong in this case.ADD Creative wrote: ↑Wed May 01, 2019 12:14 amThat replacement for system/library/encryption.php is just wrong and will never work. You can read my explanation here. viewtopic.php?p=737337#p737337
If you did want an improved system/library/encryption.php, try looking at the two examples here.
viewtopic.php?p=737628#p737628
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Well, in my case, it works perfect up to PHP 7.2x, so,what can I say ?That replacement for system/library/encryption.php is just wrong and will never work.
Ernie
My Github OC Site: https://github.com/IP-CAM
5'200 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
and it seems to work with my latest Server PHP 7.2.17 Version too.
But I have not yet PHP 7.3 on my Server, to make further tests.
Ernie
My Github OC Site: https://github.com/IP-CAM
5'200 + FREE OC Extensions, on the World's largest private Github OC Repository Archive Site.
The code below can be used to test.
Code: Select all
$original_message = 'Test message for encryption';
$encrypted_message = $this->encryption->encrypt($this->config->get('config_encryption'), $original_message);
$decrypted_message = $this->encryption->decrypt($this->config->get('config_encryption'), $encrypted_message);
if ($decrypted_message !== $original_message) {
throw new Exception('Encryption failed');
}
Code: Select all
$this->registry->set('encryption', new Encryption($this->config->get('config_encryption')));
viewtopic.php?p=737628#p737628
The one posted in this topic doesn't.
The addressed post should then be edited to specify the compatibility with PHP 7.3.4 in the mean time to avoid confusion. Also, I have found a pull commit request on GitHub regarding this file as well. Perhaps this may help but I haven't tested it yet: https://github.com/opencart/opencart/pu ... ac85c6074dBoth the two examples posted here work. Tested with PHP 7.3.4.
Dedication and passion goes to those who are able to push and merge a project.
Regards,
Straightlight
Programmer / Opencart Tester
Users browsing this forum: No registered users and 145 guests